Stream: smart/health-cards
Topic: c19.cards reference implementation
Josh Mandel (Apr 15 2021 at 14:47):
Thanks @Matt Printz for noticing some invalid elements in our metadata endpoint --
Josh Mandel (Apr 15 2021 at 14:48):
https://github.com/smart-on-fhir/health-cards-tests/pull/52/files should fix it. FYI @James Kizer because you initially added this content and I just want to make sure you're not depending on those profile elements (which if you do need them should be canonicals rather than references) :-)
Josh Mandel (Apr 15 2021 at 15:01):
https://c19.cards/api/fhir/metadata should be fixed now @Matt Printz
Matt Printz (Apr 15 2021 at 15:15):
@Josh Mandel Connection and fetching is successful. When I run my QRs through the MS Validator though, I do notice the following warnings:
├─ Warning :
| key[7rIUtD5K5Izrptr3ywgESTxhgJtJSeb06V42hg7WUDs]: wrong algorithm in issuer key. expected: 'ES256', actual: ECDH-ES
| key[7rIUtD5K5Izrptr3ywgESTxhgJtJSeb06V42hg7WUDs]: wrong usage in issuer key. expected: 'sig', actual: enc
└─ Warning :
Bundle.entry[1].resource[Immunization] should not include .meta elements
Matt Printz (Apr 15 2021 at 15:24):
Removing dupe
Christian Paquin (Apr 15 2021 at 15:56):
Matt Printz said:
Josh Mandel Connection and fetching is successful. When I run my QRs through the MS Validator though, I do notice the following warnings:
├─ Warning :
| key[7rIUtD5K5Izrptr3ywgESTxhgJtJSeb06V42hg7WUDs]: wrong algorithm in issuer key. expected: 'ES256', actual: ECDH-ES
| key[7rIUtD5K5Izrptr3ywgESTxhgJtJSeb06V42hg7WUDs]: wrong usage in issuer key. expected: 'sig', actual: enc
└─ Warning :
Bundle.entry[1].resource[Immunization] should not include .meta elements
The validation SDK warns if some keys in the issuer JWK key set are not valid to issue health cards; it's ok to have them in the key set as long as the correct one is in there as well, but we warn about it anyway to be explicit. The spec only allows meta.securityas of v0.4.4 (released yesterday), the latest SDK version accepts these as well; make sure you have the latest version.
James Kizer (Apr 15 2021 at 16:24):
No, we're not depending on those. Thanks for checking
Matt Printz (Apr 15 2021 at 16:49):
@Josh Mandel I'm getting FHIR validation errors on one of the cards returned:
Via Python:
Wrong type <class 'fhirclient.models.fhirreference.FHIRReference'> for list property "performer" on <class 'fhirclient.models.diagnosticreport.DiagnosticReport'>, expecting a list of <class 'fhirclient.models.fhirreference.FHIRReference'>
Via the MS Validator:
└─ Error :
Schema: {"keyword":"type","dataPath":"/performer","schemaPath":"#/properties/performer/type","params":{"type":"array"},"message":"should be array"}
Data:
"performer": {
"display": "Dr. Jones"
},
Josh Mandel (Apr 15 2021 at 17:02):
Thanks for this note! Been so focused on immunizations that I haven't given the diagnostic reports a proper validation. Will fix.
Josh Mandel (Apr 15 2021 at 17:52):
Just merged a fix; should be deployed in ~5min
Last updated: Apr 12 2022 at 19:14 UTC
