Stream: svc
Topic: github access
Giorgio Cangioli (Mar 31 2021 at 09:12):
Hi @Carl Leitner I fixed some QA errors and warning and I tried to push them in a branch.
Giorgio Cangioli (Mar 31 2021 at 09:13):
this is the message returned
remote: Permission to who-int/svc.git denied to gcangioli.
fatal: unable to access 'https://github.com/who-int/svc.git/': The requested URL returned error: 403
Giorgio Cangioli (Mar 31 2021 at 12:05):
maybe @Natschja Ratanaprayul you can help me on this....
Natschja Ratanaprayul (Mar 31 2021 at 14:30):
hrmmm you should already have access....will defer to @Carl Leitner
Carl Leitner (Mar 31 2021 at 14:30):
@Giorgio Cangioli maybe because the rename of the github repos? it should be able to be accessed...
Carl Leitner (Mar 31 2021 at 14:30):
https://github.com/who-int/svc-ips is the renamed older SVC repo.
Giorgio Cangioli (Mar 31 2021 at 14:42):
I've cloned the /svc repos and made some change on it, but if it is not a problem of grant I'll check if I did anything wrong... :-)
Giorgio Cangioli (Mar 31 2021 at 14:55):
@Carl Leitner , @Natschja Ratanaprayul Please could you check.. because I'm allowed to create branches from the GitHub Web GUI in 'svc-ips' repos, but not in the 'svc' one...
Carl Leitner (Mar 31 2021 at 14:58):
@Giorgio Cangioli i just gave you triage access... is that sufficient?
Carl Leitner (Mar 31 2021 at 14:58):
let me know if you need more
Giorgio Cangioli (Mar 31 2021 at 15:04):
mmmhh.. I don't see any change ... still not able to create branches with the GitHub Web GUI...or pushing my changes
Giorgio Cangioli (Mar 31 2021 at 15:06):
"Triage: Recommended for contributors who need to proactively manage issues and pull requests without write access"
Giorgio Cangioli (Mar 31 2021 at 15:08):
is this enough for pushing changes in a branch ?
Carl Leitner (Mar 31 2021 at 15:09):
it says "manage pull requests" so I assume manage includes enough access. if not, i'll bump you up to maintain.
Giorgio Cangioli (Mar 31 2021 at 15:18):
In fact now I should be able to create Pull requests based on what has been pushed in the repos...
Giorgio Cangioli (Mar 31 2021 at 15:18):
but I've no write capabilities...
Giorgio Cangioli (Mar 31 2021 at 15:18):
so It seems I cannot push my changes
Carl Leitner (Mar 31 2021 at 15:19):
try now? I gave you maintain...
Carl Leitner (Mar 31 2021 at 15:19):
(sorry on a call, so multi-tasking slowly)
Giorgio Cangioli (Mar 31 2021 at 15:20):
no problems ... I'm too in another call :-)
Giorgio Cangioli (Mar 31 2021 at 15:21):
:tada:
Giorgio Cangioli (Mar 31 2021 at 15:22):
now it works !
Carl Leitner (Mar 31 2021 at 15:22):
sorry for the hassles. glad it's working.
Carl Leitner (Mar 31 2021 at 15:23):
also... have you seen https://who-int.github.io/svc/refs/heads/qr-encoding/artifacts.html
I think some of the comments you raised on RC1 will be clarified there (e.g. one vaccine code should be constrained to 1..1 when QR encoded, but not when linked back to something more IPS-like)
Carl Leitner (Mar 31 2021 at 15:24):
(running into so IG publisher issues, so not as far along as I hoped)
Giorgio Cangioli (Mar 31 2021 at 16:18):
added two pull requests.. see what you think it might be useful..
Carl Leitner (Mar 31 2021 at 16:35):
Took a look. A couple of questions.... 1) I saw you put in the 'pre-adopted' IPS in one of the pull requests. What would be the best way on making sure that the SVC repo is up to date from where the source of this is (assuming it is elsewhere)? Would you just pull in any updates as needed? 2) I created an new rc2 branch from main + some qr-encoding stuff. Would it be possible to make your pull request against rc2 rather than main?
https://github.com/who-int/svc/tree/rc2
Giorgio Cangioli (Apr 01 2021 at 07:51):
done .. https://github.com/who-int/svc/pull/29
Giorgio Cangioli (Apr 01 2021 at 07:55):
BTW, There are some design choices I'm not able to fully understand.
I've no proposed changes however, because maybe there are presets I'm not aware of..
Giorgio Cangioli (Apr 01 2021 at 08:02):
few examples there are a lot of abstract profiles.. this means that they are not supposed to be instantiated, but for some of them I don't understand why...(e.g. svc-immunization si abstract but referred by the composition that I suppose it will be instantiated)
Giorgio Cangioli (Apr 01 2021 at 08:07):
why the protocolApplied is sliced and the slice is made on the type:authority, where the authority can be only of type Organization and so on..
Carl Leitner (Apr 01 2021 at 11:01):
the abstract may be left over from previous versions, i'll take a look. some of it may be just mistakes on my side (so any pointers would help)
Carl Leitner (Apr 01 2021 at 11:01):
mistakes/not knowing a better way to do it
Carl Leitner (Apr 01 2021 at 16:32):
Flagging for @Luke Duncan
Last updated: Apr 12 2022 at 19:14 UTC
