FHIR Chat · Connectathon Cancer PlanDefinition Feedback · medmorph

Stream: medmorph

Topic: Connectathon Cancer PlanDefinition Feedback

view this post on Zulip Benjamin Langley (May 10 2021 at 13:32):

@Nagesh Bashyam I ran the cancer PlanDefinition through the FHIR validator this morning and got these errors back. I'm assuming KAR will update the URLs to be resolvable but all of the action input/output profiles need to be arrays instead of just a single string

*FAILURE* validating medmorph/medmorph-backend/public/resources/cancer-knowledge-artifact.json:  error:13 warn:0 info:0
  Error @ Bundle.entry[0].resource.url (line 69, col100) : URL value "http://hl7.org/fhir/us/medmorph/StructureDefinition/plandefinition-cancer-example" does not resolve
  Error @ Bundle.entry[0].resource.relatedArtifact[0].resource (line 95, col12) : URL value "http://hl7.org/fhir/us/medmorph/ValueSet/valueset-cancer-trigger-codes-example" does not resolve
  Error @ Bundle.entry[0].resource.action[1].input[0].codeFilter[0].valueSet (line 176, col20) : URL value "http://hl7.org/fhir/us/medmorph/ValueSet/valueset-cancer-trigger-codes-example" does not resolve
  Error @ Bundle.entry[0].resource.action[2].input[0].profile (line 205, col16) : This property must be an Array, not a a primitive property
  Error @ Bundle.entry[0].resource.action[2].input[1].profile (line 209, col16) : This property must be an Array, not a a primitive property
  Error @ Bundle.entry[0].resource.action[2].input[2].profile (line 213, col16) : This property must be an Array, not a a primitive property
  Error @ Bundle.entry[0].resource.action[2].input[3].profile (line 217, col16) : This property must be an Array, not a a primitive property
  Error @ Bundle.entry[0].resource.action[2].input[4].profile (line 221, col16) : This property must be an Array, not a a primitive property
  Error @ Bundle.entry[0].resource.action[2].output[0].profile (line 227, col16) : This property must be an Array, not a a primitive property
  Error @ Bundle.entry[0].resource.action[3].input[0].profile (line 254, col16) : This property must be an Array, not a a primitive property
  Error @ Bundle.entry[0].resource.action[3].output[0].profile (line 260, col16) : This property must be an Array, not a a primitive property
  Error @ Bundle.entry[0].resource.action[4].input[0].profile (line 287, col16) : This property must be an Array, not a a primitive property
  Error @ Bundle.entry[1].resource.url (line 323, col97) : URL value "http://hl7.org/fhir/us/medmorph/ValueSet/valueset-cancer-trigger-codes-example" does not resolve

view this post on Zulip Nagesh Bashyam (May 10 2021 at 13:41):

Benjamin
Thanks for pointing out the erors, will fix it and repost the PlanDefinitions.

view this post on Zulip Dylan Hall (May 11 2021 at 15:03):

@Nagesh Bashyam I sent this in an email but repeating for posterity here - is the check-trigger-codes action in the cancer PlanDefinition intended to have key fields such as code and input nested inside of a sub-action, rather than at the top level?

          {
            "id": "check-trigger-codes",
            "description": "This action represents the execution of the checking trigger codes in the  workflow.",
            "textEquivalent": "Check Trigger Codes",
            "action": [
              {
                "code": [... ],
                "condition": [...],
                "input": [...],
                "relatedAction": [...]
              }
            ]
          }

view this post on Zulip Benjamin Langley (May 11 2021 at 18:50):

I too think they should at the top level. I don't really think sub-actions make sense unless both the parent action and the sub action are "complete". If a single action can have properties defined in sub actions (i.e. code) then it opens the door to defining an action in an arbitrary number of sub actions instead of all top level

view this post on Zulip Nagesh Bashyam (May 12 2021 at 11:18):

Dylan,
I think sub-actions make it complex like Benjamin said, so I will rework it to remove the sub-actions.
Although we should discuss during the connectathon if we should prevent it all together or should we allow for sub-actions.
Something to discuss further.

view this post on Zulip Nagesh Bashyam (May 12 2021 at 11:18):

Benjamin,
The latest versions on the track page should have these things fixed. Please check it and let us know.

view this post on Zulip Nagesh Bashyam (May 12 2021 at 11:19):

Sorry I meant to say that the validation errors should be fixed now and uploaded to the track page.

view this post on Zulip Dylan Hall (May 12 2021 at 13:26):

Great thanks! It shouldn't require significant rework, just bring those few fields up to the top level. And I agree there can be use cases where nested actions make sense, but like Ben said I would expect the top-level action and any sub actions to all be individually complete. Happy to discuss further at one of the upcoming calls.

Last updated: Apr 12 2022 at 19:14 UTC


An HL7 Website -