FHIR Chat · saner-ig is now fhir-saner · Covid-19 Response

Stream: Covid-19 Response

Topic: saner-ig is now fhir-saner


view this post on Zulip Keith Boone (Apr 07 2020 at 04:53):

The saner-ig repo has moved:

  1. We cloned http://github.com/AudaciousInquiry/fhir-saner from http://github.com/hl7/fhir-saner
  2. Merged http://github.com/AudaciousInquiry/saner-ig into http://github.com/AudaciousInquiry/fhir-saner
  3. Transferred issues from saner-ig to fhir-saner
  4. updated saner-ig wiki and .md files to point users to the new locations
  5. revoked commit priveledges from saner-ig
  6. are sending out invites for fhir-saner for all committers in http://github.com/fhir-saner
  7. turned off the CI-build on saner-ig
  8. will be updating templates and revising content to address transition
  9. will be completing a pull request shortly with all changes.

And then getting back to the real work!

view this post on Zulip Grahame Grieve (Apr 07 2020 at 04:59):

hey Keith, the CI build shows a lot of quality problems.. it feels to me like they're slipping out of control

view this post on Zulip Keith Boone (Apr 07 2020 at 06:32):

No, it's actually because of automation that I'm fixing, and repetition of one particular error where we are following Lloyd's advice on coding system for FHIR Paths, but the build is barfing on building URIs, and so there's a lot of repeated errors of same type.

view this post on Zulip Keith Boone (Apr 07 2020 at 06:39):

Plus, I just switched over to HL7 url scheme, but didn't update it everywhere for profiles and examples, so all references are broken.

view this post on Zulip Grahame Grieve (Apr 07 2020 at 06:48):

the errors I am concerned about:

  • qty-3: If a code for the unit is present, the system SHALL also be present [code.empty() or system.exists()]
  • The scoring system in this measure is unknown, so the measureScore values cannot be checked
  • Coding.system must be an absolute reference, not a local reference
  • The display "COVID-19" is not a valid display for the code...
  • Unable to resolve resource "...
  • A code with no system has no defined meaning. A system should be provided
  • An expression or a reference must be provided [expression.exists() or reference.exists()]

view this post on Zulip Grahame Grieve (Apr 07 2020 at 06:48):

one particular error where we are following Lloyd's advice on coding system for FHIR Paths

uh?

view this post on Zulip Keith Boone (Apr 07 2020 at 08:02):

Yep, those are the systematic ones that I'm fixing in swathes. My local is down to about 38 errors right now.

view this post on Zulip Keith Boone (Apr 07 2020 at 08:10):

And I cannot alter HL7/fhir-saner setting to configure CI/CD, so I'll do it on the AudaciousInquiry/fhir-saner fork for now.

view this post on Zulip Grahame Grieve (Apr 07 2020 at 09:01):

great - thanks

view this post on Zulip Robert McClure (Apr 07 2020 at 15:09):

@Keith Boone If you need any help with the coding and code system errors and you think I can help, let me know.

view this post on Zulip Josh Mandel (Apr 07 2020 at 18:12):

Keith Boone: And I cannot alter HL7/fhir-saner setting to configure CI/CD, so I'll do it on the AudaciousInquiry/fhir-saner fork for now.

@Keith Boone do you need permissions? Let's get this fixed.

view this post on Zulip Josh Mandel (Apr 07 2020 at 18:13):

I've set you as admin on https://github.com/HL7/fhir-saner/settings/access

image.png

view this post on Zulip Michael Donnelly (Apr 08 2020 at 23:17):

If someone can't see that page, does that mean they aren't a contributor?

view this post on Zulip Vassil Peytchev (Apr 08 2020 at 23:30):

I think it means you are not an admin. I think contributors start at https://github.com/HL7/fhir-saner/

view this post on Zulip Josh Mandel (Apr 09 2020 at 02:40):

The wiki is throwing me off -- lots of duplicated content across the two repos (I accidentally pasted Gino's notes into the wrong wiki earlier today). Is the plan to remove the content from the old location and replace with links to content in the new location?

view this post on Zulip Keith Boone (Apr 10 2020 at 01:23):

Josh Mandel said:

The wiki is throwing me off -- lots of duplicated content across the two repos (I accidentally pasted Gino's notes into the wrong wiki earlier today). Is the plan to remove the content from the old location and replace with links to content in the new location?

Yes. By open of work Monday. There are still social links point to the current content, and I wasn't sure I got all of it. But there may be another solution that works. Let me look.

view this post on Zulip Keith Boone (Apr 10 2020 at 04:39):

OK, I renamed the Old report to saner-ig-old so we don't lose content we may have missed in transition, AND created a new pretty empty repo with the old name that just points people to the new Repo to address broken links.

view this post on Zulip Josh Mandel (Apr 10 2020 at 18:09):

From https://github.com/audaciousinquiry/fhir-saner...

image.png

this is the other challenge: it looks like the "official" HL7 repo is not the place we want people to look at, or report issues to, etc.

view this post on Zulip Josh Mandel (Apr 10 2020 at 18:10):

I don't see how we're going to deliver on the principle of not confusing developers.


Last updated: Apr 12 2022 at 19:14 UTC