Stream: shorthand
Topic: template = #ig-template
Keith Boone (Mar 25 2020 at 04:13):
When I use:
template = #ig-template
in my ig.ini to work with my local template, sushi fails to transfer it.
See https://github.com/HL7/fhir-shorthand/issues/51
Chris Moesel (Mar 25 2020 at 12:22):
I've responded on the GitHub issue.
Jose Costa Teixeira (Mar 25 2020 at 14:57):
I haven't seen the # notation. Doesn't seem right
Jose Costa Teixeira (Mar 25 2020 at 14:58):
local templates are referred by the folder name.
the # is only used for versions e.g. template=base.fhir.template#0.0.1
Jose Costa Teixeira (Mar 25 2020 at 14:59):
@Lloyd McKenzie can confirm
Jose Costa Teixeira (Mar 25 2020 at 15:02):
(it is not very unlikely that I miss something, but I don't expect a hash there, and I can confirm it is not needed for the local templates)
Lloyd McKenzie (Mar 25 2020 at 15:06):
Confirm that #[local-path] is correct when you're not specifying an absolute path or package id
Chris Moesel (Mar 25 2020 at 15:38):
Yeah, I was in the same camp as @Jose Costa Teixeira -- in that I was not aware that # as the _leading character_ was valid. Because many ini parsers (including the one we use) treats # as a comment indicator, we have to jump through some hoops to support ini files where # is significant. But we'll fix it.
Jose Costa Teixeira (Mar 25 2020 at 15:42):
in the IG .ini, the # is also a comment initiator. I would not figure that out.
[local-path] without the # also works (at least worked until recently).
Jose Costa Teixeira (Mar 25 2020 at 15:43):
I'd kill that # if not needed. And I volunteer to update the docs if that makes tools simpler
Chris Moesel (Mar 25 2020 at 15:44):
Yeah, we already have some code in there to support the use of # specifically for the value of template -- but we assume the value is nameOrPath#version -- so just #nameOrPath doesn't parse right. Everywhere else we treat # as a comment.
Lloyd McKenzie (Mar 25 2020 at 15:44):
Right now, the # is needed. And I doubt Grahame wants to fuss with changing it at the moment
Lloyd McKenzie (Mar 25 2020 at 15:45):
You can submit a change request to suggest a revamp later
Jose Costa Teixeira (Mar 25 2020 at 15:50):
I meant "i'd kill that # if not needed and it's easy to kill". so we don't have to take it out from the IG publisher.
but if it is not strictly needed, @Chris Moesel can you simply not support it?
Chris Moesel (Mar 25 2020 at 19:50):
@Jose Costa Teixeira -- Lloyd indicated above that it is needed, so I don't think that "not supporting it" is really a viable option right now...
Jose Costa Teixeira (Mar 25 2020 at 20:22):
Big apologies. I was using local templates on the same folder as the ig, so I never needed it. I just confirmed that for relative paths it is needed. Sorry, and yes, we must keep it
Last updated: Apr 12 2022 at 19:14 UTC
