FHIR Chat · fsh-generated in .gitignore

Stream: shorthand

Topic: fsh-generated in .gitignore

John Keyes (Nov 30 2020 at 22:01):

From reading previous messages here, it seems that it is ok for me to have fsh-generated in my .gitignore? I am trying to figure out why the auto-builder CI process does not run a build for my fsh-based draft IG, and I wondered whether it was because I .gitignore the fsh-generated directory.

Gino Canessa (Nov 30 2020 at 22:04):

It's fine to exclude fsh-generated via .gitignore; the CI build process generates it when run.

Lloyd McKenzie (Nov 30 2020 at 22:38):

John's got an IG where the hook is triggering, but the build isn't running. Because it's FSH, I can't really diagnose what's wrong - so if anyone can take a look at his IG, that'd be awesome...

John Moehrke (Nov 30 2020 at 22:40):

I could look, but don't know what github repo to look at

Gino Canessa (Nov 30 2020 at 22:41):

Looks like https://github.com/HL7/fhir-patient-correction

Chris Moesel (Nov 30 2020 at 22:51):

What's the repo and how do you know that the auto build is getting triggered? I don't see any recent notifications in the ig-build stream that are obviously from John. And it also seems like the FHIR IG Builds index is down? (@Josh Mandel -- did that page change?)

Lloyd McKenzie (Nov 30 2020 at 22:52):

I'm seeing the hook notifications claiming success in Git.

Lloyd McKenzie (Nov 30 2020 at 22:52):

The builds page has been down for a few days

Gino Canessa (Nov 30 2020 at 22:52):

Does the CI build work with private repos?

Chris Moesel (Nov 30 2020 at 22:56):

Gino Canessa said:

Does the CI build work with private repos?

That's a good question. Unless the auto-builder is authenticated to GH as a specific user, and that user was specifically granted access to the private repo, I think the clone attempt would fail. That could be the issue if you're using a private repo.

Sarah Gaunt (Nov 30 2020 at 22:58):

Lloyd McKenzie said:

The builds page has been down for a few days

It looks to be back up now.

Chris Moesel (Nov 30 2020 at 23:05):

Not for me. You're talking about this one? https://fhir.github.io/auto-ig-builder/builds.html

Sarah Gaunt (Nov 30 2020 at 23:28):

Yes, weird. Definitely up for me.
image.png

Lloyd McKenzie (Dec 01 2020 at 04:30):

I tried to guess at the URL for the logs for fhir-patient-correction, but no dice. @Josh Mandel, are you able to see what's going on with @John Keyes' build?

John Keyes (Dec 01 2020 at 12:35):

Or the logs could be at https://build.fhir.org/ig/HL7/fhir-patient-correction/branches/master/build.log (master instead of main), but nothing there either. Also, another symptom is that my commits do not get published to committers/notification. Sounds like all this may be because it's a private repo?

Jose Costa Teixeira (Dec 01 2020 at 12:44):

AFAIK private repos don't trigger IG CI build

John Keyes (Dec 01 2020 at 12:50):

Ok, thanks Jose. I'm new to this -- are IG repos generally kept private until they are no longer in draft stage?

Jose Costa Teixeira (Dec 01 2020 at 13:18):

That would be a policy you can define.
Mine /ours are public in draft, as soon as we have a first logical models or some content for discussion within the group. The CI build is (to me) for discussion

Gino Canessa (Dec 01 2020 at 18:04):

Just talked this over with Josh - CI builds do not work on private repos (and he is adding a note about it). The rationale is that the CI builds are all public, so taking a private repo and publishing it would be a privacy/security issue.