FHIR Chat · SUSHI adding base definition summary? · shorthand

Stream: shorthand

Topic: SUSHI adding base definition summary?


view this post on Zulip Jean Duteau (Aug 26 2020 at 00:15):

I have a profile based on the vitalsigns profile and it appears that SUSHI is bringing over the summary from the base profile into my profile. Here is what SUSHI creates:

{
  "resourceType": "StructureDefinition",
  "id": "ibm-fda-icsr-patientlastmenstrualperiod",
  "extension": [
    {
      "url": "http://hl7.org/fhir/StructureDefinition/structuredefinition-summary",
      "valueMarkdown": "\"#### Complete Summary of the Mandatory Requirements\n\n1.  One status in `Observation.status`which has a [required](http://build.fhir.org/terminologies.html#extensible) binding to:\n    -    [ObservationStatus] value set.\n1.  A category in `Observation.category` which must have:\n    -   a fixed `Observation.category.coding.system`=\"http://terminology.hl7.org/CodeSystem/observation-category\"\n    -   a fixed `Observation.category.coding.code`= \"vital-signs\"\n\n1.  A code in `Observation.code`\n    -   a fixed `Observation.code.coding.system`= \"http://loinc.org\"\"\n    -   a LOINC code in `Observation.code.coding.code` which has an [extensible](http://build.fhir.org/terminologies.html#extensible) binding to:\n         -   [Vital Signs] value set.\n                \n1.  One patient in `Observation.subject`\n1.  A date and time in `effectiveDateTime` or `effectivePeriod`\n1.  Either one `Observation.value[x]` or, if there is no value, one code in `Observation.DataAbsentReason`\n    -   if a vital sign measure then:\n        -  One numeric value in Observation.valueQuantity.value\n        - a fixed Observation.valueQuantity.system=\"http://unitsofmeasure.org\"\n        - a UCUM unit code in Observation.valueQuantity.code which has an required binding to the [Vital Signs Units] value set.\n    -   Observation.DataAbsentReason is bound to [Observation Value\n        Absent Reason] value set.\n\n1.  When using a panel code to group component observations (Note: See\n    the comments regarding blood pressure in the table above), one or\n    more `Observation.component.code` each of which must have:\n    -   a fixed\n        `Observation.component.code.coding.system` =\"\"http://loinc.org\"\"\n         -   a LOINC code in `Observation.code.coding.code` which has an [extensible] binding to:\n             -   [Vital Signs Units] value set.\n\n1.  Either one `Observation.component.valueQuantity` or, if there is\n    no value, one code in `Observation.component.DataAbsentReason`\n    -   Observation.component.DataAbsentReason is bound to [Observation\n        Value Absent Reason] value set.\n\n1.  When using a panel code to group observations, one or more reference\n    to Vitals Signs Observations in `Observation.related.target`\n    -   a fixed `Observation.related.type`= \"has-member\"\"\n\n [Vital Signs]: valueset-observation-vitalsignresult.html\n  [Vital Signs Units]: valueset-ucum-vitals-common.html\n  [extensible]: terminologies.html#extensible\n  [ObservationStatus]: valueset-observation-status.html\n [Observation Value Absent Reason]: valueset-data-absent-reason.html\n[required]: terminologies.html#required\""
    }
  ],
  "url": "http://ibm.com/fhir/fda/icsr/StructureDefinition/ibm-fda-icsr-patientlastmenstrualperiod",
...

view this post on Zulip Jean Duteau (Aug 26 2020 at 00:16):

I haven't seen the behaviour that I'm getting so I'm wondering if this is something new that I'm getting since updating SUSHI?

In any case, I'm pretty sure that it shouldn't be doing this

view this post on Zulip Jean Duteau (Aug 26 2020 at 00:17):

see the discussion here where we tracked down who was doing the weirdness: https://chat.fhir.org/#narrow/stream/179252-IG-creation/topic/Bad.20links.20in.20Vital.20Signs.20derived.20profiles

view this post on Zulip Nick Freiter (Aug 26 2020 at 11:32):

You're right that this behavior is new, SUSHI used to ignore all extensions on the base profile. But, we changed that in 0.15.0 by making it so that only selected extensions were not inherited. This was done because we had an issue about it, and there was a conversation about it on zulip.

From that discussion you linked though, it sounds like we need to add another extension to our list of extensions not to inherit.

view this post on Zulip Nick Freiter (Aug 26 2020 at 11:35):

Logged here: https://github.com/FHIR/sushi/issues/582

view this post on Zulip Jean Duteau (Aug 26 2020 at 15:38):

Is there a way in the meantime to override the inheriting of this specific extension?

view this post on Zulip Chris Moesel (Aug 26 2020 at 16:52):

That's a good question. I was thinking you could use a caret rule to clear the value, but... I don't think FSH actually has a literal representation of an empty array. Arrays are always accessed one item at a time. Which makes deleting arrays (and/or deleting individual elements in arrays) quite difficult, doesn't it?

view this post on Zulip Chris Moesel (Aug 28 2020 at 21:31):

@Jean Duteau -- fixed in SUSHI 0.16.0, just released a few minutes ago!

view this post on Zulip Jean Duteau (Aug 28 2020 at 21:31):

cool, thanks for the responsiveness!


Last updated: Apr 12 2022 at 19:14 UTC