FHIR Chat · Team Notifications · ibm

Stream: ibm

Topic: Team Notifications

Lee Surprenant (Oct 25 2019 at 12:30):

starting this thread as a spot for us to leave important "notifications" for one another

Lee Surprenant (Oct 25 2019 at 12:31):

Last night we merged https://github.com/IBM/FHIR/pull/306 which includes changes to fhir-examples. So, after pulling it, don't forget to mvn clean install -p fhir-examples before attempting a local maven build.

Paul Bastide (Oct 25 2019 at 12:31):

+1

Senthil Bakthavachalam (Oct 25 2019 at 15:02):

guys, get mac client from https://chat.fhir.org/apps/mac

Senthil Bakthavachalam (Oct 25 2019 at 15:02):

I'm posting from it!

Paul Bastide (Oct 25 2019 at 15:03):

yeah - that's what I'm using

Paul Bastide (Oct 25 2019 at 15:03):

the web stinks

Lee Surprenant (Oct 30 2019 at 15:37):

Our github action-based PR builds are blazing fast again

Lee Surprenant (Oct 30 2019 at 15:38):

https://github.com/IBM/FHIR/pull/337 checks completed in 10 minutes :-)

Paul Bastide (Oct 30 2019 at 15:42):

this is good

Lee Surprenant (Nov 11 2019 at 21:58):

https://github.com/IBM/FHIR/pull/395#pullrequestreview-315180352 introduces a change that increases our build times to about 15 minutes. Specifically, I enabled the ALL index for the fhir-persistence-jdbc R4 spec example tests. This is because Albert found a number of samples that were causing our JDBC layer some issues, but we never noticed it because we only ever run the MINIMAL set.

Lee Surprenant (Nov 11 2019 at 21:59):

what i'd really like to do is conditionally set testType to ALL based on whether anything in fhir-persistence or fhir-persistence-jdbc (and maybe fhir-search) has been updated

Lee Surprenant (Nov 11 2019 at 22:00):

I opened https://stackoverflow.com/questions/58808690/conditional-jobs-and-steps-based-on-updated-paths to see if I can get some free community advice on how to do that in github actions

Lee Surprenant (Nov 11 2019 at 22:00):

but in the meantime, i think 15 minutes is acceptable for PR builds and so I've approved https://github.com/IBM/FHIR/pull/395

Lee Surprenant (Nov 11 2019 at 22:01):

another option for us to consider is to pass specially values through the commit message

Lee Surprenant (Nov 11 2019 at 22:02):

for example, we could run with ALL by default and then override that with something like ***quick*** in the commit message

Lee Surprenant (Nov 11 2019 at 22:03):

there is some precendence for this (see https://stackoverflow.com/questions/3829305/what-does-no-ci-stand-for) but I'd much rather just have it be automatic so that we don't have such a messy commit history

Lee Surprenant (Nov 12 2019 at 21:49):

OK, I got something working and submitted https://github.com/IBM/FHIR/pull/399

Lee Surprenant (Nov 12 2019 at 21:50):

the bash scripting is a bit tricky to get right, but i've tested it for fhir-persistence-jdbc and fhir-model edits

Lee Surprenant (Nov 12 2019 at 21:51):

currently, we'll set the jdbc-all-tests profile if the PR contains modifications to any paths under

        jdbc_paths=(
          fhir-search/src/main
          fhir-persistence/src/main
          fhir-persistence-schema/src/main
          fhir-persistence-jdbc
        )

and we set the model-all-tests profile for modifications to paths under

        model_paths=(
          fhir-model
        )

Lee Surprenant (Nov 12 2019 at 21:52):

unfortunately, the model-all-tests also seems to make us execute the search tests against the ALL index, but I've already spent enough time on this one

Paul Bastide (Nov 13 2019 at 12:12):

We can do this in maven as we control the test execution.

Lee Surprenant (Nov 13 2019 at 14:12):

i think the problem is it always looks "fresh" to the github action (since its a fresh clone on a new system each time)

Lee Surprenant (Nov 13 2019 at 14:12):

so not sure how to accomplish the above with just maven

Lee Surprenant (Nov 13 2019 at 14:12):

IMHO its working acceptably with the bash script from pull request 399

Lee Surprenant (Nov 13 2019 at 14:12):

certainly good enough for this sprint

Paul Bastide (Nov 13 2019 at 14:28):

i think the problem is it always looks "fresh" to the github action (since its a fresh clone on a new system each time)

something like this GIT_DIFF=git diff master..<branch> --name-only | grep -c fhir-persistence
mvn clean test -DextremeTestVariable=<GIT_DIFF> number

Paul Bastide (Nov 13 2019 at 14:29):

You would then add to the clean test to test when MAXIMUM when GIT_DIFF is over a value

Paul Bastide (Nov 13 2019 at 14:29):

you could even filter on java files

Lee Surprenant (Nov 13 2019 at 15:06):

i'm not sure thats any better than what i did...does it have advantages i'm missing? did you check out https://github.com/IBM/FHIR/pull/399 ?

Paul Bastide (Nov 13 2019 at 15:22):

it's actually the same thing

Paul Bastide (Nov 13 2019 at 15:22):

:)

Paul Bastide (Nov 13 2019 at 15:23):

line 60 is essentially the same

Paul Bastide (Nov 26 2019 at 20:08):

Hi Everyone, I just posted RC3 https://github.com/IBM/FHIR/releases/tag/4.0.0-RC3

Paul Bastide (Nov 27 2019 at 20:38):

Our team is off for the US Holiday. Please drop any messages here, and we'll grab / followup when we get back (or check in over the weekend)

Lee Surprenant (Dec 03 2019 at 03:11):

Heads Up: today we merged John's changes for https://github.com/IBM/FHIR/issues/453 which splits fhir-path (and fhir-profile) out of the fhir-model project in order to avoid a circular dependency between fhir-registry, fhir-model, and fhir-validation. If you've already set up a workspace, don't forget to import these new projects after the merge.

Lee Surprenant (Dec 06 2019 at 16:06):

Just pulled the trigger on https://github.com/IBM/FHIR/pull/478 ...the IBM FHIR Server should not be on FHIR 4.0.1

Lee Surprenant (Dec 06 2019 at 16:06):

please remember to re-install fhir-examples locally before attempting a build after merging this in

Lee Surprenant (Mar 09 2020 at 19:29):

https://github.com/IBM/FHIR/pull/759 goes beyond just issue #17 in order to provide a refactoring of one of our largested classes: com.ibm.fhir.server.resources.FHIRResource

Lee Surprenant (Mar 09 2020 at 19:29):

Previously, this class was a mix of JAX-RS methods and related helpers for performing the FHIR interactions with a given FHIRPersistence implementation

Lee Surprenant (Mar 09 2020 at 19:30):

With this PR, I split each interaction into its own JAX-RS class (which all extend from FHIRResource)

Lee Surprenant (Mar 09 2020 at 19:31):

Additionally, I moved httpHeaders into HeaderParams and moved httpHeaders from the PersistenceEvent to FHIRRequestContext.

Lee Surprenant (Mar 09 2020 at 19:32):

due to this change, please remember to build and package fhir-config into your development servers, or else every request will fail

Lee Surprenant (Mar 09 2020 at 19:33):

also, I think we've had a recent change to fhir-examples, so be sure to rebuild that before kicking off the full project build locally

Paul Bastide (Mar 12 2020 at 16:20):

Hey... Lee just started a merge of https://github.com/IBM/FHIR/pull/778... please reinstall fhir-examples - mvn -f fhir-examples clean install

Lee Surprenant (Apr 22 2020 at 14:29):

We've just merged https://github.com/IBM/FHIR/pull/939 to the master branch. This PR changes our default keystores from JKS to PCKS12 and reconfigures our server.xml to take advantage of configDropins (to align with the open-liberty image).
If you have a local development server, please consider updating you server config to align with this new approach.

Paul Bastide (Apr 22 2020 at 14:30):

please feel free to ask questions of us, we're happy to answer

Lee Surprenant (Apr 29 2020 at 16:41):

Some more important server config changes are coming in https://github.com/IBM/FHIR/pull/998
The benefit of these changes is that:

1. our default config becomes more in-line with what fhir clients expect wrt having the metadata and well-known endpoints available (where they introspect the security from); and
2. when JWTs are enabled, we now get injected with the user token so we can add code that does access control decisions based on that (putting us in position to support SMART app launch)

Lee Surprenant (Apr 29 2020 at 16:41):

If you maintain a local server, you may want to pick up the server.xml updates (or reconcile with your local copy)

Paul Bastide (May 08 2020 at 19:55):

Hi everyone, for those staying current with ibm/fhir the master branch, please be sure to import fhir-ig-davinci-pdex-plan-net into your workspace. it's a new module for a new profile wer're starting to support. Also, we've up versioned to 4.2.2-SNAPSHOT, please re-install mvn clean install -DskipTests -f fhir-examples

Paul Bastide (May 26 2020 at 18:39):

Hi everyone, for those staying current with ibm/fhir the master branch, please be sure to import fhir-term into your workspace. it's a new module for terminology support.

Paul Bastide (Jun 02 2020 at 12:45):

Please import fhir-operation-term into your workspaces.

Lee Surprenant (Jun 10 2020 at 16:54):

I'm pulling the trigger on https://github.com/IBM/FHIR/pull/1207.
This pull request moves some modules into subdirectories, so if you have a workspace with these project you will want to:

1. delete the fhir-operation-*, fhir-ig-*, and fhir-notification-* projects from your workspace
2. git pull (or rebase)
3. re-import all the fhir-operation-*, fhir-ig-*, and fhir-notification-* projects

Paul Bastide (Jul 08 2020 at 13:31):

Hey everyone, I forgot to warn those that follow master. Please be sure to update fhir-examples - mvn clean install -f fhir-examples

Paul Bastide (Jul 08 2020 at 13:32):

I added some GroupToSearchQuery examples

Lee Surprenant (Aug 07 2020 at 18:17):

New module alert: with https://github.com/IBM/FHIR/pull/1400 we just introduced a new module fhir-smart which adds

1. a sample config for configuring the FHIR Server to act as an OAuth "Resource Server" in combination with a locally-deployed instance of Keycloak, and open source identity and access management platform; and
2. a PersistenceInterceptor for checking the resources of the current interaction against the approved SMART "scopes" in the passed bearer token

Lee Surprenant (Aug 07 2020 at 18:18):

If you're keeping a development workspace up-to-date, then please don't forget to import this new module.

Lee Surprenant (Aug 14 2020 at 15:14):

recently merged https://github.com/IBM/FHIR/pull/1411 which adds language code validation during resource object construction and updates our examples with valid codes, so don't forget to rebuild fhir-examples after updating

Paul Bastide (Aug 27 2020 at 14:16):

Reminder: those that follow main/master, please update fhir-examples and import the new module fhir-ig-davinci-pdex-formulary

Lee Surprenant (Sep 01 2020 at 21:53):

we've made some more tweaks to the fhir-examples and we have another set coming (likely tomorrow) so don't forget to rebuild fhir-examples if you're staying up-to-date

Lee Surprenant (Oct 22 2020 at 13:17):

Due to the fhir-configuration updates associated with releases 4.4.1 and 4.4.2, if you have a local development server you will need to update the shared libraries (shared/lib/fhir) or create a new server from the release (liberty 20.0.0.9)

Lee Surprenant (Oct 29 2020 at 12:30):

We've merged a big change into master branch: https://github.com/IBM/FHIR/pull/1604
This is a schema change which affects how we store reference values to make the server much more efficient.
We've also updated the projects to 4.5.0-SNAPSHOT.
We'll have complete migration steps as part of the 4.5.0 release, but if you have a development server that is tracking master you'll probably want to:

1. rebuild fhir-examples to pick up 4.5.0-SNAPSHOT before your next fhir-parent build
2. delete the database and start fresh

For the official release, migration will include invoking a new $reindex operation that was delivered in the same PR.

Lee Surprenant (Dec 01 2020 at 19:34):

just merged https://github.com/IBM/FHIR/pull/1767 which sets the server timezone to UTC by default...something we generally recommend but have never made the default until now. If you happen to be running a local development server, we recommend you add this setting to your local server.env to match.

Lee Surprenant (Dec 17 2020 at 21:47):

we've bumped our project poms to 4.6.0-SNAPSHOT, so don't forget to rebuild fhir-examples if you're keeping up with master

Paul Bastide (Apr 23 2021 at 13:28):

Quick quick reminder... if you are following the main branch for IBM FHIR Server, please import the latest projects such as fhir-cache and fhir-term-remote projects into your workspace (also worth mentioning there may be more such as fhir-term-graph, fhir-operation-everything).

Lee Surprenant (Apr 28 2021 at 18:51):

just pressed merge on https://github.com/IBM/FHIR/pull/2298 …folks on main will need to rebuild fhir-examples and you workspace might take a bit to rebuild

Last updated: Apr 12 2022 at 19:14 UTC