Stream: trifolia-on-fhir
Topic: New build issues since Sept 14
Lorraine Constable (Sep 27 2021 at 23:04):
I have a guide that reliably completed the build when I last built it Sept 14 (there are warnings, etc we are working on fixing). This morning I attempted to publish again ahead of making changes, just to make sure, and I received "IG Publisher finished with code 1", with a java stack trace that starts with:
java.lang.Exception: Error Parsing File XXX/tmp-1piEFps0SK5S3/input/MCC-IG.json: JsonObject
at org.hl7.fhir.igtools.publisher.Publisher.initializeFromIg(Publisher.java:1670)
at org.hl7.fhir.igtools.publisher.Publisher.initialize(Publisher.java:1487)
at org.hl7.fhir.igtools.publisher.Publisher.execute(Publisher.java:746)
at org.hl7.fhir.igtools.publisher.Publisher.main(Publisher.java:8664)
Caused by: java.lang.UnsupportedOperationException: JsonObject
at com.google.gson.JsonElement.getAsString(JsonElement.java:192)
at org.hl7.fhir.r4.formats.JsonParser.parseImplementationGuideImplementationGuideDefinitionResourceComponentProperties(JsonPars
er.java:14566)
at org.hl7.fhir.r4.formats.JsonParser.parseImplementationGuideImplementationGuideDefinitionResourceComponent(JsonParser.java:14
534)
at org.hl7.fhir.r4.formats.JsonParser.parseImplementationGuideImplementationGuideDefinitionComponentProperties(JsonParser.java:
14495)
at org.hl7.fhir.r4.formats.JsonParser.parseImplementationGuideImplementationGuideDefinitionComponent(JsonParser.java:14480)
at org.hl7.fhir.r4.formats.JsonParser.parseImplementationGuideProperties(JsonParser.java:14433)
at org.hl7.fhir.r4.formats.JsonParser.parseImplementationGuide(JsonParser.java:14329)
at org.hl7.fhir.r4.formats.JsonParser.parseResource(JsonParser.java:28232)
at org.hl7.fhir.r4.formats.JsonParserBase.parse(JsonParserBase.java:124)
at org.hl7.fhir.r4.formats.ParserBase.parse(ParserBase.java:61)
at org.hl7.fhir.r4.formats.FormatUtilities.loadFile(FormatUtilities.java:171)
at org.hl7.fhir.igtools.publisher.Publisher.initializeFromIg(Publisher.java:1667)
There have been no changes in the IG since it built on Sept 14 - not sure where to start here.
Lorraine Constable (Sep 27 2021 at 23:06):
follow up - running the MCC-IG.json file through a validator showed only the existing known reference link problems that were known and being worked on before Sept 14
Sean McIlvenna (Oct 19 2021 at 19:24):
Hi @Lorraine Constable , so sorry for not getting back sooner! Upon first glance, I think this may be a IG Publisher bug.
- Have you asked on the #implementers stream if others have experienced similar problems?
- Have you tried publishing this IG again recently with the latest version of the IG Publisher? Maybe it's fixed now???
Robert Dieterle (Oct 30 2021 at 20:30):
@Sean McIlvenna We have red flags in the SDOH-ClinicalCare IG in trifolia-on-fhir for each of the examples. There is no obvious error. What cases the red flag and what should we do to correct them?
Sean McIlvenna (Nov 01 2021 at 14:47):
@Robert Dieterle , where are you seeing the "red flags"??
Robert Dieterle (Nov 01 2021 at 15:03):
On the resources tab -- only the examples have the link in red
Sean McIlvenna (Nov 01 2021 at 20:16):
I assume you are referring to the red "Edit" button...
Sean McIlvenna (Nov 01 2021 at 20:16):
this is the logic behind that button:
if (!resource.name || !resource.reference || ((resource.hasOwnProperty('exampleBoolean') && resource.exampleBoolean === true) || (resource.hasOwnProperty('exampleCanonical') && resource.exampleCanonical !== ''))) {
//invalid
}
Sean McIlvenna (Nov 01 2021 at 20:16):
I think that logic is incorrect
Sean McIlvenna (Nov 01 2021 at 20:17):
I think it could be improved
Sean McIlvenna (Nov 01 2021 at 20:17):
So, in general, I think you can ignore that red "edit" icon, at least for now
Sean McIlvenna (Nov 01 2021 at 20:21):
According to the logic... it's invalid if:
- No name
- No reference
- Example boolean == true
- Example canonical != ""
I have no idea why we would have put those last two bullets in the logic.. I'm sure there was a reason, but I can't figure out why that would have been
Sean McIlvenna (Nov 01 2021 at 20:21):
Asking others to see if they know why we would have done that
Last updated: Apr 12 2022 at 19:14 UTC