FHIR Chat · PR for JIRA tracker item

Stream: mapping-framework

Topic: PR for JIRA tracker item

Alexander Zautke (Aug 19 2020 at 21:18):

@Grahame Grieve @Lloyd McKenzie I've applied all necessary changes for tracker item FHIR-20839, FHIR-20843, FHIR-20849. I'm starting to implement a R5 version of the .NET engine and didn't wanted to carry over these old burdens. If I could get permissions, I could prepare a PR so these issues get fixed in the current build. Let me know if you would like that. If yes, I could offer to see if I'm able to apply some of the other open changes to StructureMap.

Grahame Grieve (Aug 19 2020 at 21:19):

sure that would be good to make a PR. If you make it in the next 2-3 hours, it can make it in the connectation build of FHIR I am releasing today (though it would mainly be for documentation purposes)

Alexander Zautke (Aug 19 2020 at 21:23):

Sounds good, the branches are ready for review

Alexander Zautke (Aug 19 2020 at 21:24):

What's the process to get permissions to open a PR on the repository?

Alexander Zautke (Aug 19 2020 at 22:38):

It's getting late here, so I guess I'll try again for the next connectathon build ;)
https://confluence.hl7.org/display/FHIR/FHIR+Build+Process#FHIRBuildProcess-Setup seems to indicate that some sort of formal email is necessary to ask for approval, where should I sent it to? Or is a message here enough?

Alexander Zautke (Aug 19 2020 at 22:38):

My GitHub username would be "alexzautke" in any case.

Grahame Grieve (Aug 19 2020 at 22:39):

you can always open a PR with no permissions

Grahame Grieve (Aug 19 2020 at 22:40):

just make the PR from your own repository

Alexander Zautke (Aug 19 2020 at 22:48):

Ok, PRs are open. #978, #977, #976.

Alexander Zautke (Aug 19 2020 at 22:52):

Thanks for the help

Alexander Zautke (Apr 05 2021 at 14:37):

I've started to apply changes for JIRA tickets which would influence either the grammar of the mapping language or the structure of StructureMap. A couple of PRs are now open. Would someone be up for a review?

https://github.com/HL7/fhir/pull/985 - J#20844
https://github.com/HL7/fhir/pull/986 - J#20841
https://github.com/HL7/fhir/pull/984 - J#20848, J#20840
https://github.com/HL7/fhir/pull/1241 - J#20842