Stream: github
Topic: Recommendation for partially open repository
John Moehrke (Dec 04 2019 at 15:47):
What is the proper way to handle having a GIThub repository that allows pull-requests without needing to add that user as a named (or grouped) contributor? (asking for a friend -- @Lloyd McKenzie )
Alexander Kiel (Dec 04 2019 at 15:51):
Every user can fork a repository, make changes and issue a pull request towards the original repository. That the usual way Open Source contribution works on GitHub.
John Moehrke (Dec 04 2019 at 15:56):
one would think that... but we are having trouble with the ig-guidance repository. The problem could be operator-error (me) as I am not a GIT expert. I know how we manage the FHIR core. The problem could be the way the repository is setup (lloyd).
John Moehrke (Dec 04 2019 at 15:57):
I have done a clone, create a branch locally, made the change, but can't submit the pull-request. I get 403
Josh Mandel (Dec 04 2019 at 16:01):
We could either add you to the repository write permissions, or you can push to a fork of the repository in your personal account. Both are reasonable options. The former makes sense in a tighter community and the latter makes sense in a wider community and of course they can be mixed and matched.
Alexander Kiel (Dec 04 2019 at 16:02):
I managed to submit a PR by forking, editing and using the "New Pull Request" button on the original repo.
Alexander Kiel (Dec 04 2019 at 16:02):
But normally, GitHub would offer me submitting a PR with a extra yellow box. I did not saw this.
John Moehrke (Dec 04 2019 at 16:03):
okay, so this is a (me) problem... As @Lloyd McKenzie explicitly does not want to be adding everyone that wants to make a change... so teach me the right way to do this.
John Moehrke (Dec 04 2019 at 16:03):
how is what you are describing different than the way we manage the FHIR core?
Alexander Kiel (Dec 04 2019 at 16:03):
@John Moehrke You have to start with a fork under your personal account.
John Moehrke (Dec 04 2019 at 16:04):
how?
Josh Mandel (Dec 04 2019 at 16:04):
You can click the fork button inside the GitHub UI to create a fork of the repository in your personal account. Then you can clone that fork (or assuming you have already done all the work locally in an existing clone, you can git remote add to point your existing clone to your new fork).
John Moehrke (Dec 04 2019 at 16:04):
sorry... you got a id10t on your hands.
John Moehrke (Dec 04 2019 at 16:04):
let me try.
Alexander Kiel (Dec 04 2019 at 16:06):
Screen-Shot-2019-12-04-at-17.04.39.png :-)
John Moehrke (Dec 04 2019 at 16:06):
yup... working on it
John Moehrke (Dec 04 2019 at 16:11):
okay, so given this additional first step, and using the normal branch mechanics I am use to with FHIR core.. I think I have succeeded.
John Moehrke (Dec 04 2019 at 16:11):
I learned something... so this is the typical way to submit pull requests to any repository?
Josh Mandel (Dec 04 2019 at 16:25):
It is a very common workflow, yes -- especially for submissions solicited from or contributed by developers outside of the core committers for a repository.
John Moehrke (Dec 04 2019 at 16:26):
thanks. good for me to know.
Last updated: Apr 12 2022 at 19:14 UTC
