Stream: genomics/committers
Topic: Updates to Queries page in IG
Kevin Power (Sep 24 2019 at 16:46):
Hey @Bret H - In our meeting today, it was mentioned you worked on the queries page in the IG to bring them up to date? Can you share an update? http://build.fhir.org/ig/HL7/genomics-reporting/usecases.html
Bret H (Sep 24 2019 at 17:04):
There was a meeting today!? Drat. I assumed it was canceled due to the WG GM having occurred last week.
I have a branch as you noted and have not pushed my changes to it. Patrick has agreed to review them before merging. Thanks for the question.
Kevin Power (Sep 24 2019 at 17:17):
Thanks @Bret H - I sent an email to the list yesterday about meeting today. If you have a branch, I would say feel free to push it up and we can get others to review.
Kevin Power (Sep 24 2019 at 17:17):
(oh, and mentioned on Zulip about the meeting as well ;)) https://chat.fhir.org/#narrow/stream/179304-genomics.2Fcommitters/topic/Call.20Tuesday.20Sep.2024.3F
Bret H (Sep 24 2019 at 19:02):
well it is on me that I missed the call this morning. Can't reverse time. I was very happy to see that Nephi's request was addressed (other chat). Was there anything else I missed?
Kevin Power (Sep 24 2019 at 19:41):
I emailed the notes to the list serv, feel free to review.
Bret H (Sep 26 2019 at 13:32):
regards queries @James Jones @Patrick Werner @Kevin Power I'm on it. Will push tonight or tomorrow morning and make merge request for review.
Bret H (Sep 27 2019 at 11:10):
@James Jones @Patrick Werner @Kevin Power I'm ready to merge. building locally. cleaning up some markup.
Kevin Power (Sep 27 2019 at 11:30):
Thanks Bret - Feel free to merge anytime.
Bret H (Sep 27 2019 at 12:04):
great. build is fine, as it should be I'm only messing with a html file. but I'm getting some odd markup bleeding. I'll give up in 15 min.
Bret H (Sep 27 2019 at 12:27):
@James Jones or @Patrick Werner please review my merge and the queries. I checked out what I could with HSPC. The syntax should be good but in some cases I did not check with the specimen parameter.
Kevin Power (Sep 27 2019 at 14:40):
I didn't do a deep review, but a quick look shows that you have some blue text in a few areas. Did you mean to switch colors? See this section: http://build.fhir.org/ig/HL7/genomics-reporting/branches/BretOperationsExampleXMLpage/usecases.html#get-all-observed-variants-for-a-specific-patient
Jamie Jones (Sep 27 2019 at 14:59):
Looks like a missed a/> tag, should be an easy fix
Patrick Werner (Sep 27 2019 at 15:02):
Yes there is a problem with the file i'm currently reviewing the changes
Jamie Jones (Sep 27 2019 at 20:00):
realizing something strange happened to the tracker for this: https://gforge.hl7.org/gf/project/fhir/tracker/?action=TrackerItemEdit&tracker_item_id=15884&start=0 it is currently marked as uncompatible and triaged but we voted to update guidance.
Jamie Jones (Sep 27 2019 at 20:00):
adding to Monday's agenda to get input on recent updates
Kevin Power (Sep 27 2019 at 21:08):
Tracker 15884 should be in "Resolved - Change Required" - Looks like when @ Bob Milius documented the vote details, he didn't update the status and remove the Group field value. We have some guidance here: https://confluence.hl7.org/display/CGW/Tracker+voting+checklist
Jamie Jones (Sep 27 2019 at 21:12):
Luckily we were working on it anyways! Should be able to resolve next week once it gets merged
Kevin Power (Sep 27 2019 at 21:16):
Jira can't come fast enough :slight_smile:
Bob Milius (Sep 27 2019 at 21:32):
sorry about that @Kevin Power I'll try to follow the procedure better in the future :dizzy:
Kevin Power (Sep 27 2019 at 21:34):
<Kevin frantically looking for trackers he didn't update correctly>
Bret H (Sep 28 2019 at 03:00):
@Patrick Werner let me know when the branch can be merged.
Patrick Werner (Sep 30 2019 at 10:02):
@Bret H github didn't persisted my first review .. :unamused: did it again
Patrick Werner (Sep 30 2019 at 10:02):
currently looking at the link issue...
Patrick Werner (Sep 30 2019 at 12:05):
fixed the anchor tags, added code review with some comments.
Bret H (Oct 01 2019 at 02:17):
Pushing latest. I'm not having good luck with the links appearing in a table of contents. Where are the templates for the IGs?
Bret H (Oct 01 2019 at 02:23):
@Patrick Werner https://github.com/HL7/genomics-reporting/pull/2/commits/8c1925296945d68ad64b588f7fca5bb6ddcb44f9 this is the latest committ
Kevin Power (Oct 01 2019 at 14:46):
Hey @Bret H - I would not worry about the links / TOC. Not sure something like that is built into the template/IG we are using today.
Bret H (Oct 01 2019 at 16:31):
Sounds good to me. The latest commit should be part of the merge request. @Patrick Werner let me know if the additional textual guidance is sufficient.
Last updated: Apr 12 2022 at 19:14 UTC
