Stream: genomics/committers
Topic: Planning - Week of Oct 8-12
Kevin Power (Oct 04 2018 at 15:26):
Team - I will be busy much of next week as Cerner is hosting our annual Cerner Health Conference. So I might start working on some of the trackers I have assigned to myself, but unlikely to commit anything. So if someone else wants to take on some trackers and start working down our backlog, that would be great.
Kevin Power (Oct 05 2018 at 14:30):
Also wanted to ask @Lloyd McKenzie about his new IG framework and the possibility of upgrading the Genomics Reporting IG to it? Any thoughts?
Lloyd McKenzie (Oct 05 2018 at 14:39):
There's a "newer" framework. We won't be moving to the "new" framework for this ballot - as it's going to require a refactoring of some things and may be flakey and we don't have time to manage that during this ballot cycle.
Jamie Jones (Oct 05 2018 at 14:58):
We can take first crack at making changes next week (Oct 8-12) here in Gil's lab! I'll pull specific trackers to this chat if I don't have write privilege to assign us to them if that's okay
Kevin Power (Oct 05 2018 at 16:12):
Thanks @James Jones - And yes, feel free to post the trackers here and I can assign them to someone for you if needed.
Kevin Power (Oct 05 2018 at 16:13):
There's a "newer" framework. We won't be moving to the "new" framework for this ballot - as it's going to require a refactoring of some things and may be flakey and we don't have time to manage that during this ballot cycle.
@Lloyd McKenzie - So that means we just stay with the framework we have for now and look to upgrade in 2019?
Lloyd McKenzie (Oct 05 2018 at 16:18):
We can update to the current "simple" version which fixes a couple of things, but the major revamp will happen in 2019.
Kevin Power (Oct 05 2018 at 19:52):
What does the "simple" version upgrade look like?
Lloyd McKenzie (Oct 05 2018 at 19:54):
Just replacing the framework folder. Off the top of my head, I'm not even sure if it'll result in any change to how things get rendered (hard to keep track of what version each IG is on :) - the new approach should fix that and ensure everyone runs against the same set of templates).
Kevin Power (Oct 05 2018 at 19:58):
Ok, that does sound simple. Sounds like we can make changes in the src folder without risk of conflicts, that is really what I wanted to validate.
Lloyd McKenzie (Oct 05 2018 at 19:59):
Absolutely
Lloyd McKenzie (Oct 05 2018 at 19:59):
The bigger change will involve some renaming and possibly moving - which is one reason we'll hold off until post-Dec.
Kevin Power (Oct 05 2018 at 20:00):
Got it, many thanks Lloyd.
Jamie Jones (Oct 08 2018 at 20:48):
Updated Background.xml by updating to the text gone over at Baltimore WGM, covering resolutions for trackers 16254, 16255, 16256, 16686, and 16712.
Jamie Jones (Oct 09 2018 at 16:44):
hey guys, anyone have a quick tip on how to remove links to profiles on the Artifacts.html page? I had it working on my local build but now I am confused why they are still showing up... thanks!
Jamie Jones (Oct 09 2018 at 17:02):
(For some more context, we are removing 4 of the cytogenetic observation profiles per tracker 16869)
Patrick Werner (Oct 09 2018 at 17:18):
as the artifacts.html is generated is assume that all profiles defined in src/resources will be included.
Lloyd McKenzie (Oct 09 2018 at 17:32):
The whole point of the artifacts.html file is to list every artifact defined by your IG. Why would you want any removed?
Jamie Jones (Oct 09 2018 at 17:37):
Per 16869 we are removing 4 observation profiles, just trying to track down how to do that cleanly. Will also be removing the (sole) sequence profile
Patrick Werner (Oct 10 2018 at 10:38):
you have to delete the profiles from the observation profiles spreadsheet. Just delete the Worksheet of the profile you want to remove.
Jamie Jones (Oct 10 2018 at 17:32):
Thanks, got that sorted. The files on the repo now work totally fine when I run the publisher locally but the live build is throwing an error:
"Exception loading http://hl7.org/fhir/uv/genomics-reporting/StructureDefinition/medicationstatement: StructureDefinition medicationstatement at MedicationStatement.status: illegal constrained type code from CodeableConcept" ...
I haven't touched anything in MedicationStatement so not sure how to fix it, reverting the change I made today to the build that worked live yesterday didn't have any effect, may have to update something like src-generated/schemas/fhir-single.xsd? I tried uploading the version that works locally but gets the same server error.
Sorry for breaking everything!
Jamie Jones (Oct 10 2018 at 20:58):
I removed the constraint and it builds again!
Also applied changes for 16869, 16107, 16848
Kevin Power (Oct 10 2018 at 21:56):
Awesome, thanks Jamie! Are you changing the status of the trackers to Applied? I see you added a comment, but we should be able to set the status of these to Applied once we have made the change.
Jamie Jones (Oct 11 2018 at 15:52):
Do you know who I can contact to get editing rights to the gforge? I can make new trackers and comment but can't change status and don't show up in the Assignee list. In the meantime I believe Ling has access and she can update them
Kevin Power (Oct 11 2018 at 15:54):
@Lloyd McKenzie ?
Lloyd McKenzie (Oct 11 2018 at 15:56):
Done. @James Jones You should now have tracker management privileges. There's a wiki page pointed to at the top of the tracker you should read through to make sure you know what everything does and what the rules are.
Jamie Jones (Oct 11 2018 at 15:57):
Thanks!
Last updated: Apr 12 2022 at 19:14 UTC
