Stream: genomics/committers
Topic: GF#24880
Patrick Werner (Oct 08 2019 at 16:13):
@Patrick Werner - With your change, can we mark https://gforge.hl7.org/gf/project/fhir/tracker/?action=TrackerItemEdit&tracker_item_id=24880 as Applied?
almost, currently trying to add an invariant which warns if Implementers are using the unspefic "old" HGNC CS URI
Patrick Werner (Oct 08 2019 at 16:14):
https://github.com/HL7/genomics-reporting/tree/Invars
Patrick Werner (Oct 08 2019 at 16:15):
Jamie Jones (Oct 08 2019 at 16:20):
if only we had meaningful diffs haha
Jamie Jones (Oct 08 2019 at 16:22):
I'm also adding text to the HGNC valueset description, "This value set includes all HGNC Codes, which includes multiple code systems. In this guide, Gene IDs from HGNC are used as CodeableConcepts, which must be sent with the HGNC gene ID including the prefix 'HGNC:' as the code and the HGNC 'gene symbol' as display. CAUTION: HGNC also indexes gene groups by numeric ID (without a prefix), and older systems may send HGNC gene IDs without the prefix, so care must be taken to confirm alignment. We have separately included the genegroup code system to draw attention to this ambiguity and potential error."
Patrick Werner (Oct 08 2019 at 16:23):
Nice explanation
Bret H (Oct 08 2019 at 17:27):
@ Bob Milius does the above look good to you? Thanks! Bret
Kevin Power (Oct 08 2019 at 17:40):
Bob M is out of the office the next 2-3 weeks I think, so we are unlikely to get a response from him.
Bret H (Oct 08 2019 at 17:55):
Ok. Leave my request to him as a retrospective. I do not think he'll disagree. Go with what we got. if a technical correction is needed from him, then it should be considered after publication.
Patrick Werner (Oct 09 2019 at 10:16):
got feedback on the invariant problem. Now stuck at the next error.. waiting for feedback.
Kevin Power (Oct 09 2019 at 15:28):
@Patrick Werner -- Should this be a showstopper?
Patrick Werner (Oct 09 2019 at 15:39):
no, i think we are fine publishing without the constraint. It is a nice feature to give a warning if you are using the old codesystem URI and pointing to the correct ones. But technically an instance using the old CS URI would be invalid anyway and detected by a validator.
Patrick Werner (Oct 09 2019 at 15:39):
So i would say applied?
Last updated: Apr 12 2022 at 19:14 UTC
