Stream: genomics/committers
Topic: Finally Pushed .json Examples to Branch (Finally)
Kevin Roberg-Perez (Jan 26 2021 at 01:59):
All,
Today's discussion about examples reminded me I had yet to push my examples from the end of November up to a branch.
I had converted 18 old examples for the IG from .json into .fsh and back through sushi. During the process I found a variety of points where sushi failed. Some of these seemed to be due to non conformance in the original .json and were fixed so most of the new .json file may now render. I finally pushed them up to my krp branch this evening.
I'm not sure if these are of value going forward, but it would be great if s.o. could run the branch to see if it will build in any case.
Kevin Power (Jan 26 2021 at 03:41):
It looks like you branch built ok? I might try to review it tomorrow. Any merge conflicts?
May Terry (Jan 26 2021 at 03:45):
seems okay. @Kevin Roberg-Perez - could you create a Pull Request for review that would enable review and embedded comments by multiple folks? It also nicely shows side-by-side comparisons of every file changed by line.
Kevin Roberg-Perez (Jan 26 2021 at 12:59):
Thanks Kevin and May. Put the pull request in, but to be clear, the original .json files did not exist in the clone I used for the branch. The only files there were the Patient and Specimen files may created from .fsh. So merging is not a problem.
Kevin Roberg-Perez (Jan 26 2021 at 13:03):
The most important thing is to look at the build (if I have the terminology correct) in a browser. Back when Jamie went over the original pages with me, there were several that did not render correctly.
Kevin Power (Jan 26 2021 at 14:14):
OK, so @Kevin Roberg-Perez - I reviewed your branch and several of the examples, and I think they look good. However, it doesn't look like all the examples are listed on the artifacts page, found here:
http://build.fhir.org/ig/HL7/genomics-reporting/branches/krp/artifacts.html#examples
This is nothing you broke, but would you will willing to determine which examples are missing and add them to the list? If not, I can probably do this as part of the work I will be doing to categorize the examples, but welcome you to do it :smile:
Kevin Power (Jan 26 2021 at 14:27):
Seems there is an error here:
http://build.fhir.org/ig/HL7/genomics-reporting/branches/krp/Observation-obs-idh-ex.html
Kevin Roberg-Perez (Jan 26 2021 at 15:15):
Glad to do it, Kevin.
May Terry (Jan 26 2021 at 17:51):
The following PR was created for review and includes a small addition - a simple example for RegionStudied: https://github.com/HL7/genomics-reporting/pull/38
Last updated: Apr 12 2022 at 19:14 UTC
