Stream: genomics/committers
Topic: FSH & recommended workflow
Bob Milius (Mar 29 2021 at 14:53):
I made a fork of the IG and making my way through the process of building.
I'm running sushi v1.3.1 & publisher.
I ran it at the top level, and it seemed to build ok
Errors: 1, Warnings: 96, Info: 270, Broken Links = 0 (08:33.0431)
The error was in the AnnotationExample
Observation.derivedFrom: minimum required = 1, but only found 0 (from http://hl7.org/fhir/uv/genomics-reporting/StructureDefinition/diagnostic-implication)
So pretty good.
My questions,
Do we still need the build directory? It seems to be leftover from earlier efforts.
Also, do new pages go into input/pages/?
I notice that input/pages/pharmacogenomics.xml begins with
<!-- pharmacogenomics.xml {% comment %}
*****************************************************************************************
* WARNING: DO NOT EDIT THIS FILE *
* *
* This file is generated by SUSHI. Any edits you make to this file will be overwritten. *
* *
* To change the contents of this file, edit the original source file at: *
* genomics-reporting/input/pages/pharmacogenomics.xml *
*****************************************************************************************
{% endcomment %} -->
But this is the page it's pointing to!
I'm creating a new pgx guidance page with content from Arthur's doc and wanted to put it somewhere. Should I put it here in input/pages?
Finally, would anyone mind if I edited the README to include step-by-step instructions on how to fork, build, and do a pull request?
Jamie Jones (Mar 29 2021 at 16:18):
Hi Bob, I think you are correct about the old "build" directory, and should ignore the DO NOT EDIT comment on the input/pages .xml, that is where we add that content to my understanding. If it gets overwritten in the build I'd be surprised. ALso +1 to the updated README : )
Bob Dolin (Apr 06 2021 at 18:13):
+1 to updated README!
Kevin Power (Apr 07 2021 at 14:37):
@May Terry -- Can you comment on the question RE: where to put the PGx guidance page and the 'warning' we see on the files in input/pages/ ?
May Terry (Apr 07 2021 at 14:55):
I'll need to take a closer look at the configuration generating the error. Have a URL to the branch?
Kevin Power (Apr 08 2021 at 12:14):
@May Terry - I am referring to the questions from @ Bob Milius in March 29 above which I think are more general in nature? But Bob should be able to point you at his fork/branch if needed.
May Terry (Apr 08 2021 at 12:29):
Based on what we did with mCODE, pages should be under /input/pagecontent.
Last updated: Apr 12 2022 at 19:14 UTC
