Stream: genomics/committers
Topic: Download Menu Item
Patrick Werner (Sep 02 2019 at 14:31):
Looking at the IPS: http://hl7.org/fhir/uv/ips/2019Sep/ i really like the Download menu item. I think we should add this as well.
Jamie Jones (Sep 11 2019 at 03:06):
Can we just copy that whole page? Very convenient for implementing (and for testing validation through uploading the defs to a server)
Patrick Werner (Sep 11 2019 at 18:35):
i'll try to c&p the page and modify it for our needs. (if needed)
Patrick Werner (Sep 11 2019 at 20:19):
it was just pure copy&paste
Patrick Werner (Sep 11 2019 at 20:19):
pushing now
Jamie Jones (Sep 12 2019 at 18:45):
Looks good! Of note, 'definitions.json' is a zip file but doesn't have the proper extension on windows for me, I had to change the name to definitions.json.zip in order to get HSPC to register it as a .zip. After importing with their new 'profiles' feature, it seems to full load 22 resources (of the 37). Not sure if this is an error with HSPC or with our structuredefs at this point
Patrick Werner (Sep 12 2019 at 19:10):
Looks good! Of note, 'definitions.json' is a zip file but doesn't have the proper extension on windows for me, I had to change the name to definitions.json.zip in order to get HSPC to register it as a .zip. After importing with their new 'profiles' feature, it seems to full load 22 resources (of the 37). Not sure if this is an error with HSPC or with our structuredefs at this point
The link in on the HomePage is:<a href="definitions.xml.zip">XML</a> so it looks like a windows issue?
Patrick Werner (Sep 12 2019 at 19:14):
fyi hapi-cli now has: upload-igpack
Jamie Jones (Sep 12 2019 at 19:14):
yes, I'm not worried about the file extension, but am curious about not all of our defs importing into HSPC... if there's an issue with the way the package is created or if its on HSPC's end
Patrick Werner (Sep 12 2019 at 19:15):
currently trying the upload-igpack function
Jamie Jones (Sep 12 2019 at 19:15):
guess it's time to get hapi if it can read all the defs ;)
Patrick Werner (Sep 12 2019 at 19:34):
its not working :-/
Patrick Werner (Sep 12 2019 at 19:35):
upload ig-pack is r5 only ...
Patrick Werner (Sep 12 2019 at 19:37):
yes, I'm not worried about the file extension, but am curious about not all of our defs importing into HSPC... if there's an issue with the way the package is created or if its on HSPC's end
HSPC uses HAPI, and hapi doesn't allow persisting transaction Bundles (it does now, i just did a PR to jpa starter,)
Patrick Werner (Sep 12 2019 at 19:37):
So the examples are supposed to fail
Patrick Werner (Sep 12 2019 at 19:37):
maybe better try http://build.fhir.org/ig/HL7/genomics-reporting/validator.pack (its' actually a zip)
Jamie Jones (Sep 12 2019 at 19:42):
I can upload validator.pack (after renaming to .zip) and similarly it loads only some of the defs (in particular the same 9 obs-defs, not including variant)
Patrick Werner (Sep 12 2019 at 19:42):
i'll investigate
Jamie Jones (Sep 12 2019 at 19:44):
maybe variant is just too long a def and it gets stuck... :sweat_smile:
Patrick Werner (Sep 12 2019 at 19:51):
just looked at the narrative part: ~350.000 Chars?!?!!!!
Jamie Jones (Sep 12 2019 at 19:52):
The narrative is huge for all the defs with a bunch of boilerplate I think, but Variant is ludicrous
Patrick Werner (Sep 12 2019 at 19:55):
but hapi accepts it.. (http://hapi.fhir.org/baseR4/StructureDefinition/170856)
Patrick Werner (Sep 12 2019 at 20:16):
maybe @Grahame Grieve knows why the narrative is blown up like this?: http://build.fhir.org/ig/HL7/genomics-reporting/obs-variant.profile.xml.html
Jamie Jones (Sep 12 2019 at 20:24):
That is a LOT of inline css
Patrick Werner (Sep 12 2019 at 20:25):
is this a 1:1 copy of the tree view? :-D
Grahame Grieve (Sep 12 2019 at 20:34):
yeah that's what it is - the source for the tree view
Patrick Werner (Sep 12 2019 at 20:35):
can we get rid of it? I don't think that the source for the tree view should be uploaded to a server for conformance testing.
Patrick Werner (Sep 12 2019 at 20:36):
thats about 300kb of narrative
Grahame Grieve (Sep 12 2019 at 20:39):
this is an issue for all IGs, so take it up on IG creation
Patrick Werner (Sep 12 2019 at 20:45):
continued here: https://chat.fhir.org/#narrow/stream/179252-IG-creation/topic/Narrative.20size.20of.20strucDefs
Last updated: Apr 12 2022 at 19:14 UTC
