Stream: committers/notification
Topic: fhir / johnmoehrke-cbcp-qa
Github Notifications (Sep 08 2018 at 23:33):
JohnMoehrke pushed the branch johnmoehrke-cbcp-qa.
Github Notifications (Sep 08 2018 at 23:46):
JohnMoehrke pushed 5 commits to branch johnmoehrke-cbcp-qa. Commits by grahamegrieve (2), jmandel (2) and jawalonoski (1).
- Clean up and remove unused SVN files from the git repository. (#16) (81ea966)
- Create .gitignore (#15) (70b3239)
- Gg work (#18) (c5e4c65)
- Update XmlParser.java (#14) (b719fd6)
- Gg no svn (#19) (5c25135)
John Moehrke (Sep 08 2018 at 23:48):
what have I done?? I was trying to follow the instructions. I hope I didn't just do something bad. I only intended to update one xml file in the Consent directory...
Github Notifications (Sep 08 2018 at 23:53):
JohnMoehrke pushed 1 commit to branch johnmoehrke-cbcp-qa.
John Moehrke (Sep 09 2018 at 00:56):
I think I succeeded?
Josh Mandel (Sep 09 2018 at 02:58):
Interesting -- it looks like perhaps the instruction should make sure that you are on the latest version of the master Branch before you begin.
After checking... No, step one seems to say that already. I'm assuming you followed it by doing "git pull"'on the master Branch before you got started?
Josh Mandel (Sep 09 2018 at 03:01):
In any case, what you did worked.
Github Notifications (Sep 09 2018 at 03:14):
jmandel deleted the branch johnmoehrke-cbcp-qa.
Josh Mandel (Sep 09 2018 at 03:14):
And looking at the history (https://github.com/HL7/fhir/pull/20) it looks perfect.
Grahame Grieve (Sep 09 2018 at 11:03):
so why does it list all the foregoing changes? how can that be right?
John Moehrke (Sep 10 2018 at 13:20):
I did start with the main branch. it did take me a day before I was ready to commit my changes. That is when these other things showed up.
Some of my confusion might have come from using the GIT desktop, rather than commandline. The instructions were not obvious what to do in that UI. So I have moved to turtle GIT.
Last updated: Apr 12 2022 at 19:14 UTC
