Stream: committers/notification
Topic: fhir / brianpos-qa-allcontentsections
Github Notifications (Dec 03 2018 at 07:27):
brianpos pushed 12 commits to branch brianpos-qa-allcontentsections.
- QA updates - allContentSection1MZ (a0c167f)
- QA updates - allContentSection4VP (f9d2c6d)
- QA updates - allContentSection5VP (a1248ca)
- QA updates - allContentSection6VP (d416851)
- QA updates - allContentSection13 (e1d09b6)
- Merge branch 'master' of https://github.com/HL7/fhir into brianpos-qa (da2636a)
- QA updates - allContentSection14 (3a2b034)
- QA updates - allContentSection15 (3baee24)
- QA updates - allContentSection16SK (6835507)
- QA updates - allContentSection21PP (5a3ed9d)
- QA updates - allContentSection22 (c1db162)
- QA updates - allContentSection23 (ca0207c)
Brian Postlethwaite (Dec 03 2018 at 08:55):
@Grahame Grieve This pull request is failing due to the presence of a "may" in the text, but that text was already there, so I assume there was already an exemption for it. storage.html
https://github.com/HL7/fhir/pull/341
Brian Postlethwaite (Dec 03 2018 at 08:56):
If you're happy that it can remain, I'm happy to update the exception if its ok to go.
Brian Postlethwaite (Dec 03 2018 at 21:43):
I couldn't see the existing text in the suppressed messages file, @Grahame Grieve is this use of "may" ok?
Grahame Grieve (Dec 03 2018 at 21:45):
why does it contain 'may not'?
Brian Postlethwaite (Dec 03 2018 at 21:52):
I can switch it over to might. (the line below does in the same context)
Github Notifications (Dec 03 2018 at 21:57):
brianpos pushed 13 commits to branch brianpos-qa-allcontentsections.
- QA - account updates (f4886b8)
- QA - Appointment updates (0882818)
- QA - AppointmentResponse updates (51bdd10)
- QA - ChargeItem updates (fa7a41d)
- QA - ChargeItemDefintion updates (c82a726)
- QA - Encounter updates (75ac9ae)
- QA - Endpoint updates (b95b88a)
- QA - EpisodeOfCare updates (ee10d0a)
- QA - Invoice updates (0219f24)
- QA - Location updates (98d2c31)
- Merge pull request #342 from HL7/brianpos-qa-updates1 (243ba2a)
- Merge branch 'master' of https://github.com/HL7/fhir into brianpos-qa (0df9a82)
- QA - remove use of may not (29a65b9)
Grahame Grieve (Dec 03 2018 at 22:04):
yes, it's prohibited for a reason; we only allow it if it's a direct quote from elsewhere
Github Notifications (Dec 03 2018 at 23:04):
brianpos deleted the branch brianpos-qa-allcontentsections.
Last updated: Apr 12 2022 at 19:14 UTC
