Stream: committers/announce
Topic: R3 Diff
Grahame Grieve (Oct 17 2018 at 22:29):
Shortly I will commit a set of updates to The R3 Diff generation code. This code generates the content of the R3 Diff tab for each resource & type in the spec.
One of your tasks is to check that the display on this tab is correct. In all but two respects, it is auto-generated, and you are checking the correctness of the code that generates the diff.
The two respects in which that code is not automatic is around renaming.
1. If the resource has been renamed (e.g. from A to B) the code won't pick that up. You need to put a note in the [r3-renames] section of fhir.ini:
A=B
If an element is renamed from A.b to A.c, the diff code will generate "remove b" and "add c". You need to make the following entry in the [r3-renames] section of fhir.ini:
A.b=A.c
Then the code will make a 'renamed from b' entry against c, and compare them otherwise. Note that the meaning could be changed a little / inverted, and it's ok to say that they've been renamed - this is about conceptual meaning, not executable mappings.
There's no way to handle splitting an element. That's just remove + 2 adds
Grahame Grieve (Oct 17 2018 at 22:39):
I've made a few of these renaming entries myself - please check
Lloyd McKenzie (Oct 18 2018 at 02:03):
1. Given that there are substantive changes still being made, should this checking wait until after the substantive freeze deadline?
2. Do we want to formally track the review of the resources so we can poke WGs that haven't done it?
Grahame Grieve (Oct 18 2018 at 02:07):
1. I intended for it to be done as part of the editorial process leading to the substantiative freeze. I've done it for all Normative resources which are already frozen
2. Don't know.
Craig Newman (Oct 18 2018 at 15:51):
I've never reviewed a version diff before. By "R3 diff tab" are you referring to the "R3 Conversions" tab that is part of the individual resource pages? Or should we be reviewing comprehensive Differences from Release 3 page (http://build.fhir.org/diff.html)? Is there additional documentation explaining best practices for reviewing this data and providing more detailed instructions for providing feedback (I'm not that familiar with updating fhir.ini)?
Grahame Grieve (Oct 18 2018 at 22:09):
the differences to release 3 is that same content as found in the R3 Diff tab gathered. You can ignore that page, and just focus on the table in the R3 Diff tab, and ignore the R3 <--> R4 Conversion maps
Grahame Grieve (Oct 18 2018 at 22:29):
I can help you with fhir.ini if you need it
Craig Newman (Oct 19 2018 at 13:54):
Too many tabs on these pages....
I was looking at the tabs at the top of the Immunization page, not the tabs in the Resource Content section. That helps. Thank you.
Last updated: Apr 12 2022 at 19:14 UTC
