Stream: committers/announce
Topic: Bug fix in IG Publisher
Lloyd McKenzie (Mar 18 2019 at 19:12):
Copying from Grahame's post to the committers stream:
Grahame Grieve: I've just fixed a significant bug in the IG generator. Here's the bug:
as part of the publication process, the IG pubisher generates snapshots for any profiles that don't have snapshots
It carefully checks the outcomes of the generation process and puts any exceptions/errors in the qa.html file
but snapshots are generated earlier in the process under a variety of conditions
if that process fails there, errors are not trapped - and the partially generated snapshot remains in place
so when the IG publisher goes to check the snapshot, it already exists - and errors are not reported
Grahame Grieve: The first and most obvious fix is that partially generated snapshots should not be left in place - which I've fixed.
Grahame Grieve: a deeper question is whether the IG publisher should accept snapshots at all.
Grahame Grieve: but irrespective of that, as of the next release, the IG publisher will be making more checks on the profiles, and you may get more qa issues, or your build might fail. Once it's released, I'll do rebuild the current set of IGs on the ci-build to see if there's any problems
Grahame Grieve (Mar 18 2019 at 19:13):
thx - meant to post a reference to that thread here
Chris Moesel (Mar 19 2019 at 17:55):
Grahame Grieve: a deeper question is whether the IG publisher should accept snapshots at all.
@Grahame Grieve - Regardless of whether or not you enforce it, does this imply that you recommend that profiles not provide their own snapshots?
Grahame Grieve (Mar 19 2019 at 19:07):
indeed I recommend that.
Lloyd McKenzie (Mar 19 2019 at 19:13):
More specifically, profiles that are input into the IG publication process should not have snapshots. Those that are produced by the publication will have (and need to have).
Chris Moesel (Mar 20 2019 at 17:12):
Got it. OK. I'll need to update our tooling to suppress the snapshot then... It will be interesting to compare the generated snapshot to the one we're producing. I guess that's one way to confirm our differentials are right!
Last updated: Apr 12 2022 at 19:14 UTC
