Stream: committers/git-help
Topic: GIthub Help
Grahame Grieve (Oct 23 2018 at 22:25):
@Craig Newman :
Is there a gForge ticket necessary for this sort of change? I might need a bit of help as I've not successfully applied a change yet with TortoiseGit yet. I think I've got it all set up but haven't had the guts (or time) yet to pull the trigger.
Grahame Grieve (Oct 23 2018 at 22:27):
probably the worst thing that can go wrong is that you make a mess of your local work area and have to start again (I recommend making a local copy of everything first to reduce the chances of having to reedit). Certainly now you have much better protection because we can all see what is being committed, and you won't be able to finish the commit unless it builds ok - which will pick up most things you could get wrong
Craig Newman (Oct 24 2018 at 18:00):
@Grahame Grieve @Lloyd McKenzie or any other experienced user...
I have created my first pull request. I started with a simply change to only add a comment (in just case something went horribly wrong). I don't want to merge my first pull request (not even sure I have the ability to do that). Can I ask that someone more experienced in the process do the merge (assuming everything looks right)? Thanks
https://github.com/HL7/fhir/pull/146
Craig Newman (Oct 24 2018 at 18:39):
Or as long as things go green, is it always safe to merge?
Rob Hausam (Oct 24 2018 at 18:47):
Yes, you should be able to go ahead and merge it.
Craig Newman (Oct 25 2018 at 00:28):
I did the merge and it appears to have worked. Please tell if you see any issue with it. Thanks
Last updated: Apr 12 2022 at 19:14 UTC
