Stream: fhircast-github
Topic: fhircast-docs / PR #76 Add context to close events
Github Notifications (FHIRcast) (Feb 25 2019 at 15:36):
wmaethner opened PR #76
from add-context-to-close-events to master
Added context to the current close events (patient and study). @NiklasSvenzen I know you mentioned also adding context to the logout events, that would be the user right? If we added that what would the resource be (we don't have anything like that in any of the other events), or since we have already done validation of this subscription based on the topic, does the topic already have enough user context to handle the logout events?
Github Notifications (FHIRcast) (Feb 25 2019 at 15:36):
wmaethner requested isaacvetter, and NiklasSvenzen for a review on PR #76.
Github Notifications (FHIRcast) (Feb 25 2019 at 15:36):
wmaethner requested isaacvetter, and NiklasSvenzen for a review on PR #76.
Github Notifications (FHIRcast) (Feb 25 2019 at 17:53):
isaacvetter submitted PR Review
Github Notifications (FHIRcast) (Feb 27 2019 at 23:03):
isaacvetter requested lbergnehr, daliboz, and NiklasSvenzen for a review on PR #76.
Github Notifications (FHIRcast) (Feb 27 2019 at 23:03):
isaacvetter requested lbergnehr, daliboz, and NiklasSvenzen for a review on PR #76.
Github Notifications (FHIRcast) (Feb 28 2019 at 07:47):
lbergnehr submitted PR Review
Github Notifications (FHIRcast) (Feb 28 2019 at 07:47):
lbergnehr submitted PR Review
Github Notifications (FHIRcast) (Feb 28 2019 at 07:47):
lbergnehr created PR Review Comment
`encounter` | Optional | `Encounter/{id}?_elements=identifier` | FHIR Encounter resource in context in the newly opened patient's chart.
Github Notifications (FHIRcast) (Feb 28 2019 at 07:47):
lbergnehr created PR Review Comment
`patient` | Required | `Patient/{id}?_elements=identifier` | FHIR Patient resource describing the patient whose chart is currently in context..
Github Notifications (FHIRcast) (Feb 28 2019 at 13:51):
wmaethner updated PR #76
from add-context-to-close-events to master
Added context to the current close events (patient and study). @NiklasSvenzen I know you mentioned also adding context to the logout events, that would be the user right? If we added that what would the resource be (we don't have anything like that in any of the other events), or since we have already done validation of this subscription based on the topic, does the topic already have enough user context to handle the logout events?
Github Notifications (FHIRcast) (Feb 28 2019 at 13:53):
wmaethner updated PR #76
from add-context-to-close-events to master
Added context to the current close events (patient and study). @NiklasSvenzen I know you mentioned also adding context to the logout events, that would be the user right? If we added that what would the resource be (we don't have anything like that in any of the other events), or since we have already done validation of this subscription based on the topic, does the topic already have enough user context to handle the logout events?
Github Notifications (FHIRcast) (Feb 28 2019 at 13:56):
wmaethner updated PR #76
from add-context-to-close-events to master
Added context to the current close events (patient and study). @NiklasSvenzen I know you mentioned also adding context to the logout events, that would be the user right? If we added that what would the resource be (we don't have anything like that in any of the other events), or since we have already done validation of this subscription based on the topic, does the topic already have enough user context to handle the logout events?
Github Notifications (FHIRcast) (Feb 28 2019 at 13:59):
wmaethner requested lbergnehr, daliboz, and NiklasSvenzen for a review on PR #76.
Github Notifications (FHIRcast) (Feb 28 2019 at 13:59):
wmaethner requested isaacvetter, lbergnehr, daliboz, and NiklasSvenzen for a review on PR #76.
Github Notifications (FHIRcast) (Feb 28 2019 at 22:32):
isaacvetter submitted PR Review
Github Notifications (FHIRcast) (Mar 02 2019 at 13:12):
NiklasSvenzen submitted PR Review
Github Notifications (FHIRcast) (Mar 05 2019 at 15:14):
daliboz created PR Review Comment
Are any of these identifiers that would have a URL system? If no, should we add the identifier types as examples here? EG: MRN?
"identifier": [ { "type": { "coding": [ { "system": "http://terminology.hl7.org/CodeSystem/v2-0203", "value": "MR", "display": "Medication Record Number" }, "text": "MRN" ], } .... }, ... ],...
Github Notifications (FHIRcast) (Mar 05 2019 at 15:14):
daliboz submitted PR Review
Github Notifications (FHIRcast) (Mar 05 2019 at 15:14):
daliboz submitted PR Review
Github Notifications (FHIRcast) (Mar 05 2019 at 15:14):
daliboz created PR Review Comment
Similar comment as above, except I think this is syntactically invalid. This I would expect to probably be an oid system like above? Not sure there's a good "type" that would apply here.
Github Notifications (FHIRcast) (Mar 06 2019 at 20:48):
lbergnehr submitted PR Review
Github Notifications (FHIRcast) (Mar 19 2019 at 12:57):
wmaethner updated PR #76
from add-context-to-close-events to master
Added context to the current close events (patient and study). @NiklasSvenzen I know you mentioned also adding context to the logout events, that would be the user right? If we added that what would the resource be (we don't have anything like that in any of the other events), or since we have already done validation of this subscription based on the topic, does the topic already have enough user context to handle the logout events?
Github Notifications (FHIRcast) (Mar 19 2019 at 13:03):
wmaethner submitted PR Review
Github Notifications (FHIRcast) (Mar 19 2019 at 13:03):
wmaethner created PR Review Comment
I don't know enough about the FHIR identifiers to determine what should go here. You have any ideas?
Github Notifications (FHIRcast) (Mar 19 2019 at 13:04):
wmaethner requested daliboz for a review on PR #76.
Github Notifications (FHIRcast) (Mar 19 2019 at 13:10):
wmaethner merged PR #76
Last updated: Apr 12 2022 at 19:14 UTC
