Stream: fhircast-github
Topic: fhircast-docs / PR #403 Ballot cleanup
Github Notifications (FHIRcast) (Mar 29 2022 at 22:30):
EricOnFHIR opened PR #403 from Ballot-Cleanup to master:
I don't know what changes caused a merge conflict but with these changes I got down to:
Code = fhircast. package-list.json entry for vcurrent: must have a 'path' that starts with the canonical (is ''http://hl7.org/fhir/uv/fhircast-docs', should start with 'http://hl7.org/fhir/uv/fhircast'
in the publication rules section of the qa report.
Github Notifications (FHIRcast) (Mar 29 2022 at 22:55):
isaacvetter submitted PR review.
Github Notifications (FHIRcast) (Mar 29 2022 at 22:55):
isaacvetter created PR review comment:
Eric, Tony already merged this change in here: https://github.com/HL7/fhircast-docs/commit/16fad91ea89b7d59a36dcab174ad62d0cb48ea11.
Can you remove it from your PR / sync with master?
Github Notifications (FHIRcast) (Mar 29 2022 at 22:56):
isaacvetter submitted PR review.
Github Notifications (FHIRcast) (Mar 29 2022 at 22:56):
isaacvetter created PR review comment:
My understanding is that this file is only generated for copying over to https://github.com/HL7/JIRA-Spec-Artifacts/ and that it otherwise has no functional impact.
Do you disagree?
Github Notifications (FHIRcast) (Mar 29 2022 at 22:57):
isaacvetter created PR review comment:
All of these additions contradict the HL7 documentation, but also don't make sense ...
Github Notifications (FHIRcast) (Mar 29 2022 at 22:57):
isaacvetter submitted PR review.
Github Notifications (FHIRcast) (Mar 29 2022 at 22:57):
isaacvetter edited PR review comment.
Github Notifications (FHIRcast) (Mar 29 2022 at 22:58):
isaacvetter submitted PR review.
Github Notifications (FHIRcast) (Mar 29 2022 at 22:58):
isaacvetter created PR review comment:
Lynn said that the url to the eventual spec on hl7.org will not contain "-docs". I worry this is re-introducing a problem.
Github Notifications (FHIRcast) (Mar 29 2022 at 23:00):
isaacvetter submitted PR review.
Github Notifications (FHIRcast) (Mar 29 2022 at 23:00):
isaacvetter created PR review comment:
I'd made a similar change, here: https://github.com/HL7/fhircast-docs/commit/102cc0873049232043c8826cc31480e11994e16b, except went with 2.0.0 for STU2, instead of 1.1.0. Did you choose 1.1.0 on purpose / with evidence?
Github Notifications (FHIRcast) (Mar 29 2022 at 23:02):
isaacvetter created PR review comment:
but trying it anyway ... there's too many conflicts to merge this PR :(
Github Notifications (FHIRcast) (Mar 29 2022 at 23:02):
isaacvetter submitted PR review.
Github Notifications (FHIRcast) (Mar 29 2022 at 23:04):
isaacvetter submitted PR review.
Github Notifications (FHIRcast) (Mar 29 2022 at 23:04):
isaacvetter created PR review comment:
setting a ci-build's path to hl7.org really doesn't make sense, though.
Github Notifications (FHIRcast) (Mar 29 2022 at 23:05):
isaacvetter created PR review comment:
oh wow, I don't think that we should put a sequence on ci-build, either.
Github Notifications (FHIRcast) (Mar 29 2022 at 23:05):
isaacvetter submitted PR review.
Github Notifications (FHIRcast) (Apr 01 2022 at 18:31):
EricOnFHIR closed without merge PR #403.
Last updated: Apr 12 2022 at 19:14 UTC
