Stream: fhircast-github
Topic: fhircast-docs / PR #385 Clarify Hub generated syncerror e...
Github Notifications (FHIRcast) (Feb 28 2022 at 20:02):
EricOnFHIR opened PR #385 from HubGeneratedSyncerror to master:
Based on discussion in February 2022 Hackathon, propose clarification on Hub generated syncerror events
Github Notifications (FHIRcast) (Feb 28 2022 at 20:29):
EricOnFHIR updated PR #385 from HubGeneratedSyncerror to master.
Github Notifications (FHIRcast) (Feb 28 2022 at 20:47):
EricOnFHIR updated PR #385 from HubGeneratedSyncerror to master.
Github Notifications (FHIRcast) (Mar 01 2022 at 23:30):
EricOnFHIR updated PR #385 from HubGeneratedSyncerror to master.
Github Notifications (FHIRcast) (Mar 10 2022 at 15:45):
isaacvetter submitted PR review.
Github Notifications (FHIRcast) (Mar 10 2022 at 15:45):
isaacvetter created PR review comment:
In addition to distributing [`syncerror`](3-8-syncerror.html) events sent by a subscribed application to all subscribed applications, the Hub SHALL generate and communicate [`syncerror`](3-8-syncerror.html) events to subscribed applications under the following conditions --Clarify language for readability.
Github Notifications (FHIRcast) (Mar 10 2022 at 15:45):
isaacvetter submitted PR review.
Github Notifications (FHIRcast) (Mar 10 2022 at 15:45):
isaacvetter created PR review comment:
Github Notifications (FHIRcast) (Mar 10 2022 at 15:49):
isaacvetter submitted PR review.
Github Notifications (FHIRcast) (Mar 10 2022 at 15:49):
isaacvetter created PR review comment:
1. A subscribed application's WebSocket connection is closed with any Connection Close Reason other than 1000 (normal closure) or 1001 (going away) (see [WebSocket RFC](https://www.rfc-editor.org/rfc/rfc6455.html#section-7.1.6) and [WebSocket Status Codes](https://www.rfc-editor.org/rfc/rfc6455.html#section-7.4))
Github Notifications (FHIRcast) (Mar 10 2022 at 15:50):
isaacvetter created PR review comment:
2. And, the subscribed application, does not respond to a FHIRcast event within 10 seconds
Github Notifications (FHIRcast) (Mar 10 2022 at 15:50):
isaacvetter submitted PR review.
Github Notifications (FHIRcast) (Mar 10 2022 at 15:53):
isaacvetter submitted PR review.
Github Notifications (FHIRcast) (Mar 10 2022 at 15:53):
isaacvetter created PR review comment:
[`syncerror`](3-8-syncerror.html) events are distributed only to applications which have subscribed to `syncerror`s. The Hub MAY only send syncerrors to application that are also subscribed to the event which triggered the [`syncerror`](3-8-syncerror.html).Uhh, syncerrors are distributed only to applications that have subscribed to syncerrors, not to apps that subscribed to the event that generated the syncerror. This would be a breaking change for the Hub (although, clearly potentially useful). Switching from implicit SHALL to explicit MAY.
Github Notifications (FHIRcast) (Mar 10 2022 at 15:54):
isaacvetter submitted PR review.
Github Notifications (FHIRcast) (Mar 10 2022 at 15:54):
isaacvetter created PR review comment:
Upon communicating a `syncerror` resulting from an unresponsive app, the Hub SHALL unsubscribe the unresponsive app.
Github Notifications (FHIRcast) (Mar 10 2022 at 15:58):
isaacvetter submitted PR review.
Github Notifications (FHIRcast) (Mar 10 2022 at 15:58):
isaacvetter created PR review comment:
2. The application closes its WebSocket connection to the Hub with a [Connection Close Reason](https://www.rfc-editor.org/rfc/rfc6455.html#section-7.4.1) of 1000 (normal closure) or 1001 (going away). During a normal shutdown of an application, it SHALL unsubscribe, and provide a WebSocket Connection Close Reason of 1000 and not rely upon the Hub recognizing and unsubscribing it as an unresponsive app.
Github Notifications (FHIRcast) (Mar 10 2022 at 16:38):
isaacvetter edited PR review comment.
Github Notifications (FHIRcast) (Mar 10 2022 at 16:48):
isaacvetter edited PR review comment.
Github Notifications (FHIRcast) (Mar 10 2022 at 16:51):
isaacvetter edited PR review comment.
Github Notifications (FHIRcast) (Mar 10 2022 at 16:52):
isaacvetter updated PR #385 from HubGeneratedSyncerror to master.
Github Notifications (FHIRcast) (Mar 10 2022 at 16:52):
isaacvetter updated PR #385 from HubGeneratedSyncerror to master.
Github Notifications (FHIRcast) (Mar 10 2022 at 16:52):
isaacvetter updated PR #385 from HubGeneratedSyncerror to master.
Github Notifications (FHIRcast) (Mar 10 2022 at 16:52):
isaacvetter updated PR #385 from HubGeneratedSyncerror to master.
Github Notifications (FHIRcast) (Mar 10 2022 at 16:53):
isaacvetter submitted PR review.
Github Notifications (FHIRcast) (Mar 10 2022 at 16:53):
isaacvetter created PR review comment:
2. And, the application does not respond to the distributed event by the Hub within 10 seconds or an order of magnitude lower than the subscription time-out. Implementer feedback is solicited on the amount and specificity of time, above.
Github Notifications (FHIRcast) (Mar 10 2022 at 16:57):
isaacvetter updated PR #385 from HubGeneratedSyncerror to master.
Github Notifications (FHIRcast) (Mar 10 2022 at 16:57):
isaacvetter updated PR #385 from HubGeneratedSyncerror to master.
Github Notifications (FHIRcast) (Mar 10 2022 at 17:02):
isaacvetter edited PR review comment.
Github Notifications (FHIRcast) (Mar 17 2022 at 15:45):
isaacvetter updated PR #385 from HubGeneratedSyncerror to master.
Github Notifications (FHIRcast) (Mar 17 2022 at 15:45):
isaacvetter submitted PR review.
Github Notifications (FHIRcast) (Mar 17 2022 at 15:45):
isaacvetter created PR review comment:
[`syncerror`](3-8-syncerror.html) events are distributed only to applications which have subscribed to `syncerror`s.
Github Notifications (FHIRcast) (Mar 17 2022 at 15:46):
isaacvetter updated PR #385 from HubGeneratedSyncerror to master.
Github Notifications (FHIRcast) (Mar 17 2022 at 15:48):
isaacvetter updated PR #385 from HubGeneratedSyncerror to master.
Github Notifications (FHIRcast) (Mar 17 2022 at 15:50):
isaacvetter updated PR #385 from HubGeneratedSyncerror to master.
Github Notifications (FHIRcast) (Mar 25 2022 at 21:24):
EricOnFHIR closed without merge PR #385.
Last updated: Apr 12 2022 at 19:14 UTC
