FHIR Chat · fhircast-docs / PR #377 Content Sharing as IG · fhircast-github

Stream: fhircast-github

Topic: fhircast-docs / PR #377 Content Sharing as IG

---

Github Notifications (FHIRcast) (Jan 26 2022 at 23:14):

EricOnFHIR opened PR #377 from re-add-content-sharing to master:

Add content sharing into new IG format

Github Notifications (FHIRcast) (Jan 26 2022 at 23:16):

EricOnFHIR updated PR #377 from re-add-content-sharing to master.

Github Notifications (FHIRcast) (Jan 26 2022 at 23:17):

EricOnFHIR updated PR #377 from re-add-content-sharing to master.

Github Notifications (FHIRcast) (Jan 26 2022 at 23:18):

EricOnFHIR updated PR #377 from re-add-content-sharing to master.

Github Notifications (FHIRcast) (Jan 26 2022 at 23:18):

EricOnFHIR updated PR #377 from re-add-content-sharing to master.

Github Notifications (FHIRcast) (Jan 26 2022 at 23:19):

EricOnFHIR updated PR #377 from re-add-content-sharing to master.

Github Notifications (FHIRcast) (Jan 31 2022 at 22:15):

EricOnFHIR updated PR #377 from re-add-content-sharing to master.

Github Notifications (FHIRcast) (Jan 31 2022 at 22:18):

EricOnFHIR updated PR #377 from re-add-content-sharing to master.

Github Notifications (FHIRcast) (Feb 01 2022 at 18:14):

isaacvetter submitted PR review.

Github Notifications (FHIRcast) (Feb 01 2022 at 18:14):

isaacvetter created PR review comment:

If supporting content sharing, a FHIRcast Hub SHALL fulfill additional responsibilities:

Eric, note that HL7 FHIR defines normative verbs of SHALL, SHOULD and MAY. MUST is not a valid HL7 FHIR spec normative verb.

Github Notifications (FHIRcast) (Feb 01 2022 at 18:15):

isaacvetter submitted PR review.

Github Notifications (FHIRcast) (Feb 01 2022 at 18:15):

isaacvetter created PR review comment:

You should define "anchor context" before using the term.

Github Notifications (FHIRcast) (Feb 01 2022 at 18:17):

isaacvetter submitted PR review.

Github Notifications (FHIRcast) (Feb 01 2022 at 18:17):

isaacvetter created PR review comment:

Why is the -select action limited to only content-sharing scenarios?

Github Notifications (FHIRcast) (Feb 01 2022 at 18:20):

isaacvetter submitted PR review.

Github Notifications (FHIRcast) (Feb 01 2022 at 18:20):

isaacvetter created PR review comment:

2. Reject `[FHIR resource]-update` and `[FHIR resource]-select` requests if the version does not match the current `versionId` by returning a 4xx/5xx HTTP Status Code rather than updating the content or indication of selection

The hub doesn't actually do any validation other than reject is versionid is wrong, right?

Github Notifications (FHIRcast) (Feb 01 2022 at 18:26):

isaacvetter submitted PR review.

Github Notifications (FHIRcast) (Feb 01 2022 at 18:26):

isaacvetter created PR review comment:

I thought we'd identified scenarios when this won't work. Mediocre notes here: https://confluence.hl7.org/pages/viewpage.action?pageId=130485460

Github Notifications (FHIRcast) (Feb 01 2022 at 18:27):

isaacvetter submitted PR review.

Github Notifications (FHIRcast) (Feb 01 2022 at 18:27):

isaacvetter created PR review comment:

In general, but also specifically this paragraph does not use enough normative language to clearly articulate exactly the behavior required by a client and a hub.

Github Notifications (FHIRcast) (Feb 01 2022 at 18:30):

isaacvetter submitted PR review.

Github Notifications (FHIRcast) (Feb 01 2022 at 18:30):

isaacvetter created PR review comment:

I thought we were planning on content sharing as either it's own FHIR IG, or as a scenario.

Github Notifications (FHIRcast) (Feb 01 2022 at 18:31):

isaacvetter submitted PR review.

Github Notifications (FHIRcast) (Feb 01 2022 at 18:31):

isaacvetter created PR review comment:

DxReport, and maybe Observation and other resources expected to be exchanged need profiles.

Github Notifications (FHIRcast) (Feb 01 2022 at 22:13):

EricOnFHIR submitted PR review.

Github Notifications (FHIRcast) (Feb 01 2022 at 22:13):

EricOnFHIR created PR review comment:

I am fine with a scenario, someone had set up a 5 content sharing structure before this PR. I am fine with changing to 4-6-content-sharing as a scenario.

Github Notifications (FHIRcast) (Feb 01 2022 at 22:23):

EricOnFHIR updated PR #377 from re-add-content-sharing to master.

Github Notifications (FHIRcast) (Feb 01 2022 at 22:34):

EricOnFHIR updated PR #377 from re-add-content-sharing to master.

Github Notifications (FHIRcast) (Feb 01 2022 at 22:36):

EricOnFHIR submitted PR review.

Github Notifications (FHIRcast) (Feb 01 2022 at 22:36):

EricOnFHIR created PR review comment:

There was a section with definitions in the STU3 (before the IG format). I can't find it in the IG formatted pages - do you know where it is or where you would want it?

Github Notifications (FHIRcast) (Feb 02 2022 at 00:05):

EricOnFHIR updated PR #377 from re-add-content-sharing to master.

Github Notifications (FHIRcast) (Feb 02 2022 at 00:39):

EricOnFHIR submitted PR review.

Github Notifications (FHIRcast) (Feb 02 2022 at 00:39):

EricOnFHIR created PR review comment:

I am still not sure how to raise -select out of the current anchor context. With multiple contexts if there is a context.id then a select could be a "Context-select" with the context.id provided and an optional select array?

How else could it work?

Without a context.id would we just say that whatever the context resource is:

"context": [
  {
    "key": "report",
    "resource": {
      "resourceType": "DiagnosticReport",
      "id": "40012366"
    }
  },

then the context is uniquely identified by the resource's id and the operation could still be "Context-select"?

Github Notifications (FHIRcast) (Feb 02 2022 at 00:40):

EricOnFHIR updated PR #377 from re-add-content-sharing to master.

Github Notifications (FHIRcast) (Feb 02 2022 at 00:54):

EricOnFHIR submitted PR review.

Github Notifications (FHIRcast) (Feb 02 2022 at 00:54):

EricOnFHIR created PR review comment:

Agreed, on my to do list. Creating them is not a huge deal but I am trying to figure out how to have the IG Publisher to put them in a good place and not randomly in the ToC. I see there is a CapabilityStatement profile (FSH) file with the defined profile ending up in the Artifacts tab. I guess the same is fine and then I can also link the profiles' output files in the -update and get current context operations.

Github Notifications (FHIRcast) (Feb 02 2022 at 00:56):

EricOnFHIR submitted PR review.

Github Notifications (FHIRcast) (Feb 02 2022 at 00:56):

EricOnFHIR created PR review comment:

In the notes I only see the comments/questions/concerns on the -select operation. What other situations are you referring to?

Github Notifications (FHIRcast) (Feb 02 2022 at 00:58):

EricOnFHIR submitted PR review.

Github Notifications (FHIRcast) (Feb 02 2022 at 00:58):

EricOnFHIR created PR review comment:

OK...I guess I can work on getting more normative. The text was originally in a section I had denoted as informative. Let me work on this so it is more "requirement'ish"

Github Notifications (FHIRcast) (Feb 02 2022 at 22:41):

EricOnFHIR updated PR #377 from re-add-content-sharing to master.

Github Notifications (FHIRcast) (Feb 04 2022 at 13:05):

EricOnFHIR submitted PR review.

Github Notifications (FHIRcast) (Feb 04 2022 at 13:05):

EricOnFHIR created PR review comment:

Done

Github Notifications (FHIRcast) (Feb 04 2022 at 13:06):

EricOnFHIR updated PR #377 from re-add-content-sharing to master.

Github Notifications (FHIRcast) (Feb 04 2022 at 13:40):

EricOnFHIR updated PR #377 from re-add-content-sharing to master.

Github Notifications (FHIRcast) (Feb 04 2022 at 13:42):

EricOnFHIR updated PR #377 from re-add-content-sharing to master.

Github Notifications (FHIRcast) (Feb 04 2022 at 13:44):

EricOnFHIR updated PR #377 from re-add-content-sharing to master.

Github Notifications (FHIRcast) (Feb 04 2022 at 18:52):

EricOnFHIR closed without merge PR #377.

Github Notifications (FHIRcast) (Feb 04 2022 at 19:07):

EricOnFHIR reopened PR #377 from re-add-content-sharing to master.

Github Notifications (FHIRcast) (Feb 04 2022 at 19:25):

EricOnFHIR updated PR #377 from re-add-content-sharing to master.

Github Notifications (FHIRcast) (Feb 04 2022 at 19:36):

EricOnFHIR updated PR #377 from re-add-content-sharing to master.

Github Notifications (FHIRcast) (Feb 04 2022 at 19:36):

EricOnFHIR closed without merge PR #377.

---

Last updated: Apr 12 2022 at 19:14 UTC