Stream: fhircast-github
Topic: fhircast-docs / PR #353 Bas stu2 prepublish review
Github Notifications (FHIRcast) (Dec 30 2020 at 19:42):
isaacvetter opened PR #353 from bas-stu2-prepublish-review to master:
1) Lot's of small/non-functional wording changes / improvements per Bas and #351
2) Rename "Draft - STU2" to "Current - STU2" and clean up menu
3) point to jira as location for submitting issues per #352
Github Notifications (FHIRcast) (Dec 30 2020 at 19:42):
isaacvetter requested wmaethner and NiklasSvenzen for a review on PR #353.
Github Notifications (FHIRcast) (Dec 30 2020 at 19:42):
isaacvetter requested wmaethner and NiklasSvenzen for a review on PR #353.
Github Notifications (FHIRcast) (Jan 04 2021 at 07:56):
NiklasSvenzen submitted PR Review.
Github Notifications (FHIRcast) (Jan 04 2021 at 17:52):
isaacvetter updated PR #353 from bas-stu2-prepublish-review to master:
1) Lot's of small/non-functional wording changes / improvements per Bas and #351
2) Rename "Draft - STU2" to "Current - STU2" and clean up menu
3) point to jira as location for submitting issues per #352
Github Notifications (FHIRcast) (Jan 04 2021 at 17:52):
wmaethner submitted PR Review.
Github Notifications (FHIRcast) (Jan 04 2021 at 17:52):
wmaethner created PR Review Comment:
Is there a reason for not capitalizing this "should"? It is capitalized in other places making it seem like one of HL7's special verbs. If it isn't meant to be an "official" should in this case, can we use a different verb so as not to be confusing
Github Notifications (FHIRcast) (Jan 04 2021 at 17:53):
wmaethner submitted PR Review.
Github Notifications (FHIRcast) (Jan 04 2021 at 17:57):
isaacvetter updated PR #353 from bas-stu2-prepublish-review to master:
1) Lot's of small/non-functional wording changes / improvements per Bas and #351
2) Rename "Draft - STU2" to "Current - STU2" and clean up menu
3) point to jira as location for submitting issues per #352
Github Notifications (FHIRcast) (Jan 04 2021 at 17:59):
isaacvetter submitted PR Review.
Github Notifications (FHIRcast) (Jan 04 2021 at 17:59):
isaacvetter created PR Review Comment:
Thanks, Will! Changed sentence to:
Websockets are particularly useful if a subscriber is unable to host an accessible callback URL.
Github Notifications (FHIRcast) (Jan 04 2021 at 18:09):
isaacvetter updated PR #353 from bas-stu2-prepublish-review to master:
1) Lot's of small/non-functional wording changes / improvements per Bas and #351
2) Rename "Draft - STU2" to "Current - STU2" and clean up menu
3) point to jira as location for submitting issues per #352
Github Notifications (FHIRcast) (Jan 04 2021 at 18:11):
wmaethner submitted PR Review.
Github Notifications (FHIRcast) (Jan 05 2021 at 14:16):
isaacvetter merged PR #353.
Last updated: Apr 12 2022 at 19:14 UTC
