Stream: fhircast-github
Topic: fhircast-docs / PR #346 add eventname to syncerror
Github Notifications (FHIRcast) (Nov 30 2020 at 17:35):
isaacvetter opened PR #346 from eventname-to-syncerror to master:
Github Notifications (FHIRcast) (Nov 30 2020 at 17:36):
isaacvetter updated PR #346 from eventname-to-syncerror to master:
Github Notifications (FHIRcast) (Nov 30 2020 at 17:37):
isaacvetter requested wmaethner for a review on PR #346.
Github Notifications (FHIRcast) (Nov 30 2020 at 17:37):
isaacvetter requested wmaethner and NiklasSvenzen for a review on PR #346.
Github Notifications (FHIRcast) (Nov 30 2020 at 18:15):
NiklasSvenzen submitted PR Review.
Github Notifications (FHIRcast) (Nov 30 2020 at 22:21):
wmaethner submitted PR Review.
Github Notifications (FHIRcast) (Nov 30 2020 at 22:21):
wmaethner submitted PR Review.
Github Notifications (FHIRcast) (Nov 30 2020 at 22:21):
wmaethner created PR Review Comment:
Few things:
- Should processing be in the fancy quotes `` since it is a code value or is it just a string (in which case should it be in normal quotes)?
- Is "error'd" correct? Should it be like the previous sentence and be "event that this error is related to"? That's wordy so I am open to a shorter wording.
Github Notifications (FHIRcast) (Nov 30 2020 at 22:25):
isaacvetter submitted PR Review.
Github Notifications (FHIRcast) (Nov 30 2020 at 22:25):
isaacvetter created PR Review Comment:
`operationoutcome` | OPTIONAL | `OperationOutcome` | FHIR resource describing an outcome of an unsuccessful system action. The OperationOutcome SHALL use a code of `processing`. The OperationOutcome's `details.coding.code` SHALL contain the id of the event that this error is related to as a `code` with the `system` value of "https://fhircast.hl7.org/events/syncerror/eventid" and the name of the relevant event with a `system` value of "https://fhircast.hl7.org/events/syncerror/eventname" . Other `coding` values can be included with different `system` values so as to include extra information about the `syncerror`.
Github Notifications (FHIRcast) (Nov 30 2020 at 22:25):
isaacvetter updated PR #346 from eventname-to-syncerror to master:
Github Notifications (FHIRcast) (Nov 30 2020 at 22:25):
isaacvetter submitted PR Review.
Github Notifications (FHIRcast) (Nov 30 2020 at 22:25):
isaacvetter created PR Review Comment:
updated. What do you think?
Github Notifications (FHIRcast) (Nov 30 2020 at 22:29):
isaacvetter updated PR #346 from eventname-to-syncerror to master:
Github Notifications (FHIRcast) (Nov 30 2020 at 22:29):
wmaethner submitted PR Review.
Github Notifications (FHIRcast) (Nov 30 2020 at 22:30):
isaacvetter merged PR #346.
Last updated: Apr 12 2022 at 19:14 UTC
