FHIR Chat · fhircast-docs / PR #327 Sub and unsub2 · fhircast-github

Stream: fhircast-github

Topic: fhircast-docs / PR #327 Sub and unsub2


view this post on Zulip Github Notifications (FHIRcast) (Aug 04 2020 at 12:59):

NiklasSvenzen opened PR #327 from SubAndUnsub2 to master:

Same as Sub and unsub2 PR, with the following additions:

FHIR-25833 - Unsubscribe and events
FHIR-25837 - Unsubscriptions and websockets

view this post on Zulip Github Notifications (FHIRcast) (Aug 04 2020 at 13:00):

NiklasSvenzen requested isaacvetter for a review on PR #327.

view this post on Zulip Github Notifications (FHIRcast) (Aug 04 2020 at 13:00):

NiklasSvenzen requested wmaethner for a review on PR #327.

view this post on Zulip Github Notifications (FHIRcast) (Aug 04 2020 at 13:00):

NiklasSvenzen requested isaacvetter and wmaethner for a review on PR #327.

view this post on Zulip Github Notifications (FHIRcast) (Aug 04 2020 at 15:59):

wmaethner submitted PR Review.

view this post on Zulip Github Notifications (FHIRcast) (Aug 04 2020 at 16:22):

isaacvetter submitted PR Review.

view this post on Zulip Github Notifications (FHIRcast) (Aug 04 2020 at 16:22):

isaacvetter created PR Review Comment:

Once a subscribing app no longer wants to receive event notifications, it SHALL unsubscribe from the session. The unsubscribe request message mirrors the subscribe request message, except for the omission of `hub.events`. An unsubscribe cannot alter an existing subscription, only cancel it. To unsubscribe, the `hub.mode` SHALL be equal to the lowercase string _unsubscribe_.  Only `webhook` unsubscribes SHALL include the `hub.callback`, `hub.secret`, and `hub.challenge`. Only `websocket` unsubscribes SHALL include the wss WebSocket url in `hub.channel.endpoint`. Note that the unsubscribe request is performed over HTTP, even for subscriptions using WebSockets. `websocket` unsubscribes will destroy the websocket which cannot be reused. A subsequent subscription will be done over a newly created and communicated WebSocket endpoint.

view this post on Zulip Github Notifications (FHIRcast) (Aug 04 2020 at 16:23):

isaacvetter updated PR #327 from SubAndUnsub2 to master:

Same as Sub and unsub2 PR, with the following additions:

FHIR-25833 - Unsubscribe and events
FHIR-25837 - Unsubscriptions and websockets

view this post on Zulip Github Notifications (FHIRcast) (Aug 04 2020 at 16:25):

isaacvetter submitted PR Review.

view this post on Zulip Github Notifications (FHIRcast) (Aug 13 2020 at 18:04):

isaacvetter merged PR #327.


Last updated: Apr 12 2022 at 19:14 UTC