Stream: fhircast-github
Topic: fhircast-docs / PR #314 Stu2 overview section
Github Notifications (FHIRcast) (Jun 16 2020 at 16:49):
isaacvetter opened PR #314 from stu2-overview-section to master:
Various minor working changes, correction of capitalizations (UUID, WebSocket), add revision history.
Addresses:
- https://jira.hl7.org/browse/FHIR-25803
- https://jira.hl7.org/browse/FHIR-25804
- https://jira.hl7.org/browse/FHIR-25806
- https://jira.hl7.org/browse/FHIR-25878
- https://jira.hl7.org/browse/FHIR-25883
- https://jira.hl7.org/browse/FHIR-25884
- https://jira.hl7.org/browse/FHIR-25886
- https://jira.hl7.org/browse/FHIR-25895
Github Notifications (FHIRcast) (Jun 16 2020 at 16:49):
isaacvetter requested wmaethner and NiklasSvenzen for a review on PR #314.
Github Notifications (FHIRcast) (Jun 16 2020 at 16:49):
isaacvetter requested wmaethner and NiklasSvenzen for a review on PR #314.
Github Notifications (FHIRcast) (Jun 18 2020 at 13:29):
wmaethner submitted PR Review.
Github Notifications (FHIRcast) (Jun 18 2020 at 13:29):
wmaethner created PR Review Comment:
For issue 25878 seems like we just removed the "by the Hub" part, but didn't define the Hub. Should we?
Github Notifications (FHIRcast) (Jun 18 2020 at 13:46):
wmaethner submitted PR Review.
Github Notifications (FHIRcast) (Jun 18 2020 at 16:02):
isaacvetter submitted PR Review.
Github Notifications (FHIRcast) (Jun 18 2020 at 16:02):
isaacvetter created PR Review Comment:
Hey Will,
I was considering this new sentence as a definition of the Hub:
A Hub exposes APIs for subsubscribing and unsubscribing, requesting context changes and also distribute event notifications. Hubs SHOULD support WebSockets and MAY support webhooks.
I considered WebSub's definition as a model: https://www.w3.org/TR/websub/#hub
What do you think?
Isaac
Github Notifications (FHIRcast) (Jun 18 2020 at 17:10):
wmaethner submitted PR Review.
Github Notifications (FHIRcast) (Jun 18 2020 at 17:10):
wmaethner created PR Review Comment:
Yeah that looks perfect to me.
Github Notifications (FHIRcast) (Jun 18 2020 at 17:10):
wmaethner submitted PR Review.
Github Notifications (FHIRcast) (Jun 22 2020 at 18:06):
NiklasSvenzen submitted PR Review.
Github Notifications (FHIRcast) (Jun 23 2020 at 17:56):
isaacvetter updated PR #314 from stu2-overview-section to master:
Various minor working changes, correction of capitalizations (UUID, WebSocket), add revision history.
Addresses:
- https://jira.hl7.org/browse/FHIR-25803
- https://jira.hl7.org/browse/FHIR-25804
- https://jira.hl7.org/browse/FHIR-25806
- https://jira.hl7.org/browse/FHIR-25878
- https://jira.hl7.org/browse/FHIR-25883
- https://jira.hl7.org/browse/FHIR-25884
- https://jira.hl7.org/browse/FHIR-25886
- https://jira.hl7.org/browse/FHIR-25895
Github Notifications (FHIRcast) (Jun 23 2020 at 17:59):
isaacvetter merged PR #314.
Last updated: Apr 12 2022 at 19:14 UTC
