FHIR Chat · fhircast-docs / PR #295 Stu2 add websockets · fhircast-github

Stream: fhircast-github

Topic: fhircast-docs / PR #295 Stu2 add websockets

---

Github Notifications (FHIRcast) (Oct 25 2019 at 18:54):

isaacvetter opened PR #295 from stu2-add-websockets to master:

First take on formal websocket support in spec.

Github Notifications (FHIRcast) (Oct 25 2019 at 18:54):

isaacvetter requested lbergnehr, wmaethner, and NiklasSvenzen for a review on PR #295.

Github Notifications (FHIRcast) (Oct 25 2019 at 18:54):

isaacvetter requested lbergnehr, wmaethner, and NiklasSvenzen for a review on PR #295.

Github Notifications (FHIRcast) (Oct 25 2019 at 18:54):

isaacvetter requested lbergnehr, wmaethner, and NiklasSvenzen for a review on PR #295.

Github Notifications (FHIRcast) (Oct 28 2019 at 15:41):

wmaethner submitted PR Review.

Github Notifications (FHIRcast) (Oct 28 2019 at 15:41):

wmaethner submitted PR Review.

Github Notifications (FHIRcast) (Oct 28 2019 at 15:41):

wmaethner created PR Review Comment:

Should there be an asterisk after this for the websocket exchange?

Github Notifications (FHIRcast) (Oct 28 2019 at 15:41):

wmaethner created PR Review Comment:

There isn't really an intent verification in websockets but it may be worth adding a note of that. I was looking for websockets information under the intent verification section (even though there really isn't anything) so I'm sure other people would too.

Github Notifications (FHIRcast) (Oct 28 2019 at 15:41):

wmaethner created PR Review Comment:

The pipe between websocket and webhook makes it not show up when actually viewing the file.

Github Notifications (FHIRcast) (Nov 12 2019 at 14:01):

isaacvetter submitted PR Review.

Github Notifications (FHIRcast) (Nov 12 2019 at 14:01):

isaacvetter created PR Review Comment:

Will, not this section already exists:

webhook Intent Verification

If a subscription with hub.channel.type=webhook is not denied, the Hub SHALL perform the verification of intent of the subscriber, this applies to apps unsubscribing as well. The hub.callback url verification process ensures that the subscriber actually controls the callback url. Note the verification of intent and the hub.callback url SHALL only be used for subscriptions over webhooks.

Any suggestions for improving it?

Github Notifications (FHIRcast) (Nov 12 2019 at 14:01):

isaacvetter edited PR Review Comment.

Github Notifications (FHIRcast) (Nov 12 2019 at 14:01):

isaacvetter updated PR #295 from stu2-add-websockets to master:

First take on formal websocket support in spec.

Github Notifications (FHIRcast) (Nov 15 2019 at 00:27):

wmaethner submitted PR Review.

Github Notifications (FHIRcast) (Nov 15 2019 at 00:27):

wmaethner created PR Review Comment:

Ahh got it. That is probably fine, I guess if we were to add a line that is a little more explicit in saying "websockets does not have any intent verification process" or something similar then that couldn't hurt.

Github Notifications (FHIRcast) (Nov 15 2019 at 01:56):

isaacvetter updated PR #295 from stu2-add-websockets to master:

First take on formal websocket support in spec.

Github Notifications (FHIRcast) (Nov 15 2019 at 02:20):

isaacvetter updated PR #295 from stu2-add-websockets to master:

First take on formal websocket support in spec.

Github Notifications (FHIRcast) (Nov 15 2019 at 02:55):

isaacvetter updated PR #295 from stu2-add-websockets to master:

First take on formal websocket support in spec.

Github Notifications (FHIRcast) (Nov 15 2019 at 04:11):

isaacvetter updated PR #295 from stu2-add-websockets to master:

First take on formal websocket support in spec.

Github Notifications (FHIRcast) (Nov 15 2019 at 04:15):

isaacvetter submitted PR Review.

Github Notifications (FHIRcast) (Nov 15 2019 at 04:15):

isaacvetter created PR Review Comment:

Will, I just added a "subscription confirmation" step, see: #299 and changes in this PR? What do you think?

Github Notifications (FHIRcast) (Nov 15 2019 at 13:47):

wmaethner submitted PR Review.

Github Notifications (FHIRcast) (Nov 15 2019 at 13:47):

wmaethner submitted PR Review.

Github Notifications (FHIRcast) (Nov 15 2019 at 13:47):

wmaethner created PR Review Comment:

So are the unique identifying combos topic/callback (for webhook) and endpoint/events (for websocket)? The only real difference between the two methods is the callback and endpoint so shouldn't the rest be the same? So shouldn't topic be included in the websockets uniqueness and what about events for webhook?

Github Notifications (FHIRcast) (Nov 15 2019 at 13:57):

wmaethner created PR Review Comment:

Read this wrong, this is what I expected.

Github Notifications (FHIRcast) (Nov 15 2019 at 13:57):

wmaethner submitted PR Review.

Github Notifications (FHIRcast) (Nov 15 2019 at 13:57):

wmaethner submitted PR Review.

Github Notifications (FHIRcast) (Nov 15 2019 at 13:58):

isaacvetter merged PR #295.

---

Last updated: Apr 12 2022 at 19:14 UTC