Stream: fhircast-github
Topic: fhircast-docs / PR #265 Fixes to Request Context Change s...
Github Notifications (FHIRcast) (Aug 14 2019 at 13:45):
wmaethner requested isaacvetter, lbergnehr, and NiklasSvenzen for a review on PR #265.
Github Notifications (FHIRcast) (Aug 14 2019 at 13:45):
wmaethner requested isaacvetter, lbergnehr, and NiklasSvenzen for a review on PR #265.
Github Notifications (FHIRcast) (Aug 14 2019 at 13:45):
wmaethner opened PR #265 from Ballot-Fixes-Request-Context-Change to master:
Fixes issue: #144, #170, #209,
Github Notifications (FHIRcast) (Aug 14 2019 at 13:45):
wmaethner requested isaacvetter, lbergnehr, and NiklasSvenzen for a review on PR #265.
Github Notifications (FHIRcast) (Aug 15 2019 at 18:41):
lbergnehr submitted PR Review.
Github Notifications (FHIRcast) (Aug 15 2019 at 18:41):
lbergnehr submitted PR Review.
Github Notifications (FHIRcast) (Aug 15 2019 at 18:41):
lbergnehr created PR Review Comment:
This id SHALL be generated by and unique for the subscriber, for example a GUID.
This sentence probably needs a little rewording. Perhaps "This id SHALL be uniquely generated by the subscriber and could be a GUID.".
Github Notifications (FHIRcast) (Aug 15 2019 at 18:41):
lbergnehr created PR Review Comment:
`hub.topic` | Required | string | The topic session URI given in the subscription request.
Github Notifications (FHIRcast) (Aug 15 2019 at 18:41):
lbergnehr created PR Review Comment:
Perhaps
... OAuth2
access_token.or
... OAuth2 access token.
Github Notifications (FHIRcast) (Aug 15 2019 at 19:14):
wmaethner updated PR #265 from Ballot-Fixes-Request-Context-Change to master:
Fixes issue: #144, #170, #209,
Github Notifications (FHIRcast) (Aug 15 2019 at 19:14):
wmaethner created PR Review Comment:
Updated
Github Notifications (FHIRcast) (Aug 15 2019 at 19:14):
wmaethner submitted PR Review.
Github Notifications (FHIRcast) (Aug 15 2019 at 19:14):
wmaethner submitted PR Review.
Github Notifications (FHIRcast) (Aug 15 2019 at 19:14):
wmaethner created PR Review Comment:
Updated
Github Notifications (FHIRcast) (Aug 15 2019 at 19:15):
wmaethner submitted PR Review.
Github Notifications (FHIRcast) (Aug 15 2019 at 19:15):
wmaethner created PR Review Comment:
Updated
Github Notifications (FHIRcast) (Aug 15 2019 at 19:15):
wmaethner requested isaacvetter, lbergnehr, and NiklasSvenzen for a review on PR #265.
Github Notifications (FHIRcast) (Aug 15 2019 at 19:27):
lbergnehr submitted PR Review.
Github Notifications (FHIRcast) (Aug 19 2019 at 14:39):
isaacvetter submitted PR Review.
Github Notifications (FHIRcast) (Aug 19 2019 at 14:39):
isaacvetter created PR Review Comment:
`id` | Required | *string* | Event identifier used to recognize retried notifications. This id SHALL be uniquely generated by the subscriber and could be a GUID. Following an accepted context change request, the hub MAY re-use this value in the broadcasted event notifications.@wmaethner - I think that we need this additional sentence to fully address #170.
Github Notifications (FHIRcast) (Aug 19 2019 at 15:07):
wmaethner updated PR #265 from Ballot-Fixes-Request-Context-Change to master:
Fixes issue: #144, #170, #209,
Github Notifications (FHIRcast) (Aug 19 2019 at 15:07):
wmaethner requested isaacvetter, and NiklasSvenzen for a review on PR #265.
Github Notifications (FHIRcast) (Aug 19 2019 at 15:09):
isaacvetter edited PR #265 from Ballot-Fixes-Request-Context-Change to master:
Fixes #144, #170, #209
Github Notifications (FHIRcast) (Aug 19 2019 at 15:10):
isaacvetter submitted PR Review.
Github Notifications (FHIRcast) (Aug 19 2019 at 15:10):
isaacvetter merged PR #265.
Last updated: Apr 12 2022 at 19:14 UTC
