Stream: fhircast-github
Topic: fhircast-docs / PR #260 Subscription request section fixes
Github Notifications (FHIRcast) (Jul 15 2019 at 18:05):
wmaethner requested isaacvetter, lbergnehr, and NiklasSvenzen for a review on PR #260.
Github Notifications (FHIRcast) (Jul 15 2019 at 18:05):
wmaethner requested isaacvetter, lbergnehr, and NiklasSvenzen for a review on PR #260.
Github Notifications (FHIRcast) (Jul 15 2019 at 18:05):
wmaethner requested isaacvetter, lbergnehr, and NiklasSvenzen for a review on PR #260.
Github Notifications (FHIRcast) (Jul 15 2019 at 18:05):
wmaethner opened PR #260 from subscription-request-STU1-fixes to master:
Fixes to issues: #92, #130, #131, #132, #184, #186, #187, #188, #189, #190
Github Notifications (FHIRcast) (Jul 23 2019 at 13:13):
isaacvetter updated PR #260 from subscription-request-STU1-fixes to master:
Fixes to issues: #92, #130, #131, #132, #184, #186, #187, #188, #189, #190
Github Notifications (FHIRcast) (Jul 23 2019 at 13:14):
isaacvetter submitted PR Review.
Github Notifications (FHIRcast) (Jul 23 2019 at 13:25):
wmaethner updated PR #260 from subscription-request-STU1-fixes to master:
Fixes to issues: #92, #130, #131, #132, #184, #186, #187, #188, #189, #190
Github Notifications (FHIRcast) (Jul 23 2019 at 13:56):
NiklasSvenzen submitted PR Review.
Github Notifications (FHIRcast) (Jul 23 2019 at 13:57):
NiklasSvenzen updated PR #260 from subscription-request-STU1-fixes to master:
Fixes to issues: #92, #130, #131, #132, #184, #186, #187, #188, #189, #190
Github Notifications (FHIRcast) (Aug 09 2019 at 13:06):
lbergnehr submitted PR Review.
Github Notifications (FHIRcast) (Aug 09 2019 at 13:06):
lbergnehr submitted PR Review.
Github Notifications (FHIRcast) (Aug 09 2019 at 13:06):
lbergnehr created PR Review Comment:
Period inside parentheses:
The client that creates the subscription may not be the same system as the server hosting the callback url. (For example, some type of federated authorization model could possibly exist between these two systems.) However, in FHIRcast, the hub assumes that the same authorization and access rights apply to both the subscribing client and the callback url.
Github Notifications (FHIRcast) (Aug 09 2019 at 13:06):
lbergnehr created PR Review Comment:
Maybe we want to link to the HMAC page as we do elsewhere:
`hub.secret` | Required | *string* | A subscriber-provided cryptographically random unique secret string that SHALL be used to compute an [HMAC digest](https://www.w3.org/TR/websub/#bib-RFC6151) delivered in each notification. This parameter SHALL be less than 200 bytes in length.
Github Notifications (FHIRcast) (Aug 09 2019 at 13:06):
lbergnehr created PR Review Comment:
We most often use _[the] Hub_ than _[the] hub_.
The client that creates the subscription may not be the same system as the server hosting the callback url. (For example, some type of federated authorization model could possibly exist between these two systems). However, in FHIRcast, the Hub assumes that the same authorization and access rights apply to both the subscribing client and the callback url.
Github Notifications (FHIRcast) (Aug 09 2019 at 13:06):
lbergnehr created PR Review Comment:
Hubs SHALL allow subscribers to re-request subscriptions that are already activated. Each subsequent and verified request to a Hub to subscribe or unsubscribe SHALL override the previous subscription state for a specific topic / callback URL combination.
Github Notifications (FHIRcast) (Aug 09 2019 at 13:06):
lbergnehr created PR Review Comment:
This request SHALL have a `Content-Type` header of `application/x-www-form-urlencoded` and SHALL use the following parameters in its body, formatted accordingly:
Github Notifications (FHIRcast) (Aug 09 2019 at 13:06):
lbergnehr created PR Review Comment:
The client that creates the subscription may not be the same system as the server hosting the callback url. (For example, some type of federated authorization model could possibly exist between these two systems.) However, in FHIRcast, the Hub assumes that the same authorization and access rights apply to both the subscribing client and the callback url.
Github Notifications (FHIRcast) (Aug 09 2019 at 13:06):
lbergnehr created PR Review Comment:
Some minor stuff.
The callback URL MAY contain arbitrary query string parameters (e.g., `?foo=bar&red=fish`). Hubs SHALL preserve the query string during subscription verification by appending new, Hub-defined, parameters to the end of the list using the `&` (ampersand) character to join. When sending the event notifications, the Hub SHALL make a POST request to the callback URL including any query string parameters in the URL portion of the request, not as POST body parameters.
Github Notifications (FHIRcast) (Aug 09 2019 at 13:18):
wmaethner updated PR #260 from subscription-request-STU1-fixes to master:
Fixes to issues: #92, #130, #131, #132, #184, #186, #187, #188, #189, #190
Github Notifications (FHIRcast) (Aug 09 2019 at 13:18):
wmaethner updated PR #260 from subscription-request-STU1-fixes to master:
Fixes to issues: #92, #130, #131, #132, #184, #186, #187, #188, #189, #190
Github Notifications (FHIRcast) (Aug 09 2019 at 13:19):
wmaethner updated PR #260 from subscription-request-STU1-fixes to master:
Fixes to issues: #92, #130, #131, #132, #184, #186, #187, #188, #189, #190
Github Notifications (FHIRcast) (Aug 09 2019 at 13:20):
wmaethner updated PR #260 from subscription-request-STU1-fixes to master:
Fixes to issues: #92, #130, #131, #132, #184, #186, #187, #188, #189, #190
Github Notifications (FHIRcast) (Aug 09 2019 at 13:20):
wmaethner updated PR #260 from subscription-request-STU1-fixes to master:
Fixes to issues: #92, #130, #131, #132, #184, #186, #187, #188, #189, #190
Github Notifications (FHIRcast) (Aug 09 2019 at 13:20):
wmaethner updated PR #260 from subscription-request-STU1-fixes to master:
Fixes to issues: #92, #130, #131, #132, #184, #186, #187, #188, #189, #190
Github Notifications (FHIRcast) (Aug 09 2019 at 13:21):
wmaethner updated PR #260 from subscription-request-STU1-fixes to master:
Fixes to issues: #92, #130, #131, #132, #184, #186, #187, #188, #189, #190
Github Notifications (FHIRcast) (Aug 09 2019 at 13:22):
wmaethner updated PR #260 from subscription-request-STU1-fixes to master:
Fixes to issues: #92, #130, #131, #132, #184, #186, #187, #188, #189, #190
Github Notifications (FHIRcast) (Aug 14 2019 at 13:16):
wmaethner requested lbergnehr for a review on PR #260.
Github Notifications (FHIRcast) (Aug 14 2019 at 13:16):
wmaethner requested lbergnehr, and NiklasSvenzen for a review on PR #260.
Github Notifications (FHIRcast) (Aug 15 2019 at 18:27):
lbergnehr submitted PR Review.
Github Notifications (FHIRcast) (Aug 19 2019 at 14:08):
wmaethner merged PR #260.
Last updated: Apr 12 2022 at 19:14 UTC
