Stream: fhircast-github
Topic: fhircast-docs / Issue #276 Event rewrite
Github Notifications (FHIRcast) (Sep 09 2019 at 20:40):
isaacvetter commented on Issue #276:
Hey Niklas, Fixed! Good catch. I mostly copied the CDS Hooks maturity model. Our FHIRcast maturity model is defined as part of the core specification, here: https://github.com/HL7/fhircast-docs/blob/f421bcdda27e8221e776bd9c564114998ebfbc6b/docs/specification/STU1.md#event-maturity-model
Isaac
Github Notifications (FHIRcast) (Sep 10 2019 at 15:04):
wmaethner commented on Issue #276:
Few things:
1. The JSON in the event examples isn't formatted (at least when I opened it for viewing) and instead shows up as one big section of text. Can we show it properly formatted to make it easier to read.
2. The hub topics in the examples still use the url format rather than the GUID format you added in a recent PR.
3. We call out the syncerror event as being infrastructural and not defined outside the spec like the others, yet it is still in the event catalog like the other events. Is that intended?
Github Notifications (FHIRcast) (Sep 10 2019 at 18:32):
isaacvetter commented on Issue #276:
Hey @wmaethner!
1. The JSON in the event examples isn't formatted (at least when I opened it for viewing) and instead shows up as one big section of text. Can we show it properly formatted to make it easier to read.
You mean the examples section on each event page, right? I see it as formatted when running locally, like this:
And specifically, it's the "```json: markdown command that does this, for example, here: https://github.com/HL7/fhircast-docs/pull/276/files#diff-5f60a799e354568d9703b19519020082R22
Any idea what might be causing you to see something different?
2. The hub topics in the examples still use the url format rather than the GUID format you added in a recent PR.
Ah, darn, fixed!
3. We call out the syncerror event as being infrastructural and not defined outside the spec like the others, yet it is still in the event catalog like the other events. Is that intended?
It was intended. I thought that it was important to document the same information. Do you think we should move it's documentation entirely into the base spec? The base spec does describe how to use it.
Github Notifications (FHIRcast) (Sep 10 2019 at 18:33):
isaacvetter edited a comment on Issue #276:
Hey @wmaethner!
1. The JSON in the event examples isn't formatted (at least when I opened it for viewing) and instead shows up as one big section of text. Can we show it properly formatted to make it easier to read.
You mean the examples section on each event page, right? I see it as formatted when running locally, like this:
And specifically, it's the
```json:markdown command that does this, for example, here: https://github.com/HL7/fhircast-docs/pull/276/files#diff-5f60a799e354568d9703b19519020082R22Any idea what might be causing you to see something different?
2. The hub topics in the examples still use the url format rather than the GUID format you added in a recent PR.
Ah, darn, fixed!
3. We call out the syncerror event as being infrastructural and not defined outside the spec like the others, yet it is still in the event catalog like the other events. Is that intended?
It was intended. I thought that it was important to document the same information. Do you think we should move it's documentation entirely into the base spec? The base spec does describe how to use it.
Github Notifications (FHIRcast) (Sep 10 2019 at 18:37):
wmaethner commented on Issue #276:
1. It must just be when you look at it in the "Files Changed" section. If that's how it looks when published then we are good.
2. Cool
3. Yeah that sounds good, I just wanted to confirm
Last updated: Apr 12 2022 at 19:14 UTC
