Stream: fhircast-github
Topic: fhircast-docs / Issue #266 Fixes to subscription response...
Github Notifications (FHIRcast) (Aug 19 2019 at 14:14):
isaacvetter commented on Issue #266:
@wmaethner - love the diagrams! Two questions/suggestions:
1) You're committing just the images of the diagrams, not the source materials, such that editing them would require re-creating them. Can you also commit the source (for example, if you were using websequencediagrams.com, the textual representation of the diagram in a text file).
2) Your denial diagram strongly implies that a denial will only and ever immediately follow a subscription request. Our spec, as well as the WebSub spec are clear that a denial may occur at any time, even after having successfully sent notifications. What do you think about updating the diagram's text callout, to something like this:
App subscribes to hub. Hub denies subscription. This denial may occur at any time, even after a successful intent verification or event notifications.
Github Notifications (FHIRcast) (Sep 03 2019 at 13:38):
wmaethner commented on Issue #266:
Hey @isaacvetter,
I think I shared the diagrams and referenced them the same way you did in the other PR. Let me know if I missed anything.
-Will
Last updated: Apr 12 2022 at 19:14 UTC
