Stream: Ballot-QA
Topic: 2018-08 ballot QA
Rick Geimer (Aug 18 2018 at 00:28):
I'm reviewing resourcelist.html to ensure all resources are present.
Rick Geimer (Aug 18 2018 at 00:41):
The following resources are not listed on the Alphabetical tab of resourcelist.html:
Invoice
MedicinalProductContraindication
MedicinalProductIndication
MedicinalProductInteraction
MedicinalProductManufactured
MedicinalProductUndesirableEffect
Rick Geimer (Aug 18 2018 at 00:41):
The following resource is out of Aphabetical order on the Alphabetical tab of resourcelist.html:
InsurancePlan
Grahame Grieve (Aug 18 2018 at 00:50):
thanks muchly
Bushra Khatoon (Nov 14 2018 at 09:57):
Hi, I have been assigned the 'devicecomponent' resource for QA but it's not included in the QA pack. Is this the right resource?
Lloyd McKenzie (Nov 14 2018 at 10:12):
DeviceComponent doesn't exist anymore - so I guess you're getting off slightly easier :)
Bushra Khatoon (Nov 14 2018 at 11:52):
:relaxed: :thumbs_up:
David Hay (Nov 14 2018 at 17:49):
oops - looks like I better check that the list is correct!
David Hay (Nov 14 2018 at 18:13):
Hi Bushra - to confirm that you're using this spreadsheet: https://docs.google.com/spreadsheets/d/1llEblkmvBCBUgJAjutweVMK8F1mm2vO5Xj0v6K_Ny6o/edit#gid=0
David Hay (Nov 14 2018 at 18:34):
ANd instructions are here: https://docs.google.com/document/d/1-kMS-S0dgxa5pyK_87g_DiZonSS7FRuTvqwPUmDH6FQ/edit#
David Hay (Nov 14 2018 at 18:34):
so sorry, not getting off easier at all!
Bushra Khatoon (Nov 15 2018 at 09:44):
Ah, The link sent out with the zip file (14/11/18) is this: https://docs.google.com/document/d/1-kMS-S0dgxa5pyK_87g_DiZonSS7FRuTvqwPUmDH6FQ/edit# and I'd followed the link in that to get to the rogue spreadsheet. Thanks for looking into this, I'll check the new one and get started!
David Hay (Nov 15 2018 at 19:43):
Weird - I must have put in a bad link somewhere. Anyway - all good now, and you're the first to complete!
Sheila Connelly (Nov 16 2018 at 12:28):
Reviewing Terminology - question. There are three columns. Code, Display, Definition. Generally all the Code items are lower case, and the Display items are initial cap each major word. When this pattern is not followed, should I fix? Is there a pattern to follow? In particular, there are many instances of Display for "Entered in Error" with various capitalizations. Can I make them all consistent to read: "Entered in Error"?
Lloyd McKenzie (Nov 16 2018 at 12:51):
If the codes are ones that FHIR defines, you can propose the change. For codes defined by v2, v3, LOINC, SNOMED, etc., we can't fix those things, so not much point. (And in terms of changing case of codes themselves, we'll be cautious about making changes at this point in the publication cycle. You can flag them, but we may defer them to the next release or make the determination that it's too late.
Sheila Connelly (Nov 16 2018 at 12:54):
Does it work if for some I add a note about the issues seen above the table, and for others use Word's revision feature to mark the change? The person making the actual changes can then decide whether or not to do it.
Lloyd McKenzie (Nov 16 2018 at 12:55):
That should work.
David Hay (Nov 16 2018 at 17:44):
Just a reminder that the reviewed files will be MSWord documents (with changes tracked). We're have a couple returned (which is great!) but they've come back as html files, which we can't use... (They're distributed as html, but part of the review process is to import them into word...)
Peter Jordan (Nov 18 2018 at 05:39):
Has a decision been made in the past to use 'errata' as both the singular and plural of the relevant noun throughout the FHIR spec? If not, I'm guessing that there are a lot of corrections to be made on that count!
Lloyd McKenzie (Nov 18 2018 at 13:07):
According to this: https://www.dictionary.com/browse/errata, errata refers to the list - and thus whether it's referring to a list of 0, 1 or more than one, the word is the same.
Peter Jordan (Nov 18 2018 at 21:10):
Erratum is the preferred singular form in the Queen's English - but happy to accept modern day custom and practice. :relaxed:
David Hay (Nov 18 2018 at 22:23):
Remember this is American english!
Sheila Connelly (Nov 20 2018 at 13:56):
TERMINOLOGY CONSISTENCY
As I was reviewing my Terminology documents, I saw inconsistencies. Such as: Entered In Error vs. Entered in error vs. Entered in Error. I marked revisions to capitalize all as 'Entered in Error', but changing may or may not be possible. This got me looking at Terms as a whole. I thought that all instances of Entered in Error should have similar definitions. Same for Cancelled. Shouldn't definitions be worded as consistently as possible?
To take a better look at consistency, I added the entries for the various Status CodeSystems found in my three docs to a spreadsheet to look and see their consistency for Codes, Display, and Definition.
I emailed David Hay about this. And although it is outside the scope of this effort, he suggested I post and see what others thought.
terminology_entered_in_error.png
Lloyd McKenzie (Nov 20 2018 at 15:46):
Consistency of capitalization we can fix as part of QA. Consistency of definitions should be submitted as a change request and may have to wait until R5.
Bob Milius (Nov 29 2018 at 18:20):
@David Hay I've signed up to help with the QA, and from the link to the spreadsheet posted in this thread I see I've been assigned a few things, but where do I get the QA Pack (zip file?) that's been described? I haven't received anything in email. I have time to review before the deadline.
David Hay (Nov 29 2018 at 18:48):
Hi Bob - sorry about that - saw your email but slow in responding. Hopefully this upload will work! Archive.zip
Bob Milius (Nov 29 2018 at 19:07):
thanks, @David Hay !
David Hay (Nov 29 2018 at 19:24):
no - thanks to you!
Michael van der Zel (Nov 30 2018 at 12:51):
I found a couple of "Todo" and even "Lorum ips..." in the files I reviewed. What do we do with those?
David Hay (Nov 30 2018 at 17:06):
make a comment in the doc. The committee needs to review...
Michael van der Zel (Dec 03 2018 at 19:57):
Is there still time enough or can it be a general note to the committees that they resolve their TODO's?
Last updated: Apr 12 2022 at 19:14 UTC
