Stream: Orders and Observation WG
Topic: deprecated Examples and Extensions
Patrick Werner (Sep 26 2019 at 14:26):
As we discussed during the WGM in Atlanta last week the Genomics WG identified missing deprecated labels on genomic related Examples and Extensions as these are replaced by the CG IG. For the MolecularSequence Resource a header was already introduced (same for the Genomics Implementation Guidance: https://www.hl7.org/fhir/genomics.html ).
We'd like to have a label with the Text:
Deprecation note:
The material on this page is deprecated and being replaced by the Genomics Reporting Implementation Guide.
on the following pages:
https://www.hl7.org/fhir/observation-examples.html#10.1.7.4
https://www.hl7.org/fhir/observation-example-genetics-1.html
https://www.hl7.org/fhir/observation-example-genetics-2.html
https://www.hl7.org/fhir/observation-example-genetics-4.html
https://www.hl7.org/fhir/observation-example-genetics-5.html
https://www.hl7.org/fhir/observation-example-diplotype1.html
https://www.hl7.org/fhir/observation-example-haplotype1.html
https://www.hl7.org/fhir/observation-example-haplotype2.html
https://www.hl7.org/fhir/observation-example-phenotype.html
https://www.hl7.org/fhir/observation-example-TPMT-diplotype.html
https://www.hl7.org/fhir/observation-example-TPMT-haplotype-one.html
https://www.hl7.org/fhir/observation-example-TPMT-haplotype-two.html
Patrick Werner (Sep 26 2019 at 14:27):
https://www.hl7.org/fhir/hlaresult.html
Profile:
https://www.hl7.org/fhir/observation-genetics.html
Extension:
https://www.hl7.org/fhir/extension-observation-geneticsallele.html
https://www.hl7.org/fhir/extension-observation-geneticsaminoacidchange.html
https://www.hl7.org/fhir/extension-observation-geneticsancestry.html
https://www.hl7.org/fhir/extension-observation-geneticscopynumberevent.html
https://www.hl7.org/fhir/extension-observation-geneticsdnaregionname.html
https://www.hl7.org/fhir/extension-observation-geneticsgene.html
https://www.hl7.org/fhir/extension-observation-geneticsgenomicsourceclass.html
https://www.hl7.org/fhir/extension-observation-geneticsinterpretation.html
https://www.hl7.org/fhir/extension-observation-geneticsphaseset.html
https://www.hl7.org/fhir/extension-observation-geneticsvariant.html
https://www.hl7.org/fhir/extension-servicerequest-geneticsitem.html
https://www.hl7.org/fhir/extension-diagnosticreport-geneticsanalysis.html
https://www.hl7.org/fhir/extension-diagnosticreport-geneticsassessedcondition.html
https://www.hl7.org/fhir/extension-diagnosticreport-geneticsfamilymemberhistory.html
https://www.hl7.org/fhir/extension-diagnosticreport-geneticsreferences.html
https://www.hl7.org/fhir/extension-observation-geneticsinterpretation.html
Patrick Werner (Sep 26 2019 at 14:32):
This example:
https://www.hl7.org/fhir/observation-example-genetics-3.html
should be deleted as it is not compliant to the usage notes. This example is just bad practice (e.g. no value, textual value in note..) and shouldn't be there.
It would be really nice to have this included into the R4 technical corrections (if still possible @Grahame Grieve )?
If a PR to FHIR CI build helps to speed this up/enables the technical correction, i'll be happy to apply these.
Patrick Werner (Sep 26 2019 at 14:35):
as agreed during the WGM i mention all co-chairs.@Hans Buitendijk @David Burgess @Lorraine Constable @Rob Hausam @Ralf Herzog @Patrick E. Loyd @John David Larkin Nolen
Patrick Werner (Sep 26 2019 at 14:41):
Patrick Werner (Oct 10 2019 at 10:15):
I wanted to ask if there is any update on this? Would be really nice to be able to include these changes into R4 TC.
Patrick Werner (Oct 10 2019 at 12:03):
I can also volunteer to apply these changes, so just need a vote on this.
Rob Hausam (Oct 10 2019 at 15:33):
Appreciate your follow up on this @Patrick Werner. I asked @Grahame Grieve a general question on whether example changes are potentially candidates for inclusion in the TC, or if the TC would be limited to only substantive changes? I haven't seen a response from him on that yet, but maybe he can weigh in for this particular question. Of course, deprecating extensions is a substantive change.
Patrick Werner (Oct 10 2019 at 15:44):
Thanks Rob! If there is a way to still include these changes where could i make a PR? @Grahame Grieve
Grahame Grieve (Oct 11 2019 at 01:45):
I wouldn't make a technical correction just for examples but I would fix examples as part of a technical correction. Make a gForge task and bring it to my attention in the committee approves the change. deadline: 1 week from today
Rob Hausam (Oct 17 2019 at 19:01):
Oops. We missed the chance to get this approved on the OO call today. Any chance that we could arrange to do it on a call tomorrow, or get approval from the co-chairs by email? @Grahame Grieve
Grahame Grieve (Oct 17 2019 at 21:27):
I'm happy with whatever process makes OO happy
Patrick Werner (Oct 25 2019 at 13:26):
i'm afraid that we are too late now. But i'm still willing to contribute. Is there a repo for R4B? I'll be happy to provide a PR for the deprecated examples.
Patrick Werner (Feb 18 2020 at 10:09):
There has be no progress on the tracker and it didn't made it into the technical correction. To remove these for R5, should i create PRs on the FHIR github directly and create a new Jira tracker item?
Eric Haas (Feb 18 2020 at 18:49):
I am ok with you making the updates.
Kevin Power (May 18 2020 at 13:07):
@Eric Haas @Rob Hausam -- I have put together a pull request for this, would you mind taking a look?
https://github.com/HL7/fhir/pull/877
http://build.fhir.org/branches/kpower_cg_outdated_artifacts/index.html
Eric Haas (May 18 2020 at 15:06):
looks good - and I merged it.
Last updated: Apr 12 2022 at 19:14 UTC