Stream: patient administration WG
Topic: R4 Changes being applied
Brian Postlethwaite (Oct 27 2018 at 06:32):
Hi All, I've taken all the trackers that currently have a group value of B. @Cooper Thompson , if you want to grab anything move to group 'C', maybe GF#14341
And Drew, maybe the 'A' group?
Brian Postlethwaite (Oct 28 2018 at 04:23):
@Simone Heckmann , can you apply GF#16476?
Simone Heckmann (Oct 28 2018 at 07:40):
Depends: what’s the deadline? I haven’t moved to git yet, so I’d need some extra time to get everything set up...
Brian Postlethwaite (Oct 28 2018 at 07:53):
Hmm, next couple of days, think theres a chance?
Simone Heckmann (Oct 28 2018 at 07:57):
I‘ll try to migrate to git tomorrow. I‘ll let you know if it worked and I’m back in the committer‘s game...
Brian Postlethwaite (Oct 28 2018 at 08:32):
Thanks heaps.
I've done all the items in group B, just not merged in yet.
Simone Heckmann (Oct 29 2018 at 10:28):
I'm on it...
Brian Postlethwaite (Oct 29 2018 at 10:32):
Thanks so much.
Simone Heckmann (Oct 29 2018 at 13:50):
Glad someone kicked me to finally get the GitHub stuff running. I've been procrastinating for weeks now :D
Cooper Thompson (Oct 29 2018 at 16:12):
I'm in the same boat as Simone - working on getting git setup today so I can help out in the next few days.
Brian Postlethwaite (Oct 29 2018 at 20:54):
Thanks, there is quite a bit of narrative stuff to get done.
I'm going to try get the verification result changes done this morning, and maybe the last of the appointment changes.
Brian Postlethwaite (Oct 29 2018 at 20:56):
If you're going to do the Patient changes (myself included) we probably should let others review the pull request before accepting it (and only include patient in single PR)
Brian Postlethwaite (Oct 29 2018 at 20:57):
(Only because it's going normative, and we dont want to slip something past accidentally)
Brian Postlethwaite (Oct 30 2018 at 14:56):
@Cooper Thompson , even if you don't get to commit a change, do you think you could draft up the notes section for GF#18824?
I'm just finishing the last of the substantive changes now...
Cooper Thompson (Oct 30 2018 at 14:59):
Yeah. I can do that. I've been having tons of problems with getting the build working with the IG/Jekyll stuff :/. I'll work on drafting that now.
Brian Postlethwaite (Oct 30 2018 at 14:59):
Thanks heaps.
Cooper Thompson (Oct 30 2018 at 15:40):
Do these look ok?
appointment-introduction.xml appointment-notes.xml
Cooper Thompson (Oct 30 2018 at 16:12):
I think I got my build sorted out. I can just do the PR for GF#18824
Brian Postlethwaite (Oct 30 2018 at 16:18):
Excellent, I've just completed the pull request for the others, so all yours for the narrative part of it
Brian Postlethwaite (Oct 30 2018 at 16:21):
Which also means that all substantive changes are complete for R4, just non-substantive ones stuff left.
@Cooper Thompson, if you could run through all the remaining things to double check that we haven't missed any substantive changes in that list.
(would be nice if we added an example of the waitlist too - but its bedtime for me now)
Brian Postlethwaite (Nov 08 2018 at 20:42):
@Cooper Thompson , did you do the changes for GF#15791?
Cooper Thompson (Nov 08 2018 at 20:43):
Yes, though I have a PR that I haven't merged yet.
Cooper Thompson (Nov 08 2018 at 20:44):
The diff for the spreadsheet is gross. I've been trying to sort out CRLF issues. But it still flags the whole doc as 100% different :(. I was going to just commit it anyway, since what I have is canonized. Unless you think otherwise?
Brian Postlethwaite (Nov 08 2018 at 20:45):
Its like that until you do a build as it needs to normalize the spreadsheet.
(which it can't do while Excel is open)
Brian Postlethwaite (Nov 08 2018 at 20:45):
(Or the last editor didn't do that - hoping it wasn't me)
Cooper Thompson (Nov 08 2018 at 20:50):
The issue isn't with the canonicalization, it is either with the CR/LF, or with tabs vs. spaces or something. Visually, in git diff the files look identical (except my changes).
Cooper Thompson (Nov 08 2018 at 20:55):
https://github.com/HL7/fhir/pull/255/files
Brian Postlethwaite (Nov 08 2018 at 21:02):
Interesting, maybe a git setting on your end, hmm.
Cooper Thompson (Nov 08 2018 at 21:46):
yeah, i tried the different git client CR/LF settings. anyway I'm working on it, but I'll probably finish sorting that out tomorrow.
Brian Postlethwaite (Nov 08 2018 at 21:50):
Cool
Last updated: Apr 12 2022 at 19:14 UTC
