Stream: IG creation
Topic: where is this html?
Eric Haas (Jul 31 2020 at 02:40):
where is this html, I can't find in the the hl7 template?
the external link icon https://imageog.flaticon.com/icons/png/512/25/25284.png?size=1200x630f&pad=10,10,10,10&ext=png&bg=FFFFFFFF is duplicated and I want to fix it.
Jose Costa Teixeira (Jul 31 2020 at 06:22):
https://github.com/HL7/ig-template-cda/pull/2
https://github.com/HL7/ig-template-fhir/pull/4
Jose Costa Teixeira (Jul 31 2020 at 06:23):
the footer page was adding the images, but the project.css is adding the images to every link that is outside the ig.
Jose Costa Teixeira (Jul 31 2020 at 06:25):
https://github.com/HL7/ig-template-base/blob/master/content/assets/css/project.css#L603
Jose Costa Teixeira (Jul 31 2020 at 06:25):
(I'm not sure this is the preferred solution)
Grahame Grieve (Jul 31 2020 at 06:26):
no don't do that in the css. The IG publisher does this for the links that are properly outside - and determining that is a little tricky
Jose Costa Teixeira (Jul 31 2020 at 06:35):
@Eric Haas i think you added the css, ok to remove it?
I would also prefer this to be done manually because I have other links that do not need this icon
Jose Costa Teixeira (Jul 31 2020 at 06:36):
i'll make another PR and you can choose which one to merge - the 2 above or this new one
Jose Costa Teixeira (Jul 31 2020 at 06:37):
https://github.com/HL7/ig-template-base/pull/118
Lloyd McKenzie (Jul 31 2020 at 13:21):
If the publisher was doing it and the CSS was doing it, then wouldn't there have been 3 icons?
Lloyd McKenzie (Jul 31 2020 at 13:21):
(I accepted the PR to remove the hard-coded double external links)
Jose Costa Teixeira (Jul 31 2020 at 13:24):
the above discussion was for the footer, where we have 2 icons.
Jose Costa Teixeira (Jul 31 2020 at 13:25):
the footer had one icon, but then the CSS added one.
Jose Costa Teixeira (Jul 31 2020 at 13:25):
What I think Grahame meant is that if the CSS adds one icon, that may have an impact in other places where the publisher also adds an icon
Jose Costa Teixeira (Jul 31 2020 at 13:27):
I didn't check the impact of the CSS and if that adds icons where they are not needed
Lloyd McKenzie (Jul 31 2020 at 13:41):
I'm not seeing doubles appearing places other than where we had them hard-coded in the footer. So either Grahame's process isn't colliding with the CSS, Grahame isn't inserting the icons right now, or the CSS isn't working. If the last is true, yanking the CSS stuff isn't a problem. Otherwise, I don't want to pull it. Curious what @Grahame Grieve means by 'external' being hard to determine?
Jose Costa Teixeira (Jul 31 2020 at 14:00):
The place where I have the unwanted icon was in my feedback thing, which is why i would prefer to control that manually.
Lloyd McKenzie (Jul 31 2020 at 14:25):
I definitely don't want authors to have to specify the icons. Doing it with CSS would let you turn it off - you could declare a class that would suppress.
Jose Costa Teixeira (Jul 31 2020 at 14:31):
yes, I can deactivate that on my css. If my "issue" is the only one, i' not worried at all
Lloyd McKenzie (Jul 31 2020 at 14:49):
I don't know that it'll be the 'only' one. Though frankly, not sure why you wouldn't want to indicate that it's an external link
Jose Costa Teixeira (Jul 31 2020 at 14:51):
I want my own link.
Lloyd McKenzie (Jul 31 2020 at 14:56):
I don't understand - having the icon doesn't change the link, it just flags the link as being external?
Eric Haas (Jul 31 2020 at 15:03):
the css I added allows you to turn it off and I don't want to have to manually turn it on.
Eric Haas (Jul 31 2020 at 15:07):
the current css assumes absolute references are external.
Eric Haas (Jul 31 2020 at 15:09):
turns off with style no-external= "true" and no-download="true"
Eric Haas (Jul 31 2020 at 15:13):
@Jose Costa Teixeira no it is not ok to remove it.
Eric Haas (Jul 31 2020 at 15:14):
until you can explain why more clearly
Jose Costa Teixeira (Jul 31 2020 at 15:18):
@Eric Haas this doesn't need a long discussion - you asked about the issue, I think it was caused by the css, and I proposed 2 solutions to remove it: undo the CSS or remove the html that I think was there before.
Lloyd McKenzie (Jul 31 2020 at 15:20):
The HTML hard-coding is now removed. So I think there's no further action required?
Jose Costa Teixeira (Jul 31 2020 at 15:24):
indeed - let's see if Grahame has a concern.
Jose Costa Teixeira (Jul 31 2020 at 15:27):
(deleted)
Eric Haas (Jul 31 2020 at 15:39):
OK just too follow up here is a screenshot of how to turn off
Eric Haas (Jul 31 2020 at 15:40):
I know am behind in documentation -where are we documenting in the sample ig ?
Jose Costa Teixeira (Jul 31 2020 at 15:41):
well, I am using post-it notes :)
Jose Costa Teixeira (Jul 31 2020 at 15:41):
(i think the idea is to add to the guidance ig)
Jose Costa Teixeira (Aug 01 2020 at 07:17):
@Eric Haas do you know how do I switch this off in my css? I tried to do this for my feedback class
.feedback:after {
content: url(another_icon.png);
}
Jose Costa Teixeira (Aug 01 2020 at 07:17):
does not work
Jose Costa Teixeira (Aug 01 2020 at 08:31):
this worked though:
.feedback:after {
content: url(another_icon.png)!important;
}
Jose Costa Teixeira (Aug 01 2020 at 08:31):
I got it
Jose Costa Teixeira (Aug 01 2020 at 09:13):
btw, I used data uris for my icon. more compact and presumably faster
Eric Haas (Aug 01 2020 at 20:21):
ok good, I assume you wanted to turn of the external png? should work with the no-external="true" on the element using span
Jose Costa Teixeira (Aug 01 2020 at 20:26):
this is in a script that generates content, so I would either have to add that to the script, or I just change on the css which is more logical.
Jose Costa Teixeira (Aug 01 2020 at 20:26):
Do you see any inconvenient in using the solution I have above?
Eric Haas (Aug 01 2020 at 20:27):
i assume the !important overrides the other icon.
Jose Costa Teixeira (Aug 01 2020 at 20:27):
Yes
Jose Costa Teixeira (Aug 01 2020 at 20:28):
I have this :
.feedback {
color: #ffffff;
.....
}
.feedback:after {
content: url('data:image/svg+xml;base64,AB........Z')!important;
}
Jose Costa Teixeira (Aug 01 2020 at 20:29):
it works, so all fine
Last updated: Apr 12 2022 at 19:14 UTC
