Stream: IG creation
Topic: type being generated twice twice
Eric Haas (Feb 27 2018 at 05:19):
The Spreadsheet parser is generating two two types. e.g.,
<element id="Observation.category">
<path value="Observation.category"/>
<min value="1"/>
<max value="1"/>
<type>
<code value="CodeableConcept"/>
</type>
<type>
<code value="CodeableConcept"/>
</type>
<mustSupport value="false"/>
<isModifier value="false"/>
</element>
<element id="Observation.category.coding">
<path value="Observation.category.coding"/>
<min value="1"/>
<max value="1"/>
<type>
<code value="Coding"/>
</type>
<type>
<code value="Coding"/>
</type>
<mustSupport value="false"/>
<isModifier value="false"/>
</element>
Eric Haas (Feb 27 2018 at 05:20):
Good news is the validator is complaining about this.
Grahame Grieve (Mar 19 2018 at 18:13):
sorry I missed this. I think I'll need to fix it
Grahame Grieve (Mar 19 2018 at 18:23):
does this happen for the current us-core?
Grahame Grieve (Mar 19 2018 at 18:23):
as in, what is committed now?
Eric Haas (Mar 19 2018 at 21:06):
nope
Grahame Grieve (Mar 19 2018 at 22:55):
Is there any easy way for me to reproduce?
Eric Haas (Mar 20 2018 at 01:18):
I can't get SD to even generate to show you with the latest ig-pub here is the error:
Initialization complete (21.0355sec)
Load Content (21.0355sec)
load /Users/ehaas/Documents/FHIR/IG-Template2/source/resources/template-profile-spreadsheet.xml (21.0691sec)
Exception in thread "main" java.lang.Error: Not the right type for ElementDefinition.binding.valueSet[x]: Reference
at org.hl7.fhir.r4.model.ElementDefinition$ElementDefinitionBindingComponent.setValueSet(ElementDefinition.java:3466)
at org.hl7.fhir.igtools.spreadsheets.IgSpreadsheetParser.readBindings(IgSpreadsheetParser.java:497)
at org.hl7.fhir.igtools.spreadsheets.IgSpreadsheetParser.loadBindings(IgSpreadsheetParser.java:431)
at org.hl7.fhir.igtools.spreadsheets.IgSpreadsheetParser.parse(IgSpreadsheetParser.java:165)
at org.hl7.fhir.igtools.publisher.Publisher.loadSpreadsheet(Publisher.java:1604)
at org.hl7.fhir.igtools.publisher.Publisher.loadSpreadsheets(Publisher.java:1589)
at org.hl7.fhir.igtools.publisher.Publisher.load(Publisher.java:1362)
at org.hl7.fhir.igtools.publisher.Publisher.createIg(Publisher.java:380)
at org.hl7.fhir.igtools.publisher.Publisher.execute(Publisher.java:354)
at org.hl7.fhir.igtools.publisher.Publisher.main(Publisher.java:4152)
Eric Haas (Mar 20 2018 at 01:20):
The above error is when I try to use a spreadsheet, I am able to run US-Core as xml files. But not able to use the definitions file that it generates. here is the error when I try to use the latest definitions file from US-Core...
Eric Haas (Mar 20 2018 at 01:24):
Local Validation Pack from cache location /Users/ehaas/Documents/FHIR/IG-Template2/generated_output/txCache/validation-3.0.1.zip using version 3.0.1 (00.0443sec)
Definitions 3.0.1-11917 (18.0748sec)
Load Terminology Cache from /Users/ehaas/Documents/FHIR/IG-Template2/generated_output/txCache (18.0754sec)
Connect to Terminology Server at http://tx.fhir.org/r4 (18.0757sec)
Load uscore (http://build.fhir.org/ig/HL7/US-Core/) from dependencies/uscore (20.0699sec)
Exception in thread "main" java.lang.Error: Not the right type for ElementDefinition.binding.valueSet[x]: Reference
at org.hl7.fhir.r4.model.ElementDefinition$ElementDefinitionBindingComponent.setValueSet(ElementDefinition.java:3466)
at org.hl7.fhir.r4.formats.JsonParser.parseElementDefinitionElementDefinitionBindingComponentProperties(JsonParser.java:1739)
at org.hl7.fhir.r4.formats.JsonParser.parseElementDefinitionElementDefinitionBindingComponent(JsonParser.java:1723)
at org.hl7.fhir.r4.formats.JsonParser.parseElementDefinitionProperties(JsonParser.java:1526)
at org.hl7.fhir.r4.formats.JsonParser.parseElementDefinition(JsonParser.java:1363)
at org.hl7.fhir.r4.formats.JsonParser.parseStructureDefinitionStructureDefinitionSnapshotComponentProperties(JsonParser.java:20735)
at org.hl7.fhir.r4.formats.JsonParser.parseStructureDefinitionStructureDefinitionSnapshotComponent(JsonParser.java:20726)
at org.hl7.fhir.r4.formats.JsonParser.parseStructureDefinitionProperties(JsonParser.java:20675)
at org.hl7.fhir.r4.formats.JsonParser.parseStructureDefinition(JsonParser.java:20543)
at org.hl7.fhir.r4.formats.JsonParser.parseResource(JsonParser.java:24564)
at org.hl7.fhir.r4.formats.JsonParserBase.parse(JsonParserBase.java:90)
at org.hl7.fhir.igtools.publisher.Publisher.loadIg(Publisher.java:1151)
at org.hl7.fhir.igtools.publisher.Publisher.initialize(Publisher.java:869)
at org.hl7.fhir.igtools.publisher.Publisher.execute(Publisher.java:352)
at org.hl7.fhir.igtools.publisher.Publisher.main(Publisher.java:4152)
Grahame Grieve (Mar 20 2018 at 01:32):
hmm. let me look into that
Eric Haas (Mar 20 2018 at 01:34):
The prior ig-pub generated a definitions.file that I was able to use.
Grahame Grieve (Mar 20 2018 at 01:34):
hm.. how are you running that?
Eric Haas (Mar 20 2018 at 01:35):
and I'm not married to spreadsheets anymore so isn't a big deal if they are dead.
Grahame Grieve (Mar 20 2018 at 01:36):
I think Lloyd still is
Eric Haas (Mar 20 2018 at 01:36):
converted the spreadsheets to xml and ran it.
Eric Haas (Mar 20 2018 at 01:36):
for the last version of ig-pub
Grahame Grieve (Mar 20 2018 at 01:44):
so I just updated from github and built - and it builds ok
Eric Haas (Mar 20 2018 at 01:49):
What builds OK? US-Core?
Grahame Grieve (Mar 20 2018 at 01:49):
yes.
Eric Haas (Mar 20 2018 at 01:51):
can you send me a defnitions file?
Grahame Grieve (Mar 20 2018 at 01:52):
Fetch Validation Pack from http://hl7.org/fhir/STU3/igpack.zip (00.0382sec)
Grahame Grieve (Mar 20 2018 at 01:52):
that's where it's loading from
Eric Haas (Mar 20 2018 at 01:52):
the US Core defintions file from your ig-build
Grahame Grieve (Mar 20 2018 at 01:54):
umm?
Eric Haas (Mar 20 2018 at 01:55):
And the SD files in the build had a single type for each element?
Grahame Grieve (Mar 20 2018 at 01:55):
don't know. I just built of what's current.
Grahame Grieve (Mar 20 2018 at 01:56):
where would look to be sure it's not generating duplicate types?
Eric Haas (Mar 20 2018 at 01:57):
The Git repo is spreadsheets and when I ran the ig-pub the generated SD had two types for each element. Should show up in qa.html if it does.
Eric Haas (Mar 20 2018 at 02:00):
I am signing off for now will look more into it tomorrow.
Grahame Grieve (Mar 20 2018 at 03:00):
ok I think i fixed that...
Grahame Grieve (Mar 20 2018 at 03:30):
no. grrr
Grahame Grieve (Mar 20 2018 at 12:32):
now really fixed!
Last updated: Apr 12 2022 at 19:14 UTC