FHIR Chat · provenance history not working · IG creation

Stream: IG creation

Topic: provenance history not working


view this post on Zulip John Moehrke (Jul 23 2020 at 21:11):

My IG that did have provenance history working, no longer shows history or throws an error... Did something change in the build tools on how provenance history bundle is to be identified?

view this post on Zulip Grahame Grieve (Jul 23 2020 at 21:14):

maybe this: https://github.com/HL7/fhir-ig-publisher/issues/134

view this post on Zulip Grahame Grieve (Jul 23 2020 at 21:14):

but no, that's not released yet

view this post on Zulip John Moehrke (Jul 23 2020 at 21:43):

how do I reference my provenance build in the IG.xml? I have explicitly added my codeSystem and valueSet to satisfy those errors, but don't know how to reference a build

view this post on Zulip John Moehrke (Jul 23 2020 at 21:44):

being an early adoptor is so painful

view this post on Zulip John Moehrke (Jul 23 2020 at 21:44):

I don't think the publisher is pulling in my provenance bundle, as it is not referenced in the IG.xml

view this post on Zulip Lloyd McKenzie (Jul 23 2020 at 22:05):

@Jose Costa Teixeira

view this post on Zulip John Moehrke (Jul 23 2020 at 22:12):

@Lloyd McKenzie I don't think it is template based.

view this post on Zulip John Moehrke (Jul 23 2020 at 22:13):

it fails just the same with fhir base template

view this post on Zulip Jose Costa Teixeira (Jul 23 2020 at 22:13):

The base template is where it all happens

view this post on Zulip Jose Costa Teixeira (Jul 23 2020 at 22:13):

I will check this tomorrow

view this post on Zulip John Moehrke (Jul 23 2020 at 22:18):

it is doing the same thing with base

view this post on Zulip Jose Costa Teixeira (Jul 23 2020 at 22:19):

Every template behaves as the base on this

view this post on Zulip John Moehrke (Jul 23 2020 at 22:21):

it was NOT THE TEMPLATE!!!!!!

view this post on Zulip John Moehrke (Jul 23 2020 at 22:22):

I added autoload-resources to my IG to get this to work. There needs to be a better way to bring in provenance history than autoload

view this post on Zulip Jose Costa Teixeira (Jul 23 2020 at 22:25):

Are you sure this is not in the base template?

view this post on Zulip John Moehrke (Jul 23 2020 at 22:26):

what is your question? I have explained that it is now working when I force autoload of all resources found

view this post on Zulip John Moehrke (Jul 23 2020 at 22:26):

problem solved

view this post on Zulip John Moehrke (Jul 23 2020 at 22:27):

just would rather not use autoload to get provenance history bundle to load

view this post on Zulip Jose Costa Teixeira (Jul 23 2020 at 22:27):

I don't understand the issue then but if there is no issue then I will not need to check tomorrow :)

view this post on Zulip John Moehrke (Jul 23 2020 at 22:28):

I was not using autoload, I was explicitly naming resources in the IG xml... there is no way to load a BUNDLE.. so the build tool never saw the provenance entries

view this post on Zulip John Moehrke (Jul 23 2020 at 22:29):

  <parameter>
        <code value="autoload-resources" />
        <value value="true" />
    </parameter>

view this post on Zulip Jose Costa Teixeira (Jul 23 2020 at 22:32):

Please write if there is an issue or not and I will read tomorrow. History has been working with bundles.

view this post on Zulip John Moehrke (Jul 23 2020 at 22:32):

@Jose Costa Teixeira there is no problem!!!!!

view this post on Zulip Lloyd McKenzie (Jul 24 2020 at 00:11):

You need to either auto-load or reference the resource in your IG. If you don't do one of those two things, the publisher won't know to look for the resource.

view this post on Zulip John Moehrke (Jul 24 2020 at 16:02):

right. I just wanted to reference the bundle, as the bundle contians an increasing number of provenance

view this post on Zulip John Moehrke (Jul 24 2020 at 17:04):

still not fully working..... and it is not a specific problem to the IHE template, it happens with base as well... The history is showing up at the bottom of the resource page (good news), but at the header of that resource page a "History" menu has appeared beside the tabs for "Narrative Content", "XML", "JSON", and "TTL"... but that History link is trying to go to a html page that doesn't exist. I did not add this History link. I did not create a history.html. Seems the template and the build tools are thinking different things.

Error: "The link 'CodeSystem-formatcode.change.history.html' for "History" cannot be resolved"

view this post on Zulip John Moehrke (Jul 24 2020 at 17:35):

see http://build.fhir.org/ig/IHE/FormatCode/branches/master/CodeSystem-formatcode.html

view this post on Zulip Grahame Grieve (Jul 24 2020 at 20:34):

there is no way to load a BUNDLE

This is not true. There are lots of IGs that contain bundes

view this post on Zulip John Moehrke (Jul 24 2020 at 21:20):

I got the bundle loading... see latest problem

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 10:54):

The base template had an issue with history layouts.
PR Submitted for Grahame or Lloyd to merge

view this post on Zulip Lloyd McKenzie (Jul 28 2020 at 13:52):

Merged

view this post on Zulip John Moehrke (Jul 28 2020 at 16:25):

Yeah. It worked

view this post on Zulip John Moehrke (Jul 28 2020 at 16:54):

but I still am getting errors from the template

ImplementationGuide-ihe.formatcode.fhir.change.history.html#/html/body/div/div/div/div/div/ul/li/a at Line 129, column 6 error The link 'ImplementationGuide-ihe.formatcode.fhir.html' for "Narrative Content" cannot be resolved
ImplementationGuide-ihe.formatcode.fhir.change.history.html#/html/body/div/div/div/div/div/ul/li/a at Line 135, column 8 error The link 'ImplementationGuide-ihe.formatcode.fhir.xml.html' for "XML" cannot be resolved
ImplementationGuide-ihe.formatcode.fhir.change.history.html#/html/body/div/div/div/div/div/ul/li/a at Line 142, column 8 error The link 'ImplementationGuide-ihe.formatcode.fhir.json.html' for "JSON" cannot be resolved
ImplementationGuide-ihe.formatcode.fhir.change.history.html#/html/body/div/div/div/div/div/ul/li/a at Line 149, column 8 error The link 'ImplementationGuide-ihe.formatcode.fhir.ttl.html' for "TTL" cannot be resolved

view this post on Zulip David deRoode (Jul 28 2020 at 16:55):

Dental Referral build is getting these build errors as well

view this post on Zulip AbdulMalik Shakir (Jul 28 2020 at 17:12):

I am also getting a new set of errors in the build of the VRDR IG that were not there yesterday. Has there been a change?

StructureDefinition-VRDR-Autopsy-Performed-Indicator.change.history.html#/html/body/div/div/div/div/div/ul/li/a at Line 131, column 8 error The link 'StructureDefinition-VRDR-Autopsy-Performed-Indicator.xml.html' for "XML" cannot be resolved
StructureDefinition-VRDR-Autopsy-Performed-Indicator.change.history.html#/html/body/div/div/div/div/div/ul/li/a at Line 138, column 8 error The link 'StructureDefinition-VRDR-Autopsy-Performed-Indicator.json.html' for "JSON" cannot be resolved
StructureDefinition-VRDR-Autopsy-Performed-Indicator.change.history.html#/html/body/div/div/div/div/div/ul/li/a at Line 145, column 8 error The link 'StructureDefinition-VRDR-Autopsy-Performed-Indicator.ttl.html' for "TTL" cannot be resolved

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 18:32):

deja vu, but I don't remember what this was

view this post on Zulip Eric Haas (Jul 28 2020 at 18:32):

@John Moehrke The ig resource isn't exposed in the base template last time I checked. So no fragments are available.

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 18:32):

@Eric Haas it is in the "Any" section

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 18:33):

ah no you are correct.

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 18:34):

but that page should actually not be generated

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 18:34):

@Lloyd McKenzie @Eric Haas do we need this?

    "ImplementationGuide": {
      "template-base": "",
      "template-format": ""
    },

view this post on Zulip Eric Haas (Jul 28 2020 at 18:36):

@AMS if your other structuredefinitions are fine then this is not a template issue. is for all your artifacts?

view this post on Zulip Eric Haas (Jul 28 2020 at 18:37):

@Jose Costa Teixeira I never expose the IG resource , so I am fine with it - I am not sure why was set up like that.

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 18:49):

what do you mean to expose the IG resource?

view this post on Zulip AbdulMalik Shakir (Jul 28 2020 at 18:55):

@Eric Haas This is for all resources in the IG. I just included a few lines of the 129 errors generated.

view this post on Zulip John Moehrke (Jul 28 2020 at 18:58):

I don't see how exposing or not the IG resource matters. This seems to be automated because I have history on one of my resources, the errors are as I have pasted them only associated with that one resource that has history

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 19:05):

what does "exposing the IG resource" mean?

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 19:08):

@David deRoode do you have a repo where I can reproduce this issue?

view this post on Zulip David deRoode (Jul 28 2020 at 19:09):

https://github.com/HL7/dental-data-exchange/tree/master

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 19:15):

I'm getting this error while building the dental IG

US Core Comparison failed: C:\ImplementationGuides\dental-data-exchange-master\temp\pages\us-core-comparisons\comparison\vs-body-site-dental-anatomy-union.json (The system cannot find the path specified)
java.io.FileNotFoundException: C:\ImplementationGuides\dental-data-exchange-master\temp\pages\us-core-comparisons\comparison\vs-body-site-dental-anatomy-union.json (The system cannot find the path specified)
        at java.io.FileOutputStream.open0(Native Method)

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 19:18):

in any case, for now iI don't see why those files that have invalid links are even being generated.

view this post on Zulip David deRoode (Jul 28 2020 at 19:23):

Thanks for checking @Jose Costa Teixeira Recognize any commonality from the last time this happened, earlier this month? https://chat.fhir.org/#narrow/stream/179252-IG-creation/topic/IG.20History.20page.20links.20cannot.20be.20resolved

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 19:31):

Yes, but that fix was different - that issue was on all igs for some resource types. in this case it's only your IG and somehow yours and John's implementationguide resource

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 19:32):

also, that was before dinner...

view this post on Zulip Lloyd McKenzie (Jul 28 2020 at 19:41):

Are the IGs in the same folders as the resources? That might be the problem. (I think Forge tends to store everything in the same folder)

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 19:42):

no

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 19:42):

David actually has a folder structure for the resources (which I flattened and still same issue)

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 19:44):

I do not know why but all of David's structureDefs have the issue

view this post on Zulip John Moehrke (Jul 28 2020 at 20:16):

my IG build is quite basic. just a codeSystem and a valueSet. It happens only on the codeSystem as that is the only one I have a history for, my valueSet has no history.

view this post on Zulip John Moehrke (Jul 28 2020 at 20:17):

https://github.com/IHE/FormatCode

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 20:38):

@John Moehrke what is happening on the codesystem? the issue is on the implementationguide history pages that should not exist

view this post on Zulip John Moehrke (Jul 28 2020 at 20:44):

ah, so the errors are not specific to codeSystem... okay.. so what do I need to do?

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 20:46):

no idea. I'm debugging this

view this post on Zulip John Moehrke (Jul 28 2020 at 20:48):

my IG source has no other history but the provenance on my codeSystem... so is there a history file I should have?

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 20:55):

no. at this moment it either in the tooling or there is something hidden in one of the resources that I cannot yet point to

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 21:14):

a PR is on the way. Hopefully that will fix it

view this post on Zulip Jose Costa Teixeira (Jul 28 2020 at 21:52):

@AbdulMalik Shakir after the PR is merged the issues should go away

view this post on Zulip AbdulMalik Shakir (Jul 29 2020 at 00:59):

@Jose Costa Teixeira And so it is. Thanks.

view this post on Zulip John Moehrke (Jul 29 2020 at 13:47):

@Jose Costa Teixeira thanks for the fix. I confirm the errors have gone away.


Last updated: Apr 12 2022 at 19:14 UTC