Stream: IG creation
Topic: plantuml upgrade?
David Pyke (Jan 13 2022 at 17:55):
Is there a way to get a later version of plantuml added to the publisher and/or a way to have it use the version installed locally on my machine?
David Pyke (Jan 13 2022 at 17:56):
There are a number of fixes in the later versions that aren't available to the publisher
Vassil Peytchev (Jan 13 2022 at 17:56):
Is there a newer version with the appropriate license?
David Pyke (Jan 13 2022 at 17:58):
What would be the appropriate license?
David Pyke (Jan 13 2022 at 17:59):
It's GPL'd so I'm not sure where the problem would be
Vassil Peytchev (Jan 13 2022 at 18:00):
From what I can tell, non-GPL. The note on the commit to downgrade it to the currently included version claims it was because it was the latest released under APL...
David Pyke (Jan 13 2022 at 18:02):
You can pick your license when you download it GPL, APL, Eclipse, LGPL,MIT. There's something for everyone
Vassil Peytchev (Jan 13 2022 at 18:03):
But yeah, it seems to be used in Github, so I don't understand the reasoning either. Maybe it just had never come up since that downgrade...
David Pyke (Jan 13 2022 at 18:04):
@Grahame Grieve ?
Vassil Peytchev (Jan 13 2022 at 18:05):
I would just do a PR with the APL version, and see what comes out of it.
David Pyke (Jan 13 2022 at 18:05):
Sounds like a plan
Jose Costa Teixeira (Jan 13 2022 at 18:09):
We had either the APL or the MIT. One of them had a bug but I don't remember which
Jose Costa Teixeira (Jan 13 2022 at 18:11):
David Pyke said:
It's GPL'd so I'm not sure where the problem would be
GPL is copyleft. We use a permissive license everywhere
Jose Costa Teixeira (Jan 13 2022 at 18:13):
it's the Apache license
David Pyke (Jan 13 2022 at 18:13):
IT's multiply licensed, including ASL
David Pyke (Jan 13 2022 at 18:14):
John Moehrke (Jan 13 2022 at 18:14):
I didn't think the publisher actually uses plantuml, I thought it used a package that supports a subset of the plantuml encoding standard.
David Pyke (Jan 13 2022 at 18:15):
According to the source, it uses a 2019 version of plantuml
Jose Costa Teixeira (Jan 13 2022 at 18:15):
I can fix it unless Vassyl is already doing it
David Pyke (Jan 13 2022 at 18:15):
Go for it, Jose!
Jose Costa Teixeira (Jan 13 2022 at 18:16):
Jose Costa Teixeira said:
David Pyke said:
It's GPL'd so I'm not sure where the problem would be
GPL is copyleft. We use a permissive license everywhere
@David Pyke this is just to explain the reason. GPL is not good. ASL is good
David Pyke (Jan 13 2022 at 18:16):
Totally understand
Jose Costa Teixeira (Jan 13 2022 at 18:17):
The publisher doesn't use plantuml, we never got the plantuml mit license to appear on sonar or whatever that was
Jose Costa Teixeira (Jan 13 2022 at 18:17):
the template uses the jar for that reason
Jose Costa Teixeira (Jan 13 2022 at 18:21):
@Lloyd McKenzie PR created
https://github.com/HL7/ig-template-base/pull/189
Jose Costa Teixeira (Jan 13 2022 at 18:21):
I'd like to test for regression before merging
Lloyd McKenzie (Jan 13 2022 at 18:32):
Ok. Poke me when you've tested.
Vassil Peytchev (Jan 13 2022 at 18:35):
FWIW, there is a pom file for PlantUML in the publisher, but maybe it is just a leftover.
Jose Costa Teixeira (Jan 13 2022 at 18:36):
My tests will be the ig-guidance (there are few different uses of plantuml there) and the davinci ehrx decision tree
Frank Oemig (Jan 15 2022 at 09:45):
I have added environment variables to the script, but perhaps this is outdated..
Jose Costa Teixeira (Jan 15 2022 at 13:13):
what scripts?
Frank Oemig (Jan 15 2022 at 14:14):
_Genonce.bat
Jose Costa Teixeira (Jan 16 2022 at 21:24):
I've tested with several types of diagrams:
- davincy hrex (exchange diagram)
- guidance ig (the demo diagrams which includes some templating and different types of diagrams)
- an ER-like diagram i had here.
From my side it's ok to merge
Lloyd McKenzie (Jan 16 2022 at 22:56):
Merged
Jose Costa Teixeira (Jan 16 2022 at 22:58):
(while I use the emoji for "Thank you", in this case it's actually "praying") :)
Last updated: Apr 12 2022 at 19:14 UTC
