Stream: IG creation
Topic: minValueQuantity and maxValueQuantity
John Moehrke (Sep 08 2021 at 17:36):
I have added some minValueQuantity and maxValueQuantity to my profiles, but
a) They are not showing up in the profile narrative
b) The IG build is not throwing validation errors on some examples I crafted that were outside these min/max.
I mostly want to know if this is expected. I didn't think I was on the bleeding edge.
John Moehrke (Sep 08 2021 at 18:27):
I will note that minValueInteger / maxValueInteger does seem to be enforced by the validator, but does not seem to appear in the IG created narrative for the profile using it.
Lloyd McKenzie (Sep 08 2021 at 19:11):
min and max Quantity are definitely bleeding edge. (It wouldn't as exciting if you always knew where that edge was...) Quantity checks can involve unit conversion, so they're much more involved. Submit tracker items against the publisher (for narrative) and validator (for validation). Ideally with a test case :)
John Moehrke (Sep 09 2021 at 12:30):
Okay, I will make sure I put my limits in the narrative in addition to the profile.
John Moehrke (Sep 09 2021 at 12:59):
where is the validator tracker?
Lloyd McKenzie (Sep 09 2021 at 15:07):
https://github.com/hapifhir/org.hl7.fhir.core
Grahame Grieve (Sep 14 2021 at 20:40):
@John Moehrke is this still a problem?
John Moehrke (Sep 14 2021 at 20:51):
what part of this has been fixed? As far as I can tell the validator ignores min/max limits on Quantity
Grahame Grieve (Sep 14 2021 at 20:52):
it does ignore them, that's true. Let's make up some test cases then..
John Moehrke (Sep 14 2021 at 20:53):
okay, that is all I was looking to add to the validator. (the validator did complain about Integer ranges)
Grahame Grieve (Sep 14 2021 at 20:55):
well, would you like to help with test cases?
John Moehrke (Sep 14 2021 at 20:56):
the easiest case I have is for body weight observations. For adult, I have been told to not allow less than 60 lbs or more than 1000 lbs. (oh, and yes the value can be entered in Kg)
John Moehrke (Sep 14 2021 at 20:56):
how do you want me to write up the test cases?
John Moehrke (Sep 14 2021 at 20:58):
My usecase is Patient Generated Health Data.. with the limits intended to catch someone accidently typing in measurements wrong -- aka fat-fingers.
John Moehrke (Sep 14 2021 at 21:00):
I have limits for Blood Pressure, Blood Sugar, Body Temp, Heart Rate, Respiration Rate, Weight, and PulseOx. (pain level of 0-10, is my integer case that does throw validation errors)
Grahame Grieve (Sep 14 2021 at 21:01):
I want a profile that expresses the limits, and then a set of instances that are valid | invalid | impossible to know (in both specified and alternative units)
John Moehrke (Sep 14 2021 at 21:19):
okay, I have them (in sushi). where do you want them? and how should I mark them valid | invalid | impossible to know?
Grahame Grieve (Sep 14 2021 at 21:20):
generate them to resources and send them to me and describe them. I'll add them to this: https://github.com/FHIR/fhir-test-cases/blob/master/validator/manifest.json
John Moehrke (Sep 14 2021 at 21:23):
tag valid vs not? Today I use the profile vs not profiled.
John Moehrke (Sep 14 2021 at 21:24):
impossible to know -- as in a weight in "stone"? :-)
John Moehrke (Sep 14 2021 at 21:27):
John Moehrke said:
tag valid vs not? Today I use the profile vs not profiled.
ah, looking at your manifest.. i guess I just need to flag those that will fail, and you will capture the error you throw. Okay.
Grahame Grieve (Sep 14 2021 at 22:55):
impossible to kwow - wieght not in ucum units
Last updated: Apr 12 2022 at 19:14 UTC
