Stream: IG creation
Topic: known bad examples in Alerts guide
Eric Haas (Dec 05 2019 at 17:48):
OK so I tried to create bundle fragments for profiles example instances as discussed here: https://chat.fhir.org/#narrow/stream/179252-IG-creation/topic/link.20errors.20for.20uuids.20in.20a.20bundle
and frankly is more confusing than having the invalid isolated resource instances. so I include a highlighted note
wherever these invalid profile examples are shown.:
The following examples of this profile are freestanding resource instances. Note that these are technically invalid since the profile is defined to references other resources within the same Da Vinci Notification Message Bundle. A complete list of examples including bundle examples can be found on the [Examples] page.
in the Da Vinci Notifications IG : http://build.fhir.org/ig/HL7/davinci-alerts/branches/master/index.html
example where this note appears is here: http://build.fhir.org/ig/HL7/davinci-alerts/branches/master/StructureDefinition-notifications-messageheader.html
example QA errors that are generated for these examples are:
I would like to get the OK from the Product Director to accept that these qa errors are OK for these instance so we can move on to ballot with the IG.
@Grahame Grieve
@Riki Merrick
@Lynn Laakso
Eric Haas (Dec 05 2019 at 17:54):
and all these link errors as well:
Grahame Grieve (Dec 09 2019 at 12:21):
ok
Eric Haas (Aug 21 2020 at 21:38):
I'm getting ready to publish Alerts and these errors still persist for the same reason as stated above. I would like get a variance on them unless there is another way. Also should these errors be put in the ignore file?
@Grahame Grieve or @Lloyd McKenzie ?
Grahame Grieve (Aug 21 2020 at 22:13):
I'm not sure what you're asking here - there's several different errors
Eric Haas (Aug 24 2020 at 16:31):
I want a realistic example for a profile that aggregrates within a bundle but have a stand alone view of the profile example as a convienence for the reader
The errors I displayed are since the references don't resolve since the example is not in a bundle. and none of the references will resolve. I think The validation errors are all due to that. Are some of them dues to other issues?
Grahame Grieve (Aug 26 2020 at 02:04):
so looking at this... I have fixed the Publisher to be able to resolve urn:uuid: links in bundles - a bug that I overlooked.
Grahame Grieve (Aug 26 2020 at 02:05):
but I think that you should have UUIDs that resolve in your particular case at least
Eric Haas (Aug 26 2020 at 02:13):
if an instance is only found in a bundle then its linke are only in the context of the bundle. how would the validator know to look inside a bundle to resolve them if the example is free standing.
Eric Haas (Aug 26 2020 at 02:14):
My desire is to give the reader an view of the isolated resource without having to sift through the bundle to find an example.
Grahame Grieve (Aug 26 2020 at 02:16):
right that part is fine. But in fact, the IG publisher already looks through the bundles so that examples in bundles can be referred to outside the bundle; exactly this situation. I overlooked a piece of logic to allow uuid matching by full URL
Grahame Grieve (Aug 26 2020 at 02:16):
the idea is that you can do what you want but still have a link that does resolve
Eric Haas (Aug 26 2020 at 17:00):
ok good to know that I will update.
Eric Haas (Aug 26 2020 at 20:32):
OK fixed examples so the current errors in them are:
Reference is remote which isn't supported by the specified aggregation mode(s) for the reference
and
Profile http://hl7.org/fhir/us/davinci-alerts/StructureDefinition/discharge-notification-messageheader, Element 'MessageHeader.focus[discharge-notification]': minimum required = 1, but only found 0
which I assume is since can't resolve the reference
see http://build.fhir.org/ig/HL7/davinci-alerts/qa.html
Grahame Grieve (Aug 27 2020 at 04:37):
ok if you add an extension to the entry that includes the example, you can turn off aggregation validation:
Grahame Grieve (Aug 27 2020 at 04:37):
"extension" : [{
"url" : "http://hl7.org/fhir/StructureDefinition/igpublisher-no-check-aggregation",
"valueBoolean" : "true"
]}
Grahame Grieve (Aug 27 2020 at 04:37):
I added an example
Eric Haas (Aug 27 2020 at 13:46):
to be precise added to ImplementationGuide.definition.resource element
Eric Haas (Aug 27 2020 at 14:37):
ok done.
Eric Haas (Aug 27 2020 at 16:02):
OK thanks that gets rid of the aggregation error ....still have this error assuming since not resolving the reference
Profile http://hl7.org/fhir/us/davinci-alerts/StructureDefinition/admit-notification-messageheader, Element 'MessageHeader.focus[admit-notification]': minimum required = 1, but only found 0
Grahame Grieve (Aug 27 2020 at 22:08):
it is resolving the reference. but the reference isn't validating as required. See the 'show reasoning' entry above it which explains why it doesn't match. The problem is in the validation of the bundle
Eric Haas (Sep 02 2020 at 14:52):
- Element not found error in isolated example - suspect not resolving to profile.
message
Profile http://hl7.org/fhir/us/davinci-
alerts/StructureDefinition/admit-notification-messageheader, Element
'MessageHeader.focus[admit-notification]': minimum required = 1, but
only found 0
For example, this example pointing to this resource within this bundle which clearly shows the profile is correct
...
{
"fullUrl" : "urn:uuid:5fe62cd5-bfcf-4d3b-a1e9-80d6f75d6f82",
"resource" : {
"resourceType" : "Encounter",
"id" : "5fe62cd5-bfcf-4d3b-a1e9-80d6f75d6f82",
"meta" : {
"versionId" : "54",
"lastUpdated" : "2020-04-28T21:32:21.199+00:00",
"source" : "#DlfWMd7j9EX8TaLI",
"profile" : [
"http://hl7.org/fhir/us/core/StructureDefinition/us-core-encounter",
"http://hl7.org/fhir/us/davinci-alerts/StructureDefinition/adt-notification-encounter"
]
...
Eric Haas (Sep 02 2020 at 14:52):
This seems to be a publisher bug ....
Eric Haas (Sep 02 2020 at 14:58):
.also the new extension is creating errrors in the QA
ImplementationGuide/hl7.fhir.us.davinci-alerts: ImplementationGuide.definition.resource[10].extension[0] error
The extension http://hl7.org/fhir/StructureDefinition/igpublisher-no-check-aggregation is unknown, and not allowed here
ImplementationGuide/hl7.fhir.us.davinci-alerts: ImplementationGuide.definition.resource[10].extension[0].url error
URL value 'http://hl7.org/fhir/StructureDefinition/igpublisher-no-check-aggregation' does not resolve
Grahame Grieve (Sep 02 2020 at 20:08):
when I looked, the instance was failing to validate, which is why it's labelled as not present in the source of the reference
Eric Haas (Sep 03 2020 at 00:43):
I don't understand the error. here is the info in the messageheader-01 instance:
MessageHeader/admit-notification-messageheader-01: MessageHeader.focus[0] (l25/c10) Slicing Information This element
does not match any known slice defined in the profile http://hl7.org/fhir/us/davinci-alerts/StructureDefinition/admit-notification-
messageheader Hide Reasoning
This element does not match any known slicedefined_in_the_profilehttp://hl7.org/fhir/us/davinci-alerts/StructureDefinition/admit-
notification-messageheader
MessageHeader.focus[0]: discriminator = true and $this.resolve().conformsTo('http://hl7.org/fhir/us/davinci-
alerts/StructureDefinition/adt-notification-encounter')
Eric Haas (Sep 03 2020 at 00:45):
but it does not show up in the bundle instance that contains the same message header (only the id has been changed)?
Eric Haas (Sep 03 2020 at 00:47):
so I don't know if and how to fix it.
Eric Haas (Sep 03 2020 at 00:54):
Here is the profile in question...
Eric Haas (Sep 05 2020 at 19:38):
@Grahame Grieve ?
Grahame Grieve (Sep 07 2020 at 01:27):
looking into this, you have different resources with the same id (e.g. 5fe62cd5-bfcf-4d3b-a1e9-80d6f75d6f82). Can you clean this up so that ids are only used once? if that doesn't resolve this issue, then I can look with out being confused about which resource is which
Last updated: Apr 12 2022 at 19:14 UTC
