Stream: IG creation
Topic: jekyll/template error
Luke Duncan (Feb 16 2022 at 05:24):
I'm getting an error trying to run IG publisher. It appears the template has been updated, but there are some filename errors. This happens after running _updatePublisher. Everything was working fine earlier today.
Jekyll has failed. Complete output from running Jekyll: Liquid Exception: Could not locate the included file 'fragment-simpletable.html' in any of [".../temp/pages/_includes"]. Ensure it exists in one of those directories and, if it is a symlink, does not point outsid (01:49.0595)
fragment-simpleTable.html does exist in temp/pages/_includes. I renamed it to be all lowercase and ran the jekyll command directly and also got errors with fragment-pagetable.html and fragment-resourcetable.html. After renaming both of those to all use lowercase "table" then jekyll would finish.
Thanks!
Grahame Grieve (Feb 16 2022 at 06:05):
@Lloyd McKenzie probably a template error (we updated the current template today)
Grahame Grieve (Feb 16 2022 at 06:05):
are you using the current template? You could anchor on the latest release instead
Jose Costa Teixeira (Feb 16 2022 at 06:44):
template has indeed an error. case mismatches.
Jose Costa Teixeira (Feb 16 2022 at 06:46):
@Grahame Grieve I'm about to send PR.
Question: Should I fix only the case mismatches or put everything lowercase? There's a few instances or this : pageTable, simpleTable...
Thomas Tveit Rosenlund (Feb 16 2022 at 07:29):
@Luke Duncan Thanks for posting this, this error stops all my builds. Good to know the crew is on it :+1:
Jose Costa Teixeira (Feb 16 2022 at 07:38):
https://github.com/HL7/ig-template-base/pull/190
Jose Costa Teixeira (Feb 16 2022 at 07:39):
This should fix it, pending a merge
Jose Costa Teixeira (Feb 16 2022 at 07:39):
it still leaves some uppercase filenames, but those that are left are not breaking anything
Grahame Grieve (Feb 16 2022 at 07:40):
thanks - I did not have time to investigate this today. However, all of you, if this broke your builds, then you are using the current template, and this is the risk of running the current template. You should rather use the latest release
Thomas Tveit Rosenlund (Feb 16 2022 at 08:04):
Grahame Grieve said:
thanks - I did not have time to investigate this today. However, all of you, if this broke your builds, then you are using the current template, and this is the risk of running the current template. You should rather use the latest release
Is it only possible to specify either #current or a specific template version in the ig.ini or are there other undocumented options? Would really like to point to #latest-release or something.
Grahame Grieve (Feb 16 2022 at 08:14):
just don't specify a version
Grahame Grieve (Feb 16 2022 at 08:15):
then you get the latest released version
Thomas Tveit Rosenlund (Feb 16 2022 at 08:15):
That's what gave me the current build actually
Thomas Tveit Rosenlund (Feb 16 2022 at 08:16):
This was my ig.ini line for template: template = https://github.com/HL7/ig-template-base
Jose Costa Teixeira (Feb 16 2022 at 08:24):
@Thomas Tveit Rosenlund can you try now?
Thomas Tveit Rosenlund (Feb 16 2022 at 08:28):
@Jose Costa Teixeira Not working for me. I have tried it all:
- template = https://github.com/HL7/ig-template-base (still gives the Liquid error 5 minutes ago)
- template = https://github.com/HL7/ig-template-base#current (gives a different error)
- template = https://github.com/HL7/ig-template-base#0.1.0 (same error as above)
If I try to specify a version i get something like this:
Publishing Content Failed: Error loading template https://github.com/HL7/ig-template-base#current: Error parsing https://github.com/HL7/ig-template-base#current/archive/master.zip#package/package.json: null (00:07.0941)
My runs: https://github.com/HL7Norway/VkpObservation/actions/workflows/vkpobservation-gh-pages.yml
Jose Costa Teixeira (Feb 16 2022 at 08:29):
which one is your build with base#current?
Grahame Grieve (Feb 16 2022 at 08:37):
just use the package id. The versioning doesn't work if you refer to a template directly by URL
Grahame Grieve (Feb 16 2022 at 08:37):
template = hl7.fhir.template
Thomas Tveit Rosenlund (Feb 16 2022 at 08:45):
@Jose Costa Teixeira The last one : https://github.com/HL7Norway/VkpObservation/runs/5213074095?check_suite_focus=true
Thomas Tveit Rosenlund (Feb 16 2022 at 08:45):
@Grahame Grieve will try that id instead
Jose Costa Teixeira (Feb 16 2022 at 09:07):
right (i missed that). you should use the package id, not url
Jose Costa Teixeira (Feb 16 2022 at 09:07):
@Thomas Tveit Rosenlund the comments on ini are #, not //
Thomas Tveit Rosenlund (Feb 16 2022 at 09:10):
@Grahame Grieve The id seems to work thanks
Thomas Tveit Rosenlund (Feb 16 2022 at 09:11):
I thought id or url was much the same for this but apparantly not
Grahame Grieve (Feb 16 2022 at 10:00):
it is a different thing, yes. the package id is resolved through the npm package system which supports versioning, but the URL is resolved directly to a working repository
Thomas Tveit Rosenlund (Feb 16 2022 at 10:56):
When you explain it like that @Grahame Grieve, it makes perfect sense
John Moehrke (Feb 16 2022 at 13:20):
I noticed that all of the derivation IG templates all call upon their previous using #current... is this what we want?
e.g. https://github.com/HL7/ig-template-fhir/blob/master/package/package.json
Grahame Grieve (Feb 16 2022 at 14:34):
All the current refer to current, yes. The versioned releases don’t
John Moehrke (Feb 16 2022 at 15:00):
Still failing
John Moehrke (Feb 16 2022 at 15:00):
The accepted pull request does not seem to be propigating.. even to the ci-build
Grahame Grieve (Feb 16 2022 at 15:06):
what's still failing?
Jose Costa Teixeira (Feb 16 2022 at 15:10):
https://github.com/HL7/ig-template-base/pull/191
Jose Costa Teixeira (Feb 16 2022 at 15:11):
@Grahame Grieve I think I missed something, or windows did
Jose Costa Teixeira (Feb 16 2022 at 15:11):
can you approve please?
Grahame Grieve (Feb 16 2022 at 15:13):
done
John Moehrke (Feb 16 2022 at 15:21):
seems all of these filenames should have (and going forward be) always lowercase.
Saul Kravitz (Feb 16 2022 at 15:24):
When I build locally (after running _updatePublisher.sh, naturally), everything works well.
The CI build bombs -- http://build.fhir.org/ig/HL7/codex-radiation-therapy/branches/master/failure/build.log
Jekyll: Source: /scratch/ig-build-temp-L4X7C4/repo/temp/pages (04:25.0119)
Jekyll: Generating... (04:25.0119)
Jekyll has failed. Complete output from running Jekyll: [31m Liquid Exception: Could not locate the included file 'fragment-simpletable.html' in any of ["/scratch/ig-build-temp-L4X7C4/repo/temp/pages/_includes"]. Ensure it exists in one of those directories and, if it is a symlink, does not point outside your (04:25.0276)
Note: Check that Jekyll is installed correctly (04:25.0276)```
David Pyke (Feb 16 2022 at 15:28):
That error means that it can't find the file you're trying to include. Can you make sure it's being created by your tooling?
Grahame Grieve (Feb 16 2022 at 15:32):
all these are template issues. Stop using the current template, and you won't have a problem
Saul Kravitz (Feb 16 2022 at 15:37):
Why does it work locally, but not on the CI build? SHouldn't it fail/succeed consistently?
Jose Costa Teixeira (Feb 16 2022 at 15:40):
it should work on the ci build. @Luke Duncan ?
Jose Costa Teixeira (Feb 16 2022 at 15:41):
@Saul Kravitz are you on Windows?
John Moehrke (Feb 16 2022 at 15:52):
@Grahame Grieve Most of us are using some template.. include those using the HL7 FHIR template... where it is THOSE templates that are pulling in base using #current... so, is THAT right?
Luke Duncan (Feb 16 2022 at 15:56):
This is working for me now.
This was done through a couple of dependencies that are handled using a package.json file, e.g,:
"dependencies": {
"ihe.fhir.template": "current"
}
If I remove current, it fails. Is there a way to get the latest release version without having to update version numbers as releases happen without using current? Or if I'm starting from something like this: https://github.com/HL7/ig-template-hl7/blob/master/package/package.json
Grahame Grieve (Feb 16 2022 at 16:05):
@John Moehrke no, I already explained. Released packages do not depend on current
Grahame Grieve (Feb 16 2022 at 16:05):
s there a way to get the latest release version without having to update version numbers as releases happen without using current?
in what context. In an ig.ini, just don't specify a version, and you get the latest release. but the context of your question suggests you're asking about something different
Grahame Grieve (Feb 16 2022 at 16:06):
I don't know why it doesn't work on the CI build, except that that's linux, and fully case sensitive, and other file systems aren't
Luke Duncan (Feb 16 2022 at 16:18):
Grahame Grieve said:
s there a way to get the latest release version without having to update version numbers as releases happen without using current?
in what context. In an ig.ini, just don't specify a version, and you get the latest release. but the context of your question suggests you're asking about something different
In a package.json file for a template that depends on other templates, you don't seem to have the option to leave off current. Like in the example I linked for hl7.base.template: https://github.com/HL7/ig-template-hl7/blob/master/package/package.json (which is using fhir.base.template#current)
Grahame Grieve (Feb 16 2022 at 16:22):
the github templates are all current, and have no choice but to rely on the current version in github, yes. When I publish the templates, the dependency chain is replaced with the latest release all the way down the chain.
Grahame Grieve (Feb 16 2022 at 16:22):
Once we've ironed out the issues with the current template, then I'll be releasing a new set of templates for all the templates
Last updated: Apr 12 2022 at 19:14 UTC
