Stream: IG creation
Topic: java.lang.IllegalArgumentException: Unknown SearchModifierCo
Rick Geimer (Jun 19 2019 at 14:50):
Build is now failing with this error:
Load USCoreR4 (http://hl7.org/fhir/us/core) from hl7.fhir.us.core#current (36.0266sec)
Publishing Content Failed: Unknown SearchModifierCode code '?' (36.0275sec)
(36.0275sec)
Use -? to get command line help (36.0275sec)
(36.0276sec)
Stack Dump (for debugging): (36.0276sec)
java.lang.IllegalArgumentException: Unknown SearchModifierCode code '?'
at org.hl7.fhir.r4.model.SearchParameter$SearchModifierCodeEnumFactory.fromCode(SearchParameter.java:606)
at org.hl7.fhir.r4.model.SearchParameter$SearchModifierCodeEnumFactory.fromCode(SearchParameter.java:1)
at org.hl7.fhir.r4.formats.JsonParser.parseEnumeration(JsonParser.java:105)
at org.hl7.fhir.r4.formats.JsonParser.parseSearchParameterProperties(JsonParser.java:22893)
at org.hl7.fhir.r4.formats.JsonParser.parseSearchParameter(JsonParser.java:22753)
at org.hl7.fhir.r4.formats.JsonParser.parseResource(JsonParser.java:27646)
at org.hl7.fhir.r4.formats.JsonParserBase.parse(JsonParserBase.java:113)
at org.hl7.fhir.igtools.publisher.Publisher.loadFromPackage(Publisher.java:2096)
at org.hl7.fhir.igtools.publisher.Publisher.loadIg(Publisher.java:2179)
at org.hl7.fhir.igtools.publisher.Publisher.initializeFromJson(Publisher.java:1669)
at org.hl7.fhir.igtools.publisher.Publisher.initialize(Publisher.java:1119)
at org.hl7.fhir.igtools.publisher.Publisher.execute(Publisher.java:603)
at org.hl7.fhir.igtools.publisher.Publisher.main(Publisher.java:6115)
Exception in thread "main" java.lang.NullPointerException
at org.hl7.fhir.igtools.publisher.Publisher.main(Publisher.java:6125)
Rick Geimer (Jun 19 2019 at 14:50):
This is happening for CDex, PDex, and HRex.
@Grahame Grieve
Chris Moesel (Jun 19 2019 at 18:37):
This is also now happening on the US Drug Formulary IG. @Saul Kravitz
Chris Moesel (Jun 19 2019 at 18:47):
@Eric Haas & @Brett Marquard -- I can't tell for sure, but based on where this error happens in the log, is it possible that US Core R4 is the source of this error? Did you recently update any search parameters that might have introduced an invalid search modifier?
Lynn Laakso (Jun 19 2019 at 18:49):
US Core R4 failed when trying to publish the STU; @Grahame Grieve is working on fix to igpublisher
Eric Haas (Jun 19 2019 at 19:07):
unless it was an errant keystroke ...no they were all script generated.
Grahame Grieve (Jun 19 2019 at 19:28):
I don't understand. they all build fine locally, right?
Rick Geimer (Jun 19 2019 at 19:34):
HRex builds locally but not on the CI build, but PDex and CDex have dependencies on HRex and thus expect HRex to have a package available on the CI build thus can't build locally either.
Saul Kravitz (Jun 19 2019 at 19:53):
Drug Formulary builds beautifully with org.hl7.fhir.publisher.cli-0.9.26-20190608.050437-1.jar
Haven't tried more recent builds locally.
Rick Geimer (Jun 19 2019 at 20:20):
@Grahame Grieve one more piece of info, when I build HRex locally I still get this build error:
URL value 'http://hl7.org/fhir/us/core/ImplementationGuide/hl7.fhir.us.core-3.0.0' does not resolve
Rick Geimer (Jun 19 2019 at 20:26):
@Grahame Grieve Actually, I have some more info for you. On a hunch I just deleted my package cache locally, and now HRex is throwing the same error as the CI build:
java.lang.IllegalArgumentException: Unknown SearchModifierCode code '?'
at org.hl7.fhir.r4.model.SearchParameter$SearchModifierCodeEnumFactory.fromCode(SearchParameter.java:606)
at org.hl7.fhir.r4.model.SearchParameter$SearchModifierCodeEnumFactory.fromCode(SearchParameter.java:1)
Rick Geimer (Jun 19 2019 at 20:26):
So it seems that a cached version of US Core was masking the error locally.
Eric Haas (Jun 19 2019 at 21:21):
perhaps this can shed some light on it...
Eric Haas (Jun 19 2019 at 21:21):
Originally the _modifiers and _comparator elements were not being published in json or xml. GG fixed that so they are now present but inadvertently the modifiers values are all "?". (When I checked to confirm the fix I must admit I only looked for _mods and _comps and a list of comparators. )
Eric Haas (Jun 19 2019 at 21:27):
e.g. for SP USCoreObservationCategory: (not source but generated from source)
Eric Haas (Jun 19 2019 at 21:29):
... "multipleAnd": true, "_multipleAnd": { "extension": [ { "url": "http://hl7.org/fhir/StructureDefinition/capabilitystatement-expectation", "valueCode": "MAY" } ] }, "modifier": [ "?", "?", "?", "?", "?", "?", "?", "?" ], "_modifier": [ { "extension": [ { "url": "http://hl7.org/fhir/StructureDefinition/capabilitystatement-expectation", "valueCode": "MAY" } ] }, { "extension": [ { "url": "http://hl7.org/fhir/StructureDefinition/capabilitystatement-expectation", ....
Eric Haas (Jun 19 2019 at 21:29):
And this is from my local US-Core-R4 build which I reran today.
Grahame Grieve (Jun 19 2019 at 21:55):
what? I checked that...
Grahame Grieve (Jun 19 2019 at 22:01):
... or not...
Rick Geimer (Jun 19 2019 at 23:16):
@Grahame Grieve Seems you got HRex to build, but now all the links to US Core are broken, and the US Core IG itself seems only partially there (see http://www.hl7.org/fhir/us/core/), but you are probably aware of that. Let me know when you think US Core and the build in general are ready to work against again, as Lynn has a few minor tweaks she wants to HRex and CDex for the ballot.
Grahame Grieve (Jun 20 2019 at 00:10):
Us Core is work in progress right now
Grahame Grieve (Jun 20 2019 at 03:15):
ok now that US Core is finally published, we need to update all the Da Vinci guides to depend on v 3.0.0 not current
Rick Geimer (Jun 20 2019 at 08:24):
Ok, will try now
Grahame Grieve (Jun 20 2019 at 08:26):
I did a couple but anything that depends on ehrx has to wait until Lynn publishes it now - because that dependency has to be 0.1.0 not current
Rick Geimer (Jun 20 2019 at 09:51):
For now I reset the HRex dependencies in CDex and PDex to current just to make sure the IGs build and to fix the remaining issues that Lynn raised with them, but I will ask Lynn to let me know when HRex is published so that I can update them to 0.1.0.
Chris Moesel (Jun 20 2019 at 14:26):
ok now that US Core is finally published, we need to update all the Da Vinci guides to depend on v 3.0.0 not current
@Grahame Grieve, @Saul Kravitz -- It looks like the USDF STU ballot release was just officially announced, but we didn't get to bump US Core from current
to 3.0.0
. So what's the procedure now? Do we bump it, and if so do we need to coordinate w/ @Lynn Laakso? Or do we leave it be?
Grahame Grieve (Jun 20 2019 at 19:25):
which one is this exactly?
Chris Moesel (Jun 20 2019 at 20:12):
new Publication: 1st STU ballot of the Da Vinci US Drug Formulary STU Ballot release 0.1.0: http://hl7.org/fhir/us/Davinci-drug-formulary/Jun2019/
Grahame Grieve (Jun 20 2019 at 20:19):
we do need to fix it
Grahame Grieve (Jun 20 2019 at 20:19):
can you commit the appropriate changes
Chris Moesel (Jun 20 2019 at 20:39):
@Saul Kravitz -- can you update the USDF IG w/ the new US Core 3.0.0? If you're rebuilding from CIMPL, you should use the new SHR CLI v5.21.1 release.
Saul Kravitz (Jun 20 2019 at 22:35):
Done. https://github.com/HL7/davinci-pdex-formulary/blob/master/ig.json now has:
"dependencyList": [
{
"package": "hl7.fhir.us.core",
"version": "3.0.0",
"name": "uscore",
"location": "http://hl7.org/fhir/us/core"
}
],
Last updated: Apr 12 2022 at 19:14 UTC