Stream: IG creation
Topic: gitlab
Jose Costa Teixeira (Apr 08 2020 at 05:41):
Will our CI build work if I use gitlab to host my repository instead of github? Anyone doing that?
Grahame Grieve (Apr 08 2020 at 06:01):
no it won't. And I don't believe we see any reason why we should invest in making that happe
Jose Costa Teixeira (Apr 08 2020 at 06:29):
ok just wanted to know
Gabriel Kleinoscheg (Jul 08 2021 at 12:52):
What's the reason that the IG is GitHub centered?
I wondered if it would at least be possible to support templates being hosted in GitLab repositories as well.
David Pyke (Jul 08 2021 at 13:17):
You can host private IGs anywhere, the templates will be fetched by the IG publisher from their homes when run locally or through the autobuilder. HL7 published IGs are in the HL7 space on Github for organizational control.
Gabriel Kleinoscheg (Jul 08 2021 at 13:30):
Yes, I know. However, the IG publisher also allows that templates are also located in a GitHub-repository. I.e. in ig.ini you can specify a GitHub-URL for template and in a template's package.json you can specify the base to be a GitHub-repository.
However, at this point it would be great, if github.com was not hardcoded into the TemplateManager.
Lloyd McKenzie (Jul 08 2021 at 14:07):
The location for 'trusted' templates must be hardcoded. We don't allow templates we don't trust the maintenance of to run in the CI build.
Gabriel Kleinoscheg (Jul 09 2021 at 10:16):
Ok - I see.
Nevertheless, an issue exists regarding GitHub-URLs and file directories - I raised the issue: https://github.com/HL7/fhir-ig-publisher/issues/285
I would be grateful for any feedback. Maybe I did something wrong configuring the IG.
Thank you all!
Lloyd McKenzie (Jul 09 2021 at 13:41):
@Mark Iantorno
Lloyd McKenzie (Jul 09 2021 at 13:41):
(FYI)
Grahame Grieve (Jul 13 2021 at 20:24):
I don't follow the issue. Dependencies are to packages, not repos
Lloyd McKenzie (Jul 13 2021 at 22:29):
The code for certain packages is tied to particular github repos though - so that non-trusted sources claiming to be a particular package can't overwrite our 'official' templates with versions that could do malicious things.
Gabriel Kleinoscheg (Jul 15 2021 at 08:50):
But still - as mentioned in the issue - the method TemplateManager#loadPackage() allows that the template to be loaded is a GitHub-Repository.
Last updated: Apr 12 2022 at 19:14 UTC
