Stream: IG creation
Topic: findExemptionComment error
Rob Hausam (Jun 05 2019 at 12:37):
I'm getting a new error (at least new to me) near the end of the IG build this morning:
Sending Usage Stats to Server (00:01:18.0163sec)
Jekyll: Source: /Users/rhausam/git-repo/fhir-ips/temp (00:01:19.0432sec)
Jekyll: Generating... (00:01:19.0432sec)
Jekyll: done in 9.381 seconds. (00:01:28.0813sec)
Installing hl7.fhir.uv.ips#dev to the package cache
Fetching:......|
Analysing.... done.
Can't store ImplementationGuide-ig-uv-ips in R3 format for registry.fhir.org (00:01:35.0996sec)
Checking Output HTML (00:01:36.0615sec)
found 1140 files
Publishing Content Failed: null (00:01:56.0470sec)
(00:01:56.0470sec)
Use -? to get command line help (00:01:56.0470sec)
(00:01:56.0470sec)
Stack Dump (for debugging): (00:01:56.0470sec)
java.lang.NullPointerException
at org.hl7.fhir.igtools.publisher.HTLMLInspector.findExemptionComment(HTLMLInspector.java:386)
at org.hl7.fhir.igtools.publisher.HTLMLInspector.check(HTLMLInspector.java:232)
at org.hl7.fhir.igtools.publisher.Publisher.generate(Publisher.java:3635)
at org.hl7.fhir.igtools.publisher.Publisher.createIg(Publisher.java:725)
at org.hl7.fhir.igtools.publisher.Publisher.execute(Publisher.java:604)
at org.hl7.fhir.igtools.publisher.Publisher.main(Publisher.java:6011)
Exception in thread "main" java.lang.NullPointerException
at org.hl7.fhir.igtools.publisher.Publisher.main(Publisher.java:6021)
This is with the latest Publisher 0.9.23-SNAPSHOT. I'm not sure yet what the "exemption comment" is that's apparently being looked for and is generating the null pointer exception. I'll do further checking, but does anyone have thoughts or solutions?
Rob Hausam (Jun 05 2019 at 13:31):
I'm getting the same error with 0.9.24-SNAPSHOT (freshly built from source).
Sarah Gaunt (Jun 05 2019 at 19:59):
I was getting that yesterday too - works fine locally with the latest IG Publisher download.
Sarah Gaunt (Jun 05 2019 at 22:52):
@Grahame Grieve any idea whether this is an IG Publisher issue or not? My build works fine with the latest IG publisher running locally but fails in the CI build (http://build.fhir.org/ig/HL7/case-reporting/branches/master/build.log). @Mark Scrimshire also getting the same error (http://build.fhir.org/ig/HL7/davinci-epdx/branches/master/build.log )
Mark Scrimshire (Jun 05 2019 at 22:55):
Grahame Grieve any idea whether this is an IG Publisher issue or not? My build works fine with the latest IG publisher running locally but fails in the CI build (http://build.fhir.org/ig/HL7/case-reporting/branches/master/build.log). Mark Scrimshire also getting the same error (http://build.fhir.org/ig/HL7/davinci-epdx/branches/master/build.log )
I have raised a ticket with the trifolia-on-fhir Team ( @Sean McIlvenna / @Rick Geimer ) so they should be checking this from their end.
Sarah Gaunt (Jun 05 2019 at 22:59):
@Rob Hausam you aren't using Trifolia on FHIR for your IG are you? Did you find a solution to the issue?
Rob Hausam (Jun 06 2019 at 00:52):
@Sarah Gaunt @Grahame Grieve No, I haven't been using Trifolia. I fixed the null pointer exception in my local copy of the IG Publisher source code, and with that the IPS IG builds fine again. I don't have access to the IG Pub git repo at the moment, but I can create a pull request when I do.
Sarah Gaunt (Jun 06 2019 at 00:55):
Yeah my local build works fine with latest version of IG Publisher. Maybe some caching issue with the CI build.
Sarah Gaunt (Jun 06 2019 at 00:56):
Oh - you're saying you fixed the IG Publisher code - sweet!
Rob Hausam (Jun 06 2019 at 01:11):
My fix isn't published yet - so I'm not entirely sure why the error isn't showing up more consistently.
Giorgio Cangioli (Jun 06 2019 at 15:22):
I'm getting the same error with 0.9.24-SNAPSHOT (freshly built from source).
MMhh using https://oss.sonatype.org/service/local/artifact/maven/redirect?r=snapshots&g=org.hl7.fhir.publisher&a=org.hl7.fhir.publisher.cli&v=LATEST&e=jar I'm getting version 0.9.22 ..
Giorgio Cangioli (Jun 06 2019 at 15:23):
is there a more updated link to be used ?
Rob Hausam (Jun 06 2019 at 16:18):
The latest release is 0.9.24-SNAPSHOT as noted here. But when I downloaded from the https://fhir.github.io/latest-ig-publisher/org.hl7.fhir.publisher.jar link yesterday I got 0.9.23-SNAPSHOT. It seems that 0.9.24-SNAPSHOT hasn't been pushed to the download site(s) yet? @Grahame Grieve? My pull request (still pending at this point) is to fix the NullPointerException (noted above) when I attempted to build IPS using both 0.9.23-SNAPSHOT and 0.9.24-SNAPSHOT.
Ricky Sahu (Jun 06 2019 at 18:30):
Im getting the same Publisher error (http://build.fhir.org/ig/HL7/bulk-data/branches/mayrec2/build.log)
Stack Dump (for debugging): (40.0780sec)
java.lang.NullPointerException
at org.hl7.fhir.igtools.publisher.HTLMLInspector.findExemptionComment(HTLMLInspector.java:386)
at org.hl7.fhir.igtools.publisher.HTLMLInspector.check(HTLMLInspector.java:232)
at org.hl7.fhir.igtools.publisher.Publisher.generate(Publisher.java:3635)
at org.hl7.fhir.igtools.publisher.Publisher.createIg(Publisher.java:725)
at org.hl7.fhir.igtools.publisher.Publisher.execute(Publisher.java:604)
at org.hl7.fhir.igtools.publisher.Publisher.main(Publisher.java:6011)
Exception in thread "main" java.lang.NullPointerException
at org.hl7.fhir.igtools.publisher.Publisher.main(Publisher.java:6021)
@Josh Mandel was suggesting the Publisher has changed. How can I change it back or otherwise resolve this issue? I believe may be an issue with the build process because even previous commits that worked are not building.
- I created a new branch on git and pushed older working builds (via their commit id) and that didnt work (http://build.fhir.org/ig/HL7/bulk-data/branches/)
- Went back all the way to the previous builds (https://github.com/HL7/bulk-data/tree/mayrec2) that had succeeded (https://chat.fhir.org/#narrow/stream/179297-committers.2Fnotification/topic/ig-build/near/166746957) on the new branch
- Even pushing @Grahame Grieve 's commit before balloting (https://github.com/HL7/bulk-data/tree/mayrec3) is not working currently.
Rob Hausam (Jun 06 2019 at 18:32):
I can provide you with a copy of my fixed version of the 0.9.24-SNAPSHOT IG Publisher if that will help.
Ricky Sahu (Jun 06 2019 at 18:36):
@Rob Hausam yes can you share that with me. I will try it. However from what I understand, that will only work locally correct? In order to have this build work on build.fhir.org we need a fix from the team that manages it right?
Rob Hausam (Jun 06 2019 at 18:45):
Yes, that would be to get it working for you locally. For it to work with the CI build the PR (or an equivalent fix) will need to be accepted and published.
Rick Geimer (Jun 06 2019 at 18:54):
I'm getting this error too using the latest IG publisher.
Ricky Sahu (Jun 06 2019 at 19:07):
OK great we'll stay tuned for this PR to be published.
Lloyd McKenzie (Jun 06 2019 at 19:22):
I've merged the pull request, but I'm not totally clear on the process for pushing up a new release
Rob Hausam (Jun 06 2019 at 19:26):
I saw that, Lloyd - thanks. I'm not sure how Grahame pushes the new release, either. If anyone wants a copy of my fixed version in the meantime just message me privately and I'll give you a link. You can also build the IG Publisher from source now that Lloyd has merged the PR, but getting the link should be a bit easier. :)
Chris Moesel (Jun 06 2019 at 20:45):
It looks to me like Grahame just pushes the built jar to https://github.com/FHIR/latest-ig-publisher
Chris Moesel (Jun 06 2019 at 20:46):
Once it gets pushed, I think GitHub detects the change and publishes it out via GitHub Pages (which may take a few minutes).
Chris Moesel (Jun 06 2019 at 20:46):
I think @Josh Mandel helped him get that set up.
Josh Mandel (Jun 06 2019 at 21:05):
It's true that if you fetch via github pages there may be a delay; the auto-builder (and anyone who isn't worried about bandwidth of downloading duplicate files) can fetch from https://github.com/FHIR/latest-ig-publisher/raw/master/org.hl7.fhir.publisher.jar
Rob Hausam (Jun 06 2019 at 21:20):
How is the new release version (e.g., "0.9.25-SNAPSHOT") assigned?
Rick Geimer (Jun 06 2019 at 21:27):
CI build still broken
Rick Geimer (Jun 06 2019 at 21:43):
This critically impacts the QA deadline for the Da Vinci out of cycle ballots today @Melva Peters @Grahame Grieve
Lloyd McKenzie (Jun 06 2019 at 22:01):
Understand. There is a release.bat file in the igpublisher source, but it's hard-coded to stuff on Grahame's hard drive and makes use of executables I don't have - or even know where to find. Some of them I think are optional (e.g. automated notifications to Zulip), but others not so much.
Rob Hausam (Jun 06 2019 at 22:03):
@Josh Mandel Is there a way to get the IG Publisher in the CI build updated to use Lloyd's latest commit (0c48842)?
Lloyd McKenzie (Jun 06 2019 at 22:04):
Grahame's currently in Brussels and he mentioned this morning that his hotel's internet is absolutely horrible, so whether he'll even see this in time to do anything about it, I'm not sure. (Obviously one take-away is to ensure that more people are capable of doing new publisher and validator releases - which will particularly be important once Grahame goes walkabout later this month.)
Lloyd McKenzie (Jun 06 2019 at 22:04):
I'll see if I can generate the jar locally and push it directly to that location. It won't be in Maven, but I'm not sure anyone much cares right now :)
Rob Hausam (Jun 06 2019 at 22:05):
I already have the jar, if that helps.
Lloyd McKenzie (Jun 06 2019 at 22:06):
It does. Can you PM it to me?
Rob Hausam (Jun 06 2019 at 22:06):
sure
Lloyd McKenzie (Jun 06 2019 at 22:20):
Piddle. I don't have admin for github.com/FHIR. (I do for github.com/HL7, but that doesn't help). @Josh Mandel do you? Any chance you could give it to me? (Or commit Rob's jar yourself?)
Josh Mandel (Jun 06 2019 at 22:49):
@Lloyd McKenzie you have an invite now.
Lloyd McKenzie (Jun 07 2019 at 00:15):
Unfortunately the invite doesn't seem to give me committer privileges :(
Rick Geimer (Jun 07 2019 at 01:17):
Rob's publisher works for me locally, but now getting the following QA error on all pages:
"error The html source does not contain the header marker"
Anyone know what this one is about? The HTML output does contain the <head> tag.
Lloyd McKenzie (Jun 07 2019 at 02:42):
Ok, publisher is now committed. Sorry to all that took as long as it did. I've re-run SDC and it was happy, so in theory the publisher should be good now.
Lloyd McKenzie (Jun 07 2019 at 02:42):
@Rick Geimer Is it looking for the standard header fragment on all of your pages that Grahame now expects so he can substitute into it when publishing? (You can see an example of it in the SDC guide if you want.)
Rob Hausam (Jun 07 2019 at 02:45):
Thanks, Lloyd.
Sarah Gaunt (Jun 07 2019 at 03:22):
Second the thanks Lloyd!
Rick Geimer (Jun 07 2019 at 03:25):
Agreed. @Lloyd McKenzie is that header fragment documented somewhere? If so I must have missed it.
Rick Geimer (Jun 07 2019 at 03:25):
I will look at the SDC example though
Grahame Grieve (Jun 07 2019 at 03:53):
@Lloyd McKenzie please explain what you actually did. I'm finally back on line, and catching up - it's astonishingly hard to get on-line in european hotels), and I expected to see a new release of the IG-publisher after reading all this, but I on;y see a bug fix
Grahame Grieve (Jun 07 2019 at 03:54):
btw the fix is weird - do we routinely have empty html comments in our pages do we?
Sarah Gaunt (Jun 07 2019 at 03:55):
@Rick Geimer http://wiki.hl7.org/index.php?title=FHIR_Implementation_Guide_Publishing_Requirements
Rick Geimer (Jun 07 2019 at 03:56):
So this:
<!--ReleaseHeader--><p id="publish-box">Publish Box goes here</p><!--EndReleaseHeader-->
Rick Geimer (Jun 07 2019 at 03:57):
Thanks @Sarah Gaunt
Rob Hausam (Jun 07 2019 at 04:07):
There maybe shouldn't be "null" comments - but if they are there they shouldn't cause a NPE. An appropriate warning message probably would make sense, but at least with this the build completes.
Grahame Grieve (Jun 07 2019 at 04:17):
I'm just surprised. even then it shouldn't be null so I'm not sure why it was an NPE. Unfortunate that I released this and then couldn't get back on line at the times I could have fixed it (was very busy with meetings yesterday)
Grahame Grieve (Jun 07 2019 at 04:19):
and I'm not sure how to automate the build of the IG publisher. The build actions have been growing...
Rob Hausam (Jun 07 2019 at 04:22):
You can't be available all the time - we probably need some additional backup options, in case it does occur.
Grahame Grieve (Jun 07 2019 at 04:23):
right. which is why the question about the build. the build is dependent on my local set up, but it's complicated because of cross-repo actions.
Lloyd McKenzie (Jun 07 2019 at 13:36):
My action was just to commit a new jar to the latest publisher git repo. (And to merge Rob's PR.). I did NOT follow the steps for an official Maven release because I wasn't sure how. Though I'd like to be at the point where I can before you leave. We can talk off line about how to make things independent of your machine.
Grahame Grieve (Jun 07 2019 at 13:40):
ok thx
David Pyke (Jun 07 2019 at 13:50):
Leave?
Lloyd McKenzie (Jun 07 2019 at 14:49):
Grahame's disconnected for a month starting mid-late June.
David Pyke (Jun 07 2019 at 14:49):
Oh, okay. You scared me for a while there.
Grahame Grieve (Jun 07 2019 at 18:54):
it's for 5 weeks, but I won't be disconnected completely - just not very responsive
Last updated: Apr 12 2022 at 19:14 UTC
