Stream: IG creation
Topic: data elements lost in output examples
François Macary (Feb 12 2020 at 15:59):
I'm building the fhir-order-catalog IG. This IG includes profiles of PlanDefinition and ChargeItemDefinition. My example of these two resources systematically lose their useContext elements in the output of the IG. In addition PlanDefinition also loses action.definitionCanonical element. See for intance this example in the input: https://github.com/HL7/fhir-order-catalog/blob/master/input/examples/example-lab-panel-blood-electrolyte.xml, and then check the output in the artifacts of the guide. Any idea on this issue? Thanks
Lloyd McKenzie (Feb 12 2020 at 16:07):
What version of FHIR is the IG targeting?
François Macary (Feb 12 2020 at 16:08):
4.0.1
Lloyd McKenzie (Feb 12 2020 at 16:20):
That's really weird... The order of elements in your source instance is correct. There appears to be no change from 4.0.1 to R5 for the respective elements. @Grahame Grieve any ideas?
Grahame Grieve (Feb 12 2020 at 19:41):
it was code you wrote, @Lloyd McKenzie , of course
Grahame Grieve (Feb 12 2020 at 19:46):
fixed next release
François Macary (Feb 12 2020 at 21:30):
Looking forward to it :-) Thank you, guys.
Lloyd McKenzie (Feb 12 2020 at 21:35):
I don't think I'm deserving of thanks in this particular case... (sorry)
François Macary (Feb 13 2020 at 16:48):
The fix is only partial, unfortunately.
Now my examples of PlanDefinition and ChargeItemDefinition have their useContext elements generated in the output. Happy of this!
But my PlanDefinition elements are still missing some child elements of PlanDefinition.action in the output.
This example: https://github.com/HL7/fhir-order-catalog/blob/master/input/examples/example-lab-panel-blood-electrolyte.xml
is missing action.definitionCanonical value="ActivityDefinition/example-lab-blood-electrolyte" in the output.
This example: https://github.com/HL7/fhir-order-catalog/blob/master/input/examples/example-lab-test-serum-creatinine.xml
is missing its two sub-actions and their respective definitionCanonical child elements (lines #107 to #112 vanished from the output)
François Macary (Feb 13 2020 at 18:45):
@Lloyd McKenzie There is more around parsing PlanDefinition.action. Apparently the IG builder is not able to parse a PlanDefinition with more than one level of nested actions. It aborts with a java error in that case.
Unlike in the Dune novel, it could not say "I can see plans within plans".
I'm guessing that this is closely related to the issue above.
Grahame Grieve (Feb 13 2020 at 19:45):
looking into this... I notice that you are not using semantic versioning for your version. As an HL7 IG, this will be required before publication
Grahame Grieve (Feb 13 2020 at 20:01):
@François Macary I found and fixed the issue with action.definitionCanonical but I can not reproduce the issue with the sub-actions. I see it on the ci-build, but not locally. that's real weird, because there's no change since release except for the action.definitionCanonical thing.
you say:
It aborts with a java error in that case.
What is the specific error? I don't see that on the ci-build?
François Macary (Feb 14 2020 at 08:38):
@Grahame Grieve I checked right now on the CI build. The PlanDefinition.action.definitionCanonical are still missing for all my 5 examples.
I had commented the more complex one E5 with two levels of sub-actions, which provoked the abort. I'm removing the comments right now.
This one: https://github.com/HL7/fhir-order-catalog/blob/master/input/examples/example-lab-panel-urine24h-creatinine-clearance.xml
I have also used the <Debug Summary> button and sent you the content by email, as instructed by this button.
So in summary:
1) I don't see yet any PlanDefinition.action.definitionCanonical in the output
2) The problematic example above aborts tne build.
François Macary (Feb 20 2020 at 08:12):
All corrected. Thanks :+1:
Last updated: Apr 12 2022 at 19:14 UTC
