Stream: IG creation
Topic: broken links for CodeSystem
Rob Hausam (Mar 06 2019 at 19:44):
In IPS we've gotten a number of these errors for broken links with our 'absent-unknown-uv-ips' code system:
ValueSet-absent-or-unknown-devices-uv-ips.html#/html/head/body/div/div/div/div/div/div/div/table/tr/td/a at Line 284, column 665 error The link 'CodeSystem-absent-unknown-uv-ips.html#absent-unknown-uv-ips-no-device-info' for "no-device-info" cannot be resolved (valid targets: [page-content-wrapper, segment-header, publish-box, stripe, segment-footer, segment-post-footer, segment-navbar, your-logo, project-status])
We've been able to resolve them by adding this section for handling CodeSystem resources to base.html (thanks @Giorgio Cangioli):
{% when 'CodeSystem' %}
<!-- ============CodeSystem CONTENT CONTENT=============== -->
{% include {{[type]}}-{{[id]}}-summary.xhtml %}
{% include {{[type]}}-{{[id]}}-xref.xhtml %}
{% include {{[type]}}-{{[id]}}-content.xhtml %}
<!-- ============CodeSystem CONTENT CONTENT=============== -->
My question is does this make sense and is it a legitimate solution (it seems to be)? And does this change need to be made generally (not just for the IPS IG)? @Lloyd McKenzie? @Eric Haas? Others?
Lloyd McKenzie (Mar 06 2019 at 20:07):
Are you running with my set of templates?
Rob Hausam (Mar 06 2019 at 20:08):
Not for this IG. IPS was built from @Eric Haas's framework.
Eric Haas (Mar 06 2019 at 20:19):
here is what I use :
{% when 'CodeSystem' %}
<!-- ============CODESYSTEM CONTENT CONTENT=============== -->
{% include {{[type]}}-{{[id]}}-summary.xhtml %}
{% include {{[type]}}-{{[name]}}.xhtml %}
<!-- ============CODESYSTEM CONTENT CONTENT=============== -->
so I assume you added
{% include {{[type]}}-{{[id]}}-xref.xhtml %}
which just a "A list of all the places where the resource is used (all conformance resources)"
that should not affect bad links.
And I haven't found it useful so don't use it. can you give an example of how you link ( canonical or internal relative link?)
Eric Haas (Mar 06 2019 at 20:21):
I also not having problems with code-system links I think the canonical is not going to work until is publshed although I am foggy on that. I think that is why you need a local package file for dependencies...
Rob Hausam (Mar 06 2019 at 20:49):
Thanks, @Eric Haas. I haven't explored it yet to be sure, but I'm guessing that you updated your templates along the way after we started and we didn't pick up those changes. @Giorgio Cangioli added this code and figured out that it worked - and I assume he got his inspiration from the code for ValueSet, which is quite similar (except for '-content' vs. '-cld'), but he will have to say. But maybe we need to do a more general update of the framework at this point? And if so, can you point us to the best (or at least a correct) place to get those updates?
Eric Haas (Mar 06 2019 at 20:51):
latest is always at: https://github.com/Healthedata1/IG-Template2
Eric Haas (Mar 06 2019 at 20:53):
but that base.html has not been changed since last spring?
Rob Hausam (Mar 06 2019 at 20:58):
Thanks for the reminder. I don't recall exactly when we started but it was probably around that time. I'll look at base.html - that should be straightforward. What's the best way to look for the other files that need to be updated (in specific folders, etc.)?
Eric Haas (Mar 06 2019 at 21:12):
um.... most of the templates haven;t changed much. you can look at the git hub history and see. Biggest changes in the framework foleder I've added the capability to generate table of contents and breadcrumbs and section based on the pages element in ig.xml. and added _config.yml for some globals and and applied to the layouts css for downloads and external icons. I would see if your source works with latest frameworks.
Rob Hausam (Mar 06 2019 at 22:48):
@Eric Haas It looks like we updated the framework folder in IPS on Nov. 2 and then you made updates on Dec. 13 to some of the framework files (Any.html, _includes/footer.html, etc.) and base.html (added the CodeSystem case block, which we didn't have) and ig.json and ig.ini, so we just missed that. Presumably the thing to do now is update the framework folder again and also base.html and any of the other files in the root that have changed? Should that do it?
Rob Hausam (Mar 06 2019 at 22:49):
Any potential issues if we do that update?
Eric Haas (Mar 06 2019 at 22:56):
I don't know, I keep all my IG's pretty much up to date with it.
Rob Hausam (Mar 06 2019 at 22:57):
OK. I'll see how it goes and will let you know (I expect it will be good).
Last updated: Apr 12 2022 at 19:14 UTC
